Attention needed from James Robinson, Owners Override and Yilong Li
James Robinson has uploaded the change for review![Open in Gerrit]()
Petr Hosek would like Owners Override to review this change authored by James Robinson.
Commit message
[escher][test] Avoid taking address of vector<bool> element
This is not allowed in C++ and newer libc++ implementations generate an
error. Instead, capture a reference to the whole vector and offset and
assign directly to the element.
Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000
Change diff
diff --git a/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc b/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
index 8afad30..15a5d90 100644
--- a/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
+++ b/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
@@ -114,7 +114,7 @@
const auto command_buffer_type = kCommandBufferTypes[i];
std::unique_ptr<BatchGpuDownloader> downloader =
BatchGpuDownloader::New(escher, command_buffer_type);
- downloader->Submit([done_ptr = &downloaders_done[i]]() { *done_ptr = true; });
+ downloader->Submit([&downloaders_done, i]() { downloaders_done[i] = true; });
}
EXPECT_VK_SUCCESS(escher->vk_device().waitIdle());
Change information
Files:
- M src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in GerritRelated details
Attention is currently required from:
- James Robinson
- Owners Override
- Yilong Li
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000
Gerrit-Change-Number: 1563473
Gerrit-PatchSet: 1
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
.