[XS] Change in fuchsia/fuchsia[main]: [escher][test] Avoid taking address of vector<bool> element

0 views
Skip to first unread message

'Petr Hosek (Gerrit)' via owners-override

unread,
3:10 AM (11 hours ago) 3:10 AM
to Owners Override
Attention needed from James Robinson, Owners Override and Yilong Li

James Robinson has uploaded the change for review

Petr Hosek would like Owners Override to review this change authored by James Robinson.

Commit message

[escher][test] Avoid taking address of vector<bool> element

This is not allowed in C++ and newer libc++ implementations generate an
error. Instead, capture a reference to the whole vector and offset and
assign directly to the element.
Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000

Change diff

diff --git a/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc b/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
index 8afad30..15a5d90 100644
--- a/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
+++ b/src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
@@ -114,7 +114,7 @@
const auto command_buffer_type = kCommandBufferTypes[i];
std::unique_ptr<BatchGpuDownloader> downloader =
BatchGpuDownloader::New(escher, command_buffer_type);
- downloader->Submit([done_ptr = &downloaders_done[i]]() { *done_ptr = true; });
+ downloader->Submit([&downloaders_done, i]() { downloaders_done[i] = true; });
}

EXPECT_VK_SUCCESS(escher->vk_device().waitIdle());

Change information

Files:
  • M src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • James Robinson
  • Owners Override
  • Yilong Li
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000
Gerrit-Change-Number: 1563473
Gerrit-PatchSet: 1
Gerrit-Owner: James Robinson <jam...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>
Gerrit-Attention: James Robinson <jam...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Yilong Li <li...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/65b0255e38dc06f05d40e2383a6fcb9589676b51-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Yilong Li (Gerrit)' via owners-override

unread,
10:00 AM (4 hours ago) 10:00 AM
to James Robinson, Yilong Li, Owners Override, Petr Hosek, GI Try Builder, CQ Bot
Attention needed from James Robinson and Owners Override

Yilong Li voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • James Robinson
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000
Gerrit-Change-Number: 1563473
Gerrit-PatchSet: 1
Gerrit-Owner: James Robinson <jam...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>
Gerrit-Attention: James Robinson <jam...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 03 Apr 2026 13:59:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6812f31b9d1c964d7255e41ae2e1743649667019-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
10:01 AM (4 hours ago) 10:01 AM
to James Robinson, Yilong Li, Owners Override, Petr Hosek, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[escher][test] Avoid taking address of vector<bool> element

This is not allowed in C++ and newer libc++ implementations generate an
error. Instead, capture a reference to the whole vector and offset and
assign directly to the element.
Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000
Reviewed-by: Yilong Li <li...@google.com>
Fuchsia-Auto-Submit: James Robinson <jam...@google.com>
Commit-Queue: James Robinson <jam...@google.com>
Reviewed-by: Petr Hosek <pho...@google.com>
Files:
  • M src/ui/lib/escher/test/renderer/batch_gpu_downloader_unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Petr Hosek, +2 by Yilong Li
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000
Gerrit-Change-Number: 1563473
Gerrit-PatchSet: 2
Gerrit-Owner: James Robinson <jam...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9841a9d7933516227351b6c53c9e1bbd6ff38a1b-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
10:04 AM (4 hours ago) 10:04 AM
to James Robinson, CQ Bot, Yilong Li, Owners Override, Petr Hosek, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ie5ce21603d0ad01f9b7e256dacae09d2dc327000
Gerrit-Change-Number: 1563473
Gerrit-PatchSet: 2
Gerrit-Owner: James Robinson <jam...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>
Gerrit-Comment-Date: Fri, 03 Apr 2026 14:04:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/98be7a9b3ea1f96d3a0ef07dccf5d2eb36ae802e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages