Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[M] Change in fuchsia/fuchsia[main]: [swd] Rename PackageBuilder::{new,api_level,abi_revision}.
2 views
Skip to first unread message
'Hunter Freyer (Gerrit)' via owners-override
Mar 19, 2024, 5:38:23 PM3/19/24
to Owners Override
Attention needed from Owners Override
Hunter Freyer has uploaded the change for review![]( "Open in Gerrit")
Hunter Freyer would like Owners Override to review this change.
Commit message
[swd] Rename PackageBuilder::{new,api_level,abi_revision}.
This lays the groundwork for ensuring that all users of PackageBuilder
specify an ABI revision. That work is complete when I've removed
`new_without_abi_revision`, `deprecated_api_level`, and
`deprecated_abi_revision`.
This lets me make the change over a few CLs, rather than one giant one.
Bug: 326095332Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Change diff
Change information
Files:
- M src/developer/ffx/plugins/assembly/src/compiled_package.rs
- M src/developer/ffx/plugins/assembly/src/operations/product/assembly_builder.rs
- M src/developer/ffx/plugins/assembly/src/subpackage_blobs_package.rs
- M src/lib/assembly/base_package/src/base_package.rs
- M src/lib/assembly/config_capabilities/src/config_capabilities.rs
- M src/lib/assembly/config_data/src/config_data.rs
- M src/lib/assembly/domain_config/src/domain_config.rs
- M src/lib/assembly/package_copy/src/package_copy.rs
- M src/lib/assembly/shell_commands/src/shell_commands.rs
- M src/lib/assembly/subpackage_blobs_package/src/subpackage_blobs_package.rs
- M src/lib/assembly/update_package/src/update_package.rs
- M src/starnix/tools/convert_tarball_to_starnix_container/src/main.rs
- M src/starnix/tools/gen_android_starnix_container/src/main.rs
- M src/sys/pkg/lib/fuchsia-pkg-testing/src/package.rs
- M src/sys/pkg/lib/fuchsia-pkg/src/package_builder.rs
- M src/sys/pkg/lib/fuchsia-pkg/src/package_manifest.rs
- M src/sys/pkg/lib/fuchsia-pkg/src/subpackages_build_manifest.rs
- M src/sys/pkg/lib/fuchsia-repo/src/package_manifest_watcher.rs
- M src/sys/pkg/lib/fuchsia-repo/src/repo_builder.rs
- M src/sys/pkg/lib/fuchsia-repo/src/test_utils.rs
- M src/sys/pkg/lib/package-tool/src/package_archive.rs
- M src/sys/pkg/lib/package-tool/src/package_build.rs
Change size: M
Delta: 22 files changed, 129 insertions(+), 83 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/758b48b4e355911691ca83d6290c703637545772-HTML%40fuchsia-review.googlesource.com.
'Hunter Freyer (Gerrit)' via owners-override
Mar 19, 2024, 5:38:24 PM3/19/24
to Owners Override, Erick Tryzelaar, CQ Bot
Attention needed from Owners Override
Hunter Freyer voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/758b48b4e355911691ca83d6290c703637545772-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Kevin Lindkvist (Gerrit)' via owners-override
Mar 20, 2024, 10:55:54 AM3/20/24
to Hunter Freyer, Owners Override, Erick Tryzelaar, CQ Bot
Attention needed from Hunter Freyer and Owners Override
Kevin Lindkvist voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Hunter Freyer
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ff562fd1fcd85adc501d2962743ffa6f679df764-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Mar 20, 2024, 1:29:12 PM3/20/24
to Hunter Freyer, Auto-Submit, Kevin Lindkvist, Owners Override, Erick Tryzelaar
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[swd] Rename PackageBuilder::{new,api_level,abi_revision}.
This lays the groundwork for ensuring that all users of PackageBuilder
specify an ABI revision. That work is complete when I've removed
`new_without_abi_revision`, `deprecated_api_level`, and
`deprecated_abi_revision`.
This lets me make the change over a few CLs, rather than one giant one.
Bug: 326095332Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Hunter Freyer <hjfr...@google.com>
Owners-Override: Kevin Lindkvist <lind...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Erick Tryzelaar
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b847905f95a84937d6af48d03cf30154db6f35af-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Mar 20, 2024, 1:33:07 PM3/20/24
to CQ Bot, Hunter Freyer, Auto-Submit, Kevin Lindkvist, Owners Override, Erick Tryzelaar
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/70d69cdfd53358b5bb01b4d716c28ff20ddc07db
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f925c9df11afebe48b646e73f0c9b0184d4bbbcc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages