[M] Change in fuchsia/fuchsia[main]: [swd] Rename PackageBuilder::{new,api_level,abi_revision}.

2 views
Skip to first unread message

'Hunter Freyer (Gerrit)' via owners-override

unread,
Mar 19, 2024, 5:38:23 PMMar 19
to Owners Override
Attention needed from Owners Override

Hunter Freyer has uploaded the change for review

Hunter Freyer would like Owners Override to review this change.

Commit message

[swd] Rename PackageBuilder::{new,api_level,abi_revision}.

This lays the groundwork for ensuring that all users of PackageBuilder
specify an ABI revision. That work is complete when I've removed
`new_without_abi_revision`, `deprecated_api_level`, and
`deprecated_abi_revision`.

This lets me make the change over a few CLs, rather than one giant one.

Bug: 326095332
Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042

Change diff


Change information

Files:
Change size: M
Delta: 22 files changed, 129 insertions(+), 83 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Gerrit-Change-Number: 1009332
Gerrit-PatchSet: 5
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/758b48b4e355911691ca83d6290c703637545772-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,
Mar 19, 2024, 5:38:24 PMMar 19
to Owners Override, Erick Tryzelaar, CQ Bot
Attention needed from Owners Override

Hunter Freyer voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Gerrit-Change-Number: 1009332
Gerrit-PatchSet: 5
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 19 Mar 2024 21:38:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/758b48b4e355911691ca83d6290c703637545772-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Kevin Lindkvist (Gerrit)' via owners-override

unread,
Mar 20, 2024, 10:55:54 AMMar 20
to Hunter Freyer, Owners Override, Erick Tryzelaar, CQ Bot
Attention needed from Hunter Freyer and Owners Override

Kevin Lindkvist voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hunter Freyer
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Gerrit-Change-Number: 1009332
Gerrit-PatchSet: 5
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Kevin Lindkvist <lind...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Hunter Freyer <hjfr...@google.com>
Gerrit-Comment-Date: Wed, 20 Mar 2024 14:55:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ff562fd1fcd85adc501d2962743ffa6f679df764-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 20, 2024, 1:29:12 PMMar 20
to Hunter Freyer, Auto-Submit, Kevin Lindkvist, Owners Override, Erick Tryzelaar

CQ Bot submitted the change

Change information

Commit message:
[swd] Rename PackageBuilder::{new,api_level,abi_revision}.

This lays the groundwork for ensuring that all users of PackageBuilder
specify an ABI revision. That work is complete when I've removed
`new_without_abi_revision`, `deprecated_api_level`, and
`deprecated_abi_revision`.

This lets me make the change over a few CLs, rather than one giant one.

Bug: 326095332
Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Fuchsia-Auto-Submit: Hunter Freyer <hjfr...@google.com>
Owners-Override: Kevin Lindkvist <lind...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Erick Tryzelaar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Gerrit-Change-Number: 1009332
Gerrit-PatchSet: 6
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Kevin Lindkvist <lind...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b847905f95a84937d6af48d03cf30154db6f35af-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 20, 2024, 1:33:07 PMMar 20
to CQ Bot, Hunter Freyer, Auto-Submit, Kevin Lindkvist, Owners Override, Erick Tryzelaar

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ibed60fd6968a567b23a8b3b73d2abfd4eb993042
Gerrit-Change-Number: 1009332
Gerrit-PatchSet: 6
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Kevin Lindkvist <lind...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 20 Mar 2024 17:32:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f925c9df11afebe48b646e73f0c9b0184d4bbbcc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages