[S] Change in fuchsia/fuchsia[main]: [diagnostics] Rename driver diagnostics crate

0 views
Skip to first unread message

'David Koloski (Gerrit)' via owners-override

unread,
Mar 3, 2026, 1:14:20 PM (3 days ago) Mar 3
to Owners Override
Attention needed from Owners Override

David Koloski has uploaded the change for review

David Koloski would like Owners Override to review this change.

Commit message

[diagnostics] Rename driver diagnostics crate

Our build system can handle multiple crates being used which have the
same name. However, when generating docs and using cargo-based
workflows, our GN-to-cargo generator does not handle it correctly. The
easiest way to fix this is to give the crates different names.
Change-Id: I0b288f96441d140f8468b3e779029c0bc9313d66

Change diff

diff --git a/sdk/lib/driver/component/rust/src/context.rs b/sdk/lib/driver/component/rust/src/context.rs
index 450e4c2..912d6f5 100644
--- a/sdk/lib/driver/component/rust/src/context.rs
+++ b/sdk/lib/driver/component/rust/src/context.rs
@@ -121,8 +121,8 @@
             }
         };
 
-        if let Err(e) = diagnostics_log::initialize(
-            diagnostics_log::PublishOptions::default()
+        if let Err(e) = driver_diagnostics_log::initialize(
+            driver_diagnostics_log::PublishOptions::default()
                 .use_log_sink(log_client)
                 .tags(&["driver", driver_name]),
         ) {
diff --git a/src/connectivity/wlan/drivers/wlansoftmac/rust_driver/c-binding/src/lib.rs b/src/connectivity/wlan/drivers/wlansoftmac/rust_driver/c-binding/src/lib.rs
index d191170..8646521 100644
--- a/src/connectivity/wlan/drivers/wlansoftmac/rust_driver/c-binding/src/lib.rs
+++ b/src/connectivity/wlan/drivers/wlansoftmac/rust_driver/c-binding/src/lib.rs
@@ -5,7 +5,7 @@
 //! C bindings for wlansoftmac-rust crate.
 #![deny(unsafe_op_in_unsafe_fn)]
 
-use diagnostics_log::PublishOptions;
+use driver_diagnostics_log::PublishOptions;
 use fuchsia_async::LocalExecutor;
 use log::{error, info};
 use std::ffi::c_void;
@@ -81,10 +81,10 @@
             return;
         }
         // Initialize logging with a tag that can be used to filter for forwarding to console
-        diagnostics_log::initialize_sync(
+        driver_diagnostics_log::initialize_sync(
             PublishOptions::default()
                 .tags(&["wlan"])
-                .enable_metatag(diagnostics_log::Metatag::Target),
+                .enable_metatag(driver_diagnostics_log::Metatag::Target),
         );
     });
 
diff --git a/src/connectivity/wlan/lib/mlme/fullmac/src/logger.rs b/src/connectivity/wlan/lib/mlme/fullmac/src/logger.rs
index 9818598..d47010ee 100644
--- a/src/connectivity/wlan/lib/mlme/fullmac/src/logger.rs
+++ b/src/connectivity/wlan/lib/mlme/fullmac/src/logger.rs
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-use diagnostics_log::PublishOptions;
+use driver_diagnostics_log::PublishOptions;
 use std::sync::Once;
 
 static LOGGER_ONCE: Once = Once::new();
@@ -15,10 +15,10 @@
         // Initialize logging with a tag that can be used to filter for forwarding to console
         // Ignore failures as they might occur due to previously installed logger by the driver
         // host.
-        if let Err(e) = diagnostics_log::initialize(
+        if let Err(e) = driver_diagnostics_log::initialize(
             PublishOptions::default()
                 .tags(&["wlan"])
-                .enable_metatag(diagnostics_log::Metatag::Target),
+                .enable_metatag(driver_diagnostics_log::Metatag::Target),
         ) {
             eprintln!("Error initializing logging at driver startup: {e}");
         }
diff --git a/src/lib/diagnostics/log/rust/BUILD.gn b/src/lib/diagnostics/log/rust/BUILD.gn
index 0592b14..f763610 100644
--- a/src/lib/diagnostics/log/rust/BUILD.gn
+++ b/src/lib/diagnostics/log/rust/BUILD.gn
@@ -68,7 +68,7 @@
 # support. This exists mostly to support driver libraries that don't use
 # this feature are forbidden from linking the symbol zx_take_startup_handle.
 rustc_library("no_startup_handle") {
-  name = "diagnostics_log"
+  name = "driver_diagnostics_log"
   edition = "2024"
   deps = LIB_DEPS
   sources = LIB_SOURCES

Change information

Files:
  • M sdk/lib/driver/component/rust/src/context.rs
  • M src/connectivity/wlan/drivers/wlansoftmac/rust_driver/c-binding/src/lib.rs
  • M src/connectivity/wlan/lib/mlme/fullmac/src/logger.rs
  • M src/lib/diagnostics/log/rust/BUILD.gn
Change size: S
Delta: 4 files changed, 9 insertions(+), 9 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I0b288f96441d140f8468b3e779029c0bc9313d66
Gerrit-Change-Number: 1525377
Gerrit-PatchSet: 1
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Brian Bosak <bbo...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/84de2f8abb22103c9deab55dedb5d5f1c37e2dd9-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Mar 3, 2026, 1:20:03 PM (3 days ago) Mar 3
to David Koloski, Owners Override, Brian Bosak
Attention needed from David Koloski and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I0b288f96441d140f8468b3e779029c0bc9313d66
Gerrit-Change-Number: 1525377
Gerrit-PatchSet: 1
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Brian Bosak <bbo...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 03 Mar 2026 18:19:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4e19cb69f1919b35a740443d9636ce378f4304b4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 3, 2026, 2:53:35 PM (3 days ago) Mar 3
to David Koloski, GI Try Builder, James Robinson, Owners Override, Brian Bosak

CQ Bot submitted the change

Change information

Commit message:
[diagnostics] Rename driver diagnostics crate

Our build system can handle multiple crates being used which have the
same name. However, when generating docs and using cargo-based
workflows, our GN-to-cargo generator does not handle it correctly. The
easiest way to fix this is to give the crates different names.
Change-Id: I0b288f96441d140f8468b3e779029c0bc9313d66
Fuchsia-Auto-Submit: David Koloski <dkol...@google.com>
Commit-Queue: David Koloski <dkol...@google.com>
Reviewed-by: Brian Bosak <bbo...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Files:
  • M sdk/lib/driver/component/rust/src/context.rs
  • M src/connectivity/wlan/drivers/wlansoftmac/rust_driver/c-binding/src/lib.rs
  • M src/connectivity/wlan/lib/mlme/fullmac/src/logger.rs
  • M src/lib/diagnostics/log/rust/BUILD.gn
Change size: S
Delta: 4 files changed, 9 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Brian Bosak
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I0b288f96441d140f8468b3e779029c0bc9313d66
Gerrit-Change-Number: 1525377
Gerrit-PatchSet: 2
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Brian Bosak <bbo...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/61ba878d2f1c6bba4bba9e6c1207225d7e724f17-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 3, 2026, 3:01:27 PM (3 days ago) Mar 3
to David Koloski, CQ Bot, GI Try Builder, James Robinson, Owners Override, Brian Bosak

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I0b288f96441d140f8468b3e779029c0bc9313d66
Gerrit-Change-Number: 1525377
Gerrit-PatchSet: 2
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Brian Bosak <bbo...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 03 Mar 2026 20:01:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d8f1bffa409583f873192a7506ffd107e07e076f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages