Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[L] Change in fuchsia/fuchsia[main]: [fuchsia.io] Rename permission flags
2 views
Skip to first unread message
'Brandon Castellano (Gerrit)' via owners-override
May 2, 2025, 1:15:58 PMMay 2
to Owners Override, Adam Barth, James Sullivan
Attention needed from Adam Barth, James Sullivan and Owners Override
Brandon Castellano has uploaded the change for review![]( "Open in Gerrit")
Brandon Castellano would like Owners Override, Adam Barth and James Sullivan to review this change.
Commit message
[fuchsia.io] Rename permission flags
To reduce confusion between the PERM_* constants and the PERM_* flags,
we rename the latter to match the definitions of those operations.
Also add a comment above the flags as a reminder that callers should
prefer to use the defined constants rather than individual flags.
Although this change rewrites history, all out-of-tree usages use
the PERM_READABLE, PERM_WRITABLE, and/or PERM_EXECUTABLE constants
rather than specifying individual permission flags.
Bug: 346585458
Change-Id: I3ffd0066e472f77fc7cdd92bb79ae4b0fc4d27ca
Change diff
Change information
Files:
- M sdk/ctf/tests/pkg/fdio/spawn_test.cc
- M sdk/fidl/fuchsia.io/directory.fidl
- M sdk/fidl/fuchsia.io/fuchsia.io.api
- M sdk/history/16/fuchsia.io.api_summary.json
- M sdk/history/23/fuchsia.io.api_summary.json
- M sdk/history/25/fuchsia.io.api_summary.json
- M sdk/history/26/fuchsia.io.api_summary.json
- M sdk/history/27/fuchsia.io.api_summary.json
- M sdk/history/NEXT/fuchsia.io.api_summary.json
- M sdk/lib/driver/component/cpp/tests/namespace_test.cc
- M sdk/lib/vfs/cpp/tests/remote_dir_test.cc
- M sdk/lib/zxio/pipe.cc
- M sdk/lib/zxio/tests/directory-test.cc
- M sdk/lib/zxio/tests/pipe-test.cc
- M sdk/lib/zxio/tests/transferable-test.cc
- M sdk/lib/zxio/tests/vmo-flags-test.cc
- M sdk/lib/zxio/tests/vmo-test.cc
- M sdk/lib/zxio/tests/zxio-test.rs
- M sdk/lib/zxio/transferable.cc
- M sdk/lib/zxio/vmo.cc
- M src/bringup/bin/bootpkg/src/lib.rs
- M src/connectivity/bluetooth/hci/vendor/broadcom/bt_hci_broadcom.cc
- M src/connectivity/bluetooth/hci/vendor/intel/device.cc
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/sdio/sdio_device.cc
- M src/devices/block/drivers/sdmmc/sdmmc-block-device.cc
- M src/devices/bus/drivers/platform/test/power-integration-test/test-power-integration-board.cc
- M src/devices/misc/drivers/compat/driver.cc
- M src/lib/fuchsia-fs/src/directory.rs
- M src/lib/fuchsia-fs/src/lib.rs
- M src/starnix/kernel/fs/fuchsia/remote.rs
- M src/starnix/kernel/vfs/file_server.rs
- M src/storage/conformance/src/flags.rs
- M src/storage/conformance/tests/clone.rs
- M src/storage/conformance/tests/directory/create.rs
- M src/storage/conformance/tests/directory/link.rs
- M src/storage/conformance/tests/directory/open.rs
- M src/storage/conformance/tests/flags.rs
- M src/storage/conformance/tests/get_connection_info.rs
- M src/storage/conformance/tests/remote.rs
- M src/storage/conformance/tests/service.rs
- M src/storage/fuchsia-fatfs/src/directory.rs
- M src/storage/lib/vfs/cpp/connection/directory_connection.cc
- M src/storage/lib/vfs/cpp/tests/connection_integration_tests.cc
- M src/storage/lib/vfs/cpp/tests/connection_rights_tests.cc
- M src/storage/lib/vfs/cpp/vfs_types.cc
- M src/storage/lib/vfs/rust/src/protocols.rs
- M src/storage/lib/vfs/rust/src/remote/tests.rs
- M src/sys/pkg/lib/blobfs/src/mock.rs
- M src/sys/pkg/lib/isolated-swd/src/cache.rs
- M src/virtualization/bin/guest_manager_rs/src/guest_config.rs
Change size: L
Delta: 50 files changed, 239 insertions(+), 219 deletions(-)
Related details
Attention is currently required from:
- Adam Barth
- James Sullivan
- Owners Override
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/76db4fbf26753b8b4d88db4997128ff0e916cd72-HTML%40fuchsia-review.googlesource.com.
'Brandon Castellano (Gerrit)' via owners-override
May 2, 2025, 1:16:01 PMMay 2
to Adam Barth, James Sullivan, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Barth, James Sullivan and Owners Override
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Adam Barth
- James Sullivan
- Owners Override
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/76db4fbf26753b8b4d88db4997128ff0e916cd72-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
May 2, 2025, 1:21:17 PMMay 2
to Brandon Castellano, James Sullivan, Owners Override, GI Try Builder, CQ Bot
Attention needed from Brandon Castellano, James Sullivan and Owners Override
Adam Barth voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Brandon Castellano
- James Sullivan
- Owners Override
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e05ccf2b78b0ba5d221a670ecb23a0bc65b205f6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
May 2, 2025, 1:21:25 PMMay 2
to Brandon Castellano, James Sullivan, Owners Override, GI Try Builder, CQ Bot
Attention needed from Brandon Castellano, James Sullivan and Owners Override
Adam Barth voted![]( "Open in Gerrit")
| API-Review | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Brandon Castellano
- James Sullivan
- Owners Override
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fcc6c99b3bdaa98504286408de5d2b8d1b6128a7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'James Sullivan (Gerrit)' via owners-override
May 2, 2025, 1:43:31 PMMay 2
to Brandon Castellano, Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Brandon Castellano
James Sullivan voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brandon Castellano
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9814de7f9ff0056c350ac1c08f16a37df8318e42-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Brandon Castellano (Gerrit)' via owners-override
May 5, 2025, 5:02:37 PMMay 5
to James Sullivan, Adam Barth, Owners Override, GI Try Builder, CQ Bot
Brandon Castellano voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b058536ad9542e93274e1d274d4e6eab767b6804-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
May 5, 2025, 10:05:16 PMMay 5
to Brandon Castellano, James Sullivan, Adam Barth, Owners Override, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fuchsia.io] Rename permission flags
To reduce confusion between the PERM_* constants and the PERM_* flags,
we rename the latter to match the definitions of those operations.
Also add a comment above the flags as a reminder that callers should
prefer to use the defined constants rather than individual flags.
Although this change rewrites history, all out-of-tree usages use
the PERM_READABLE, PERM_WRITABLE, and/or PERM_EXECUTABLE constants
rather than specifying individual permission flags.
Bug: 346585458
Change-Id: I3ffd0066e472f77fc7cdd92bb79ae4b0fc4d27ca
Reviewed-by: Adam Barth <aba...@google.com>
Reviewed-by: James Sullivan <jfsu...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
API-Review: Adam Barth <aba...@google.com>
Commit-Queue: Brandon Castellano <bcas...@google.com>
Branch: refs/heads/main
Submit Requirements:
API-Review: +1 by Adam Barth
Code-Review: +2 by Adam Barth, +2 by James Sullivan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bcc47ac80112b5e9c4d1a7c9f5bb31f1438a3cd2-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
May 5, 2025, 10:08:07 PMMay 5
to Brandon Castellano, CQ Bot, James Sullivan, Adam Barth, Owners Override, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/047b1ad133b93e67ff0dc6dec7f64bd82e51e984
Related details
Attention set is empty
Submit Requirements:
API-Review
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f87b6e354e56661b8b291656b15ff6d13174cddb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages