[L] Change in fuchsia/fuchsia[main]: [role_manager] Add fuchsia.scheduler.RoleManager routes
1 view
Skip to first unread message
'Anirudh Mathukumilli (Gerrit)' via owners-override
Feb 22, 2024, 4:32:34 PM2/22/24
to Owners Override
Attention needed from Owners Override
Anirudh Mathukumilli has uploaded the change for review![]( "Open in Gerrit")
Anirudh Mathukumilli would like Owners Override to review this change.
Commit message
[role_manager] Add fuchsia.scheduler.RoleManager routes
Adds a fuchsia.scheduler.RoleManager route wherever there is an existing
fuchsia.scheduler.ProfileProvider route, except when routing from the
ProfileProvider itself or its tests. This is the first step of a
sof-transition from the ProfileProvider to the RoleManager. Future CLs
will swap clients over to the new service and then delete the
ProfileProvider routes.
This CL was mostly auto-generated by a python script that searched for
any fuchsia.scheduler.ProfileProvider route in a CML file and added a
fuchsia.scheduler.RoleManager route. This of course does not apply to
the bootstrap.cml/core.cml/root.cml/etc. files, which required some more
custom routing rules.
I then verified the output of the script with another script that
compared the existence of both routes and printed out the differences:
```
------------------------------------------------------------------
Places that have a role manager route but no profile provider one:
------------------------------------------------------------------
./src/sys/bootstrap/meta/bootstrap.cml:1386
./src/sys/bootstrap/meta/bootstrap.cml:673
./src/sys/bootstrap/meta/bootstrap.cml:777
./src/sys/bootstrap/meta/bootstrap.cml:793
./src/zircon/bin/role_manager/meta/role_manager.cml:12
./src/zircon/bin/role_manager/meta/role_manager.cml:27
./src/zircon/bin/role_manager/testing/fake/meta/fake_role_manager.cml:12
./src/zircon/bin/role_manager/testing/fake/meta/fake_role_manager.cml:17
------------------------------------------------------------------
Places that have a profile provider route but no role manager one:
------------------------------------------------------------------
./src/bringup/bin/svchost/meta/svchost.cml:15
./src/bringup/bin/svchost/meta/svchost.cml:45
./src/sys/bootstrap/meta/bootstrap.cml:1380
./src/sys/bootstrap/meta/bootstrap.cml:663
./src/sys/bootstrap/meta/bootstrap.cml:773
./src/sys/bootstrap/meta/bootstrap.cml:785
./src/zircon/tests/profile/meta/profile-test.cml:15
```
These are all expected differences (they either are bootstrap routes,
which must be unique, or unique to either the RoleManager or
ProfileProvider services and tests). Therefore, I believe this CL
correctly routes RoleManager to any realm/component that has access to
ProfileProvider.
Bug: 323262398
Change-Id: I687c91604826ce63529b8e0af46bc0bbb6d7c8ea
Change diff
Change information
Files:
- M sdk/ctf/test_realm/meta/test-collection.shard.cml
- M sdk/ctf/tests/fidl/fuchsia.ui.composition/meta/test-root.cml
- M src/bringup/bin/console-launcher/meta/console-launcher.cml
- M src/bringup/bin/netsvc/meta/netsvc.cml
- M src/chromium/web_runner_tests/meta/web_runner_integration_tests.cml
- M src/cobalt/bin/app/meta/cobalt_base.cml
- M src/cobalt/bin/meta/base/cobalt_testapp.shard.cml
- M src/connectivity/network/dns/meta/client.shard.cml
- M src/connectivity/network/dns/meta/dns_resolver_base.shard.cml
- M src/connectivity/network/drivers/network-device/meta/network-device.cml
- M src/connectivity/network/meta/common.shard.cml
- M src/connectivity/network/netstack/meta/netstack2-prod.shard.cml
- M src/connectivity/network/testing/netemul/guest/meta/netemul-guest.cml
- M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/meta/brcmfmac_sdio.cml
- M src/developer/memory/monitor/meta/memory_monitor.core_shard.cml
- M src/developer/memory/monitor/meta/memory_monitor_base.shard.cml
- M src/developer/sshd-host/meta/sshd-host.cml
- M src/developer/sshd-host/meta/sshd-host.core_shard.cml
- M src/developer/sshd-host/meta/sshd.cml
- M src/devices/bin/driver_host/meta/driver_host.cml
- M src/devices/bin/driver_manager/meta/driver-manager-base.shard.cml
- M src/devices/bin/driver_manager/meta/driver_manager.cml
- M src/devices/bin/driver_runtime/meta/driver_runtime_scheduler_role_test.cml
- M src/devices/block/drivers/core/meta/core.cml
- M src/devices/block/drivers/ftl/meta/ftl.cml
- M src/devices/block/drivers/sdmmc/meta/sdmmc.cml
- M src/devices/gpio/drivers/gpio/meta/gpio.cml
- M src/devices/i2c/drivers/aml-i2c/meta/aml-i2c.cml
- M src/devices/i2c/drivers/i2c/meta/i2c.cml
- M src/devices/nand/drivers/nand/meta/nand.cml
- M src/devices/power/drivers/nelson-brownout-protection/meta/nelson-brownout-protection.cml
- M src/devices/securemem/drivers/aml-securemem/meta/aml-securemem.cml
- M src/devices/spi/drivers/aml-spi/meta/aml-spi.cml
- M src/devices/sysmem/drivers/sysmem/meta/sysmem.cml
- M src/devices/tee/drivers/optee/meta/optee.cml
- M src/devices/usb/drivers/dwc2/meta/dwc2.cml
- M src/devices/usb/drivers/xhci/meta/xhci.cml
- M src/graphics/display/drivers/amlogic-display/meta/amlogic-display.cml
- M src/graphics/display/drivers/coordinator/meta/display-coordinator.cml
- M src/graphics/display/drivers/intel-i915/meta/intel-i915.cml
- M src/graphics/drivers/msd-arm-mali/meta/msd_arm.shard.cml
- M src/graphics/drivers/msd-arm-mali/tests/meta/msd_arm_mali_nonhardware_tests.cml
- M src/graphics/drivers/msd-intel-gen/meta/msd_intel.cml
- M src/graphics/drivers/msd-vsi-vip/meta/msd_vsi.cml
- M src/graphics/drivers/msd-vsi-vip/meta/msd_vsi_test.cml
- M src/lib/ui/carnelian/meta/carnelian_integration_test.cml
- M src/media/audio/audio_core/meta/audio_core.cml
- M src/media/audio/audio_core/meta/audio_core.core_shard.base.cml
- M src/media/audio/audio_core/testing/integration/meta/shard.cml
- M src/media/audio/audio_core/tools/output_pipeline_benchmark/meta/pipeline_benchmark.cml
- M src/media/audio/consumer/meta/audio_consumer.cml
- M src/media/audio/consumer/meta/audio_consumer.core_shard.cml
- M src/media/audio/drivers/intel-hda/controller/meta/intel-hda.cml
- M src/media/audio/drivers/tests/meta/audio_driver_tests.cml
- M src/media/drivers/amlogic_decoder/meta/amlogic_video_decoder-component.cml
- M src/recovery/system/meta/tests/system_recovery_fdr_test.cml
- M src/security/tests/pkg_test/tests/access_ota_blob_as_executable/meta/access_ota_blob_as_executable.cml
- M src/security/tests/pkg_test/tests/bad_signature_update/meta/bad_signature_update.cml
- M src/starnix/kernel/meta/starnix_kernel.cml
- M src/starnix/runner/meta/starnix_runner.cml
- M src/starnix/runner/meta/starnix_runner.core_shard.cml
- M src/starnix/tests/starnix_test_common.shard.cml
- M src/storage/blobfs/bin/meta/blobfs.cml
- M src/storage/blobfs/meta/decompressor_sandbox.cml
- M src/storage/f2fs/bin/meta/f2fs.cml
- M src/storage/fshost/meta/base_fshost.cml
- M src/storage/fshost/meta/blobfs_fshost.cml
- M src/storage/fshost/meta/f2fs_fshost.cml
- M src/storage/fshost/meta/minfs_fshost.cml
- M src/storage/memfs/meta/memfs.cml
- M src/storage/minfs/bin/meta/minfs.cml
- M src/sys/bootstrap/meta/bootstrap.cml
- M src/sys/core/meta/core.cml
- M src/sys/root/root.cml
- M src/sys/test_manager/meta/common.shard.cml
- M src/sys/test_manager/meta/test_manager.core_shard.cml
- M src/sys/testing/meta/chromium_system_test_realm.shard.cml
- M src/sys/testing/meta/chromium_test_realm.shard.cml
- M src/sys/testing/meta/system-tests.shard.cml
- M src/sys/testing/meta/test_realm.core_shard.cml
- M src/tests/microbenchmarks/meta/fuchsia_microbenchmarks.cml
- M src/tests/microbenchmarks/meta/starnix_microbenchmarks.cml
- M src/ui/a11y/lib/semantics/tests/meta/web-semantics-test.cml
- M src/ui/a11y/lib/view/tests/meta/flatland-a11y-view-test.cml
- M src/ui/a11y/lib/view/tests/meta/flatland-scene-integration-test.cml
- M src/ui/bin/scene_manager/meta/scene_manager_bin_test.cml
- M src/ui/input/drivers/focaltech/meta/focaltech-sherlock.cml
- M src/ui/input/drivers/focaltech/meta/focaltech.cml
- M src/ui/input/drivers/goodix/meta/goodix.cml
- M src/ui/input/drivers/gt6853/meta/gt6853.cml
- M src/ui/meta/scenic_base_routes.shard.cml
- M src/ui/meta/ui_routes_base.shard.cml
- M src/ui/scenic/bin/meta/scenic.cml
- M src/ui/scenic/meta/scenic_util_tests.cml
- M src/ui/scenic/tests/meta/scenic_integration_test_base.shard.cml
- M src/ui/testing/context/meta/context-factory.cml
- M src/ui/testing/test_ui_stack/meta/test-ui-stack.cml
- M src/ui/tests/conformance/meta/conformance-test-base.shard.cml
- M src/ui/tests/integration_graphics_tests/carnelian-pixel-tests/meta/carnelian_pixel_test.cml
- M src/ui/tests/integration_graphics_tests/web-pixel-tests/meta/web_runner_pixeltest.cml
- M src/ui/tests/integration_input_tests/factory-reset-handler/meta/factory-reset-handler-test.cml
- M src/ui/tests/integration_input_tests/mouse/meta/mouse-input-test.cml
- M src/ui/tests/integration_input_tests/starnix-touch/meta/starnix-touch-test.cml
- M src/ui/tests/integration_input_tests/text-input/meta/text-input-test.cml
- M src/ui/tests/integration_input_tests/touch/meta/pointerinjector-config-test.cml
- M src/ui/tests/integration_input_tests/touch/meta/touch-input-test.cml
- M src/ui/tests/integration_input_tests/virtual-keyboard/meta/virtual-keyboard-test.cml
- M src/ui/tests/integration_input_tests/web-touch-input/meta/web-touch-input-test.cml
- M src/virtualization/bin/guest_manager/meta/debian_guest_manager.core_shard.cml
- M src/virtualization/bin/guest_manager/meta/guest_manager.cml
- M src/virtualization/bin/guest_manager/meta/termina_guest_manager.core_shard.cml
- M src/virtualization/bin/guest_manager/meta/zircon_guest_manager.core_shard.cml
- M src/virtualization/bin/vmm/device/tests/meta/virtio_block_device_tests.cml
- M src/virtualization/bin/vmm/device/tests/meta/virtio_console_device_tests.cml
- M src/virtualization/bin/vmm/device/tests/meta/virtio_gpu_device_tests.cml
- M src/virtualization/bin/vmm/device/tests/meta/virtio_magma_device_tests.cml
- M src/virtualization/bin/vmm/device/tests/meta/virtio_sound_device_tests.cml
- M src/virtualization/bin/vmm/device/virtio_magma/meta/virtio_magma_unittests.cml
- M src/virtualization/bin/vmm/meta/virtio_sound.cml
- M src/virtualization/bin/vmm/meta/vmm.cml
- M src/virtualization/bin/vmm_launcher/meta/vmm_launcher.cml
- M src/virtualization/bin/vmm_launcher/meta/vmm_launcher.core_shard.cml
- M src/virtualization/lib/guest_interaction/meta/server_daemon_test.cml
- M src/virtualization/tests/meta/virtualization_integration_test.cml
- M src/zircon/bin/hwstress/meta/hwstress.cml
- M src/zircon/bin/hwstress/meta/hwstress.core_shard.cml
- M src/zircon/bin/hwstress/meta/hwstress_v2_test.cml
Change size: L
Delta: 127 files changed, 322 insertions(+), 37 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/033a77405e45e1c06c9021b115de003174f10e2f-HTML%40fuchsia-review.googlesource.com.
'Alice Neels (Gerrit)' via owners-override
Feb 22, 2024, 4:58:41 PM2/22/24
to Anirudh Mathukumilli, Owners Override, Corey Tabaka, CQ Bot, RubberStamper 🤖?
Attention needed from Anirudh Mathukumilli and Owners Override
Alice Neels voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alice Neels
| Owners-Override | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Alice Neels . resolved
If this proves hard to land, please consider splitting it up.
Related details
Attention is currently required from:
- Anirudh Mathukumilli
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e40c5fe2f6cb3c523e98d9c9248e4ed7f205cd88-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Anirudh Mathukumilli (Gerrit)' via owners-override
Feb 22, 2024, 5:22:07 PM2/22/24
to Alice Neels, Owners Override, Corey Tabaka, CQ Bot, RubberStamper 🤖?
Attention needed from Owners Override
Anirudh Mathukumilli voted![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/edab921d72ce9a59597ab6266b4b1cccb69628f5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Feb 22, 2024, 6:05:08 PM2/22/24
to Anirudh Mathukumilli, Alice Neels, Owners Override, Corey Tabaka, RubberStamper 🤖?
CQ Bot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit-Queue: Anirudh Mathukumilli <rudy...@google.com>
Fuchsia-Auto-Submit: Anirudh Mathukumilli <rudy...@google.com>
Reviewed-by: Corey Tabaka <ei...@google.com>
Owners-Override: Alice Neels <nee...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Corey Tabaka
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/05debdf881c2bc8b47b175d16e3c83788e790d1b-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Feb 22, 2024, 6:13:02 PM2/22/24
to Anirudh Mathukumilli, CQ Bot, Alice Neels, Owners Override, Corey Tabaka, RubberStamper 🤖?
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/ce1af52faa636a1de0894e1770b88bd8974abb57
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6744393ee897ceaee55df13537a61446d734bb0f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages