'Erick Tryzelaar (Gerrit)' via owners-override

unread,

May 6, 2026, 12:40:50 PM (yesterday) May 6

to Owners Override

Attention needed from Owners Override

Erick Tryzelaar has uploaded the change for review

Erick Tryzelaar would like Owners Override to review this change.

Commit message

[rust] Fix upcoming clippy lints

This fixes some lints in an upcoming rust toolchain roll, which now
warns on:

* unnecessary borrows in format strings
* unnecssary `.to_string()` on types that implement display in format
  strings.
* suggests directly using `.values_mut()` over using `for (_, value) in
  ....iter_mut()`.

Change-Id: I74f721be570fe3b701b85032b3b3bdedaa1a24bb

Change diff

Change information

Files:

M build/assembly/tools/assembly_config/src/platform_artifacts.rs
M build/assembly/tools/assembly_config/src/product_config.rs
M build/assembly/tools/generate_assembly_scrutiny_configs/src/main.rs
M examples/fidl/calculator/rust/client/src/main.rs
M examples/fidl/calculator/rust_next/client/src/main.rs
M examples/fidl/new/canvas/client_requested_draw/rust/client/src/main.rs
M examples/fidl/new/canvas/client_requested_draw/rust_next/client/src/main.rs
M examples/fidl/new/key_value_store/support_trees/rust/server/src/main.rs
M examples/fidl/new/key_value_store/support_trees/rust_next/server/src/main.rs
M examples/fidl/new/key_value_store/use_generic_values/rust/client/src/main.rs
M examples/fidl/new/key_value_store/use_generic_values/rust/server/src/main.rs
M examples/fidl/new/key_value_store/use_generic_values/rust_next/client/src/main.rs
M examples/fidl/new/key_value_store/use_generic_values/rust_next/server/src/main.rs
M src/bringup/bin/ptysvc/src/ptysvc.rs
M src/connectivity/bluetooth/profiles/bt-hfp-hands-free/src/peer/calls.rs
M src/connectivity/bluetooth/tools/bt-avrcp-controller/src/main.rs
M src/connectivity/lib/at-commands/codegen/src/codegen/raise.rs
M src/connectivity/lib/at-commands/codegen/src/main.rs
M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/border_agent.rs
M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/srp_proxy/discovery_proxy.rs
M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/tasks.rs
M src/connectivity/lowpan/lib/lowpan_driver_common/src/spinel/mock/fake_device_client.rs
M src/connectivity/lowpan/lib/lowpan_driver_common/src/spinel/types/mod.rs
M src/connectivity/lowpan/lib/openthread_fuchsia/src/backing/nat64.rs
M src/connectivity/lowpan/service/src/service.rs
M src/connectivity/lowpan/tools/lowpanctl/src/status_command.rs
M src/connectivity/network/dhcpv4/lib/src/server.rs
M src/connectivity/network/netstack3/core/device/src/id.rs
M src/connectivity/network/netstack3/core/ip/src/gmp.rs
M src/connectivity/policy/netcfg/src/lib.rs
M src/connectivity/wlan/lib/mlme/rust/src/minstrel.rs
M src/connectivity/wlan/lib/sme/src/ap/mod.rs
M src/connectivity/wlan/lib/telemetry/src/processors/power.rs
M src/connectivity/wlan/wlancfg/src/client/connection_selection/mod.rs
M src/connectivity/wlan/wlancfg/src/client/roaming/roam_monitor/stationary_monitor.rs
M src/connectivity/wlan/wlancfg/src/mode_management/phy_manager.rs
M src/developer/ffx/daemon/protocols/target_collection/src/lib.rs
M src/developer/ffx/daemon/server/src/daemon.rs
M src/developer/ffx/daemon/src/lib.rs
M src/developer/ffx/daemon/target/src/target.rs
M src/developer/ffx/daemon/target/src/target_collection.rs
M src/developer/ffx/lib/daemonize/src/lib.rs
M src/developer/ffx/lib/emulator_instance/src/targets.rs
M src/developer/ffx/lib/fastboot_file_discovery/src/lib.rs
M src/developer/ffx/lib/mdns_discovery/src/lib.rs
M src/developer/ffx/lib/ssh/src/keys.rs
M src/developer/ffx/plugins/assembly/src/operations/size_check/common.rs
M src/developer/ffx/plugins/assembly/src/subpackage_blobs_package.rs
M src/developer/ffx/plugins/audio/device/src/lib.rs
M src/developer/ffx/plugins/config/src/lib.rs
M src/developer/ffx/plugins/doctor/src/ledger_view.rs
M src/developer/ffx/plugins/doctor/src/lib.rs
M src/developer/ffx/plugins/emulator/commands/start/src/editor.rs
M src/developer/ffx/plugins/emulator/commands/start/src/pbm.rs
M src/developer/ffx/plugins/emulator/configuration/src/conversions.rs
M src/developer/ffx/plugins/emulator/engines/src/arg_templates.rs
M src/developer/ffx/plugins/emulator/engines/src/lib.rs
M src/developer/ffx/plugins/emulator/engines/src/qemu_based/mod.rs
M src/developer/ffx/plugins/product/get_artifacts/src/lib.rs
M src/developer/ffx/plugins/product/get_version/src/unique_release_info.rs
M src/developer/ffx/plugins/product/list/src/lib.rs
M src/developer/ffx/plugins/product_bundle/create/src/lib.rs
M src/developer/ffx/plugins/scrutiny/verify/src/bootfs.rs
M src/developer/ffx/plugins/session/add/src/lib.rs
M src/developer/ffx/plugins/session/remove/src/lib.rs
M src/developer/ffx/plugins/target/snapshot/src/lib.rs
M src/developer/ffx/tools/wm/focus/src/lib.rs
M src/developer/ffx/tools/wm/set-order/src/lib.rs
M src/devices/bin/driver-index/src/indexer.rs
M src/devices/bin/driver-index/src/resolved_driver.rs
M src/devices/bin/driver_tools/common/src/lib.rs
M src/diagnostics/archivist/src/inspect/servers/inspect_sink.rs
M src/diagnostics/archivist/src/logs/listener.rs
M src/diagnostics/lib/triage/src/config.rs
M src/diagnostics/lib/triage/src/metrics.rs
M src/diagnostics/validator/inspect/src/data.rs
M src/factory/factory_store_providers/src/config.rs
M src/factory/factory_store_providers/src/main.rs
M src/factory/factory_store_providers/src/validators/size.rs
M src/factory/fake_factory_store_providers/src/main.rs
M src/fonts/offset_string/src/lib.rs
M src/fonts/src/font_service/builder.rs
M src/fonts/src/font_service/mod.rs
M src/fonts/src/main.rs
M src/fonts/tools/manifest_generator/src/font_db.rs
M src/fonts/tools/manifest_generator/src/generator.rs
M src/intl/strings_to_json/src/main.rs
M src/lib/analytics/rust/src/env_info.rs
M src/lib/analytics/rust/src/metrics_state.rs
M src/lib/assembly/artifact_cache/src/build_api.rs
M src/lib/assembly/artifact_cache/src/cipd.rs
M src/lib/assembly/artifact_cache/src/mos.rs
M src/lib/assembly/assembled_system/src/assembled_system.rs
M src/lib/assembly/assembled_system/src/base_package.rs
M src/lib/assembly/assembled_system/src/fvm.rs
M src/lib/assembly/assembled_system/src/image.rs
M src/lib/assembly/assembled_system/src/vbmeta.rs
M src/lib/assembly/assembled_system/src/zbi.rs
M src/lib/assembly/blobfs/src/manifest.rs
M src/lib/assembly/components/src/components.rs
M src/lib/assembly/config_capabilities/src/config_capabilities.rs
M src/lib/assembly/config_schema/src/board_input_bundle.rs
M src/lib/assembly/config_schema/src/platform_settings/icu_config.rs
M src/lib/assembly/config_schema/src/product_config.rs
M src/lib/assembly/container/src/assembly_container.rs
M src/lib/assembly/domain_config/src/domain_config.rs
M src/lib/assembly/image_assembly_config_builder/src/compiled_package.rs
M src/lib/assembly/image_assembly_config_builder/src/image_assembly_config_builder.rs
M src/lib/assembly/image_assembly_config_builder/src/product_assembly.rs
M src/lib/assembly/images_config/src/board_filesystem_config.rs
M src/lib/assembly/package_copy/src/package_copy.rs
M src/lib/assembly/package_list/src/package_list.rs
M src/lib/assembly/partitions_config/src/partition_image_mapper.rs
M src/lib/assembly/partitions_config/src/partitions_config.rs
M src/lib/assembly/platform_configuration/src/common.rs
M src/lib/assembly/platform_configuration/src/subsystems/diagnostics.rs
M src/lib/assembly/platform_configuration/src/subsystems/recovery.rs
M src/lib/assembly/platform_configuration/src/subsystems/session.rs
M src/lib/assembly/platform_configuration/src/subsystems/swd.rs
M src/lib/assembly/platform_configuration/src/subsystems/trusted_apps.rs
M src/lib/assembly/platform_configuration/src/util.rs
M src/lib/assembly/product_bundle/src/product_bundle_builder.rs
M src/lib/assembly/product_bundle/src/v2.rs
M src/lib/assembly/shell_commands/src/shell_commands.rs
M src/lib/assembly/update_package/src/update_package.rs
M src/lib/assembly/util/src/insert_unique.rs
M src/lib/diagnostics/selectors-ext/src/inspect.rs
M src/lib/diagnostics/testing/fake-archive-accessor/src/fake_archive_accessor/archivist_server.rs
M src/lib/fake-clock/svc/src/main.rs
M src/lib/fidl_table_validation/fidl_table_validation_derive/src/lib.rs
M src/lib/fuchsia-component-test/realm_builder_server/src/main.rs
M src/lib/fuchsia-component-test/realm_builder_server/src/resolver.rs
M src/lib/icu_data/rust/icu_data/src/lib.rs
M src/lib/intl/lookup/rust/src/lib.rs
M src/lib/intl/strings/src/json.rs
M src/lib/intl/strings/src/message_ids.rs
M src/lib/intl/strings/src/parser.rs
M src/lib/testing/expectation/preprocess/src/main.rs
M src/lib/ui/input-synthesis/src/modern_backend/input_device.rs
M src/lib/ui/input-synthesis/src/synthesizer.rs
M src/media/audio/services/ffxdaemon/src/main.rs
M src/power/broker/src/broker.rs
M src/power/broker/src/credentials.rs
M src/power/broker/src/main.rs
M src/power/cpu-manager/src/syscall_handler.rs
M src/power/power-manager/src/thermal_load_driver.rs
M src/power/system-activity-governor/src/system_activity_governor.rs
M src/recovery/lib/installer/src/partition.rs
M src/recovery/system/src/ota.rs
M src/security/lib/scrutiny/frontend/src/verify/pre_signing.rs
M src/security/lib/scrutiny/frontend/src/verify/route_sources.rs
M src/security/lib/scrutiny/utils/src/artifact.rs
M src/security/lib/scrutiny/utils/src/fs.rs
M src/settings/service/src/agent/earcons/bluetooth_handler.rs
M src/starnix/kernel/runner/src/component_runner.rs
M src/starnix/kernel/runner/src/container.rs
M src/starnix/lib/starnix_container/src/lib.rs
M src/storage/factory/export_ffs/src/main.rs
M src/storage/fshost/src/matcher/config_matcher.rs
M src/storage/fxfs/make-blob-image/src/lib.rs
M src/storage/fxfs/src/object_store.rs
M src/storage/fxfs/src/object_store/data_object_handle.rs
M src/storage/lib/vfs/rust/macros/src/lib.rs
M src/sys/component_manager/src/builtin_environment.rs
M src/sys/component_manager/src/model/component/instance.rs
M src/sys/component_manager/src/model/component/mod.rs
M src/sys/component_manager/src/model/routing/aggregate_router.rs
M src/sys/lib/cm_fidl_validator/src/error.rs
M src/sys/lib/component_debug/src/cli/doctor.rs
M src/sys/lib/component_debug/src/cli/graph.rs
M src/sys/lib/component_debug/src/cli/route.rs
M src/sys/lib/component_debug/src/copy.rs
M src/sys/lib/component_debug/src/io.rs
M src/sys/lib/component_debug/src/storage/delete.rs
M src/sys/lib/elf_runner/src/lib.rs
M src/sys/lib/routing/src/bedrock/program_output_dict.rs
M src/sys/lib/routing/src/bedrock/use_dictionary_router.rs
M src/sys/lib/routing/src/component_instance.rs
M src/sys/lib/routing/src/lib.rs
M src/sys/pkg/bin/omaha-client/src/fidl.rs
M src/sys/pkg/bin/pkg-resolver/src/inspect_util.rs
M src/sys/pkg/bin/pkg-resolver/src/main.rs
M src/sys/pkg/lib/fuchsia-pkg/src/package_build_manifest.rs
M src/sys/pkg/lib/fuchsia-pkg/src/package_manifest.rs
M src/sys/pkg/lib/fuchsia-pkg/src/subpackages_build_manifest.rs
M src/sys/pkg/lib/package-tool/src/package_archive.rs
M src/sys/pkg/lib/package-tool/src/repo_publish.rs
M src/sys/run_test_suite/directory/src/testing.rs
M src/sys/run_test_suite/src/output/shell/mod.rs
M src/sys/time/lib/push-source/src/lib.rs
M src/sys/time/timekeeper/alarms/src/lib.rs
M src/sys/time/timekeeper/src/clock_manager.rs
M src/sys/time/timekeeper/src/diagnostics/inspect.rs
M src/sys/time/timekeeper/src/main.rs
M src/sys/time/timekeeper/src/time_source_manager.rs
M src/sys/tools/debug-dash-launcher/src/trampoline.rs
M src/testing/fidl/intl_property_manager/src/main.rs
M src/testing/sl4f/src/server/sl4f_executor.rs
M src/ui/bin/brightness_manager/src/backlight.rs
M src/ui/bin/text/src/keyboard/keyboard3.rs
M src/ui/bin/text/src/legacy_ime/state.rs
M src/ui/lib/input_pipeline/src/dead_keys_handler.rs
M src/ui/lib/input_pipeline/src/display_ownership.rs
M src/ui/lib/input_pipeline/src/ime_handler.rs
M src/ui/lib/input_pipeline/src/input_device.rs
M src/ui/lib/input_pipeline/src/input_pipeline.rs
M src/ui/lib/input_pipeline/src/keyboard_binding.rs
M src/ui/lib/input_pipeline/src/modifier_handler.rs
M src/ui/lib/input_pipeline/src/text_settings_handler.rs
M src/ui/testing/input_helper/src/input_device.rs
M tools/cargo-gnaw/src/lib.rs
M tools/cargo-gnaw/tests/golden.rs
M tools/clidoc/src/main.rs
M tools/cmc/src/include.rs
M tools/cmc/src/util.rs
M tools/create/src/main.rs
M tools/fidl/abi-compat/src/convert.rs
M tools/fidl/fidldoc/src/main.rs
M tools/lib/cml/src/validate.rs
M tools/make-fuchsia-vol/src/lib.rs
M tools/pbtool/src/build_archive.rs
M tools/pbtool/src/product_description.rs
M tools/shush/src/issues.rs
M tools/shush/src/lint.rs
M tools/test_list_tool/src/main.rs

Change size: L

Delta: 225 files changed, 492 insertions(+), 492 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dc330eef8209363f3090585883151a4ea27499c4-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,

May 6, 2026, 12:40:55 PM (yesterday) May 6

to Owners Override, SLSA Policy Verification Service, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com

Attention needed from Owners Override

Erick Tryzelaar added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Erick Tryzelaar . resolved

Adding owners-override since this is a trivial change across the codebase.

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dc330eef8209363f3090585883151a4ea27499c4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'SLSA Policy Verification Service (Gerrit)' via owners-override

unread,

May 6, 2026, 12:42:05 PM (yesterday) May 6

to Erick Tryzelaar, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com

Attention needed from Owners Override

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

+1

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/39bae6a9cf0dcad6a72de8368e2eb73c3e5554a8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

May 6, 2026, 12:45:41 PM (yesterday) May 6

to Erick Tryzelaar, SLSA Policy Verification Service, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com

Attention needed from Erick Tryzelaar and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Erick Tryzelaar
Owners Override

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/737019d5f2cdf834a198bc966a042de5717f84fd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override

unread,

May 6, 2026, 2:09:00 PM (23 hours ago) May 6

to Erick Tryzelaar, James Robinson, SLSA Policy Verification Service, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com

fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[rust] Fix upcoming clippy lints

This fixes some lints in an upcoming rust toolchain roll, which now
warns on:

* unnecessary borrows in format strings

* unnecessary `.to_string()` on types that implement display in


  format strings.
* suggests directly using `.values_mut()` over using
  `for (_, value) in ....iter_mut()`.

Change-Id: I74f721be570fe3b701b85032b3b3bdedaa1a24bb

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1601109

Reviewed-by: Marie Janssen <jam...@google.com>

Owners-Override: James Robinson <jam...@google.com>

SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Commit-Queue: Erick Tryzelaar <etryz...@google.com>

Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Marie Janssen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6ccc0678edeae9c8e91e57d975cce01a3ad12207-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override

unread,

May 6, 2026, 2:18:05 PM (23 hours ago) May 6

to Erick Tryzelaar, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, James Robinson, SLSA Policy Verification Service, Owners Override, Marie Janssen, global-integrat...@fuchsia-infra.iam.gserviceaccount.com

Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1257109

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f7557b91eb44d32e95a2174b214b216f04243618-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in fuchsia/fuchsia[main]: [rust] Fix upcoming clippy lints

'Erick Tryzelaar (Gerrit)' via owners-override

Erick Tryzelaar has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Erick Tryzelaar (Gerrit)' via owners-override

Erick Tryzelaar added 1 comment

Related details

'SLSA Policy Verification Service (Gerrit)' via owners-override

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override

fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

Change information

'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override

Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com

Related details