[M] Change in fuchsia/fuchsia[main]: [syslog] Remove legacy namespaces with the next API level

0 views
Skip to first unread message

'Chris Suter (Gerrit)' via owners-override

unread,
Aug 6, 2025, 1:55:49 AMAug 6
to Owners Override
Attention needed from Owners Override

Chris Suter has uploaded the change for review

Chris Suter would like Owners Override to review this change.

Commit message

[syslog] Remove legacy namespaces with the next API level
Bug: 377963307
Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Dependent-on: Icaa28de07749ac716910b60c67e554d06c252ac7
Dependent-on: Ia73d926db6841969c92c4d829ab8a68fe394aaeb

Change diff


Change information

Files:
  • M examples/components/pw_rpc/runner/log_proxy.cc
  • M sdk/lib/driver/logging/cpp/driver_logging_cpp.api
  • M sdk/lib/driver/logging/cpp/logger.cc
  • M sdk/lib/driver/logging/cpp/logger.h
  • M sdk/lib/syslog/cpp/log_message_impl.cc
  • M sdk/lib/syslog/cpp/log_message_impl.h
  • M sdk/lib/syslog/cpp/log_structure_unittest.cc
  • M sdk/lib/syslog/cpp/logging_backend_fuchsia.cc
  • M sdk/lib/syslog/cpp/logging_unittest.cc
  • M sdk/lib/syslog/cpp/syslog_cpp.api
  • M sdk/lib/syslog/duplicate_header_test/duplicate_header_unittest.cc
  • M sdk/lib/syslog/structured_backend/cpp/fuchsia_syslog.h
  • M sdk/lib/syslog/structured_backend/cpp/log_buffer.cc
  • M sdk/lib/syslog/structured_backend/cpp/log_connection.h
  • M sdk/lib/syslog/structured_backend/syslog_structured_backend.api
  • M src/devices/lib/log/log.h
  • M src/devices/testing/syslog/fuzz-sdk.cc
  • M src/devices/testing/syslog/fuzz.cc
  • M src/diagnostics/validator/logs/sink/puppet/cpp/puppet.cc
  • M src/diagnostics/validator/logs/sink/puppet/sdk/puppet.cc
  • M src/graphics/magma/lib/magma/platform/zircon/zircon_platform_logger_syslog.cc
  • M src/lib/diagnostics/log/message/rust/cpp-log-decoder/test.cc
  • M zircon/system/ulib/syslog/fx_logger.cc
Change size: M
Delta: 23 files changed, 53 insertions(+), 49 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Gerrit-Change-Number: 1336265
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b6c22c23ab3f37ae58dce8bcda91c181b6b63b06-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Chris Suter (Gerrit)' via owners-override

unread,
Aug 6, 2025, 1:56:12 AMAug 6
to Owners Override, Christopher Johnson, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override

Chris Suter voted API-Review+1

API-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Gerrit-Change-Number: 1336265
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 06 Aug 2025 05:55:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/146f5b513d9b09dadccc713d7c74defd1f8218fa-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Aug 6, 2025, 2:43:29 AMAug 6
to Chris Suter, Owners Override, Christopher Johnson, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Chris Suter and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Suter
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Gerrit-Change-Number: 1336265
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chris Suter <csu...@google.com>
Gerrit-Comment-Date: Wed, 06 Aug 2025 06:43:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7e69fb3ee807d3615d712d5f6e1a37ad5ca20b80-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Chris Suter (Gerrit)' via owners-override

unread,
Aug 6, 2025, 3:57:05 AMAug 6
to Adam Barth, Owners Override, Christopher Johnson, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Owners Override

Chris Suter voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Gerrit-Change-Number: 1336265
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 06 Aug 2025 07:56:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/68460c9313f26c0a508bd3686f630cf67de0eeae-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Aug 6, 2025, 3:57:14 AMAug 6
to Chris Suter, Adam Barth, Owners Override, Christopher Johnson, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com

CQ Bot submitted the change

Change information

Commit message:
[syslog] Remove legacy namespaces with the next API level
Bug: 377963307
Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Dependent-on: Icaa28de07749ac716910b60c67e554d06c252ac7
Dependent-on: Ia73d926db6841969c92c4d829ab8a68fe394aaeb
API-Review: Chris Suter <csu...@google.com>
Reviewed-by: Christopher Johnson <crj...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Commit-Queue: Chris Suter <csu...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedAPI-Review: +1 by Chris Suter
  • requirement satisfiedCode-Review: +2 by Christopher Johnson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Gerrit-Change-Number: 1336265
Gerrit-PatchSet: 7
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f307455f7b220e84819bab4759a2fe58da404e06-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Aug 6, 2025, 3:59:55 AMAug 6
to Chris Suter, CQ Bot, Adam Barth, Owners Override, Christopher Johnson, GI Try Builder, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I54d9428affe1fc0e8fdcee1a10534ab8fa962705
Gerrit-Change-Number: 1336265
Gerrit-PatchSet: 7
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 06 Aug 2025 07:59:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/de71691159c8d0bc1a269d34cf8a528a1773a79f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages