'Aaron Wood (Gerrit)' via owners-override

unread,

Aug 11, 2025, 3:55:37 PMAug 11

to David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, David Turner, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from David Fang, David Turner, James Robinson, Jay Zhuang and Owners Override

Aaron Wood has uploaded the change for review

Aaron Wood would like David Fang, Owners Override, CL Deps Checker, David Turner, CQ Bot, Jay Zhuang and James Robinson to review this change.

Commit message

Reland "[build] Roll new GN release into the tree."

This is a reland of commit 3793479447263ceeb7cb32e370443278db7b3d39

Original change's description:
> [build] Roll new GN release into the tree.
>
> Manually roll a new GN release which includes a change
> in the `gn format` output, coming from [1].
>
> [1] https://gn-review.googlesource.com/c/gn/+/19322
>
> - build/icu/icu_rust_binary.gni: Minor fix to ensure dependency
>   label is properly formatted before expansion.
>
> Depends-On: turquoise-internal:I130fc9946936ee84acde6d3739f96c2eee39f67c
> Change-Id: If46f27428b8120d255ad9beff11ef62c31c22a49
> Bug: 434660570
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1332564
> Reviewed-by: David Fang <fan...@google.com>
> Commit-Queue: David Turner <di...@google.com>
> Fuchsia-Auto-Submit: David Turner <di...@google.com>
> Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
> Reviewed-by: Jay Zhuang <jayz...@google.com>
> Reviewed-by: Aaron Wood <aaro...@google.com>

Bug: 434660570

Change-Id: I3c777511ba71a32cb6b0e8934cf1266a941a7086

Change diff

Change information

Files:

M build/BUILD.gn
M build/cpp/BUILD.gn
M build/dart/BUILD.gn
M build/icu/config.gni
M build/icu/icu_rustc_binary.gni
M bundles/buildbot/minimal/BUILD.gn
M bundles/drivers/BUILD.gn
M bundles/drivers/pci/BUILD.gn
M examples/diagnostics/inspect/cpp/BUILD.gn
M examples/drivers/transport/banjo/v2/BUILD.gn
M examples/drivers/transport/driver/rust_next/child/BUILD.gn
M examples/drivers/transport/driver/v1/BUILD.gn
M examples/drivers/transport/zircon/rust/child/BUILD.gn
M examples/drivers/transport/zircon/rust/parent/BUILD.gn
M examples/drivers/transport/zircon/rust_next/child/BUILD.gn
M examples/drivers/transport/zircon/rust_next/parent/BUILD.gn
M examples/drivers/transport/zircon/v2/BUILD.gn
M examples/fidl/new/canvas/add_line_metered/cpp_natural/BUILD.gn
M examples/fidl/new/canvas/add_line_metered/cpp_wire/BUILD.gn
M examples/fidl/new/canvas/add_line_metered/rust/BUILD.gn
M examples/fidl/new/canvas/baseline/cpp_natural/BUILD.gn
M examples/fidl/new/canvas/baseline/cpp_wire/BUILD.gn
M examples/fidl/new/canvas/baseline/rust/BUILD.gn
M examples/fidl/new/canvas/client_requested_draw/cpp_natural/BUILD.gn
M examples/fidl/new/canvas/client_requested_draw/cpp_wire/BUILD.gn
M examples/fidl/new/canvas/client_requested_draw/rust/BUILD.gn
M examples/fidl/new/key_value_store/add_iterator/rust/BUILD.gn
M examples/fidl/new/key_value_store/add_read_item/rust/BUILD.gn
M examples/fidl/new/key_value_store/baseline/cpp_natural/BUILD.gn
M examples/fidl/new/key_value_store/baseline/cpp_natural/client/BUILD.gn
M examples/fidl/new/key_value_store/baseline/cpp_wire/BUILD.gn
M examples/fidl/new/key_value_store/baseline/rust/BUILD.gn
M examples/fidl/new/key_value_store/support_exports/cpp_natural/BUILD.gn
M examples/fidl/new/key_value_store/support_exports/cpp_natural/client/BUILD.gn
M examples/fidl/new/key_value_store/support_exports/cpp_wire/BUILD.gn
M examples/fidl/new/key_value_store/support_exports/rust/BUILD.gn
M examples/fidl/new/key_value_store/support_trees/rust/BUILD.gn
M examples/fidl/new/key_value_store/use_generic_values/rust/BUILD.gn
M manifests/jiri.lock
M manifests/toolchain
M sdk/BUILD.gn
M sdk/fidl/fuchsia.hardware.telephony.transport/BUILD.gn
M sdk/fidl/fuchsia.power.broker/BUILD.gn
M sdk/lib/BUILD.gn
M sdk/lib/driver/compat/cpp/BUILD.gn
M sdk/lib/driver/devicetree/manager/BUILD.gn
M sdk/lib/driver/devicetree/visitors/BUILD.gn
M sdk/lib/driver/devicetree/visitors/default/BUILD.gn
M sdk/lib/driver/devicetree/visitors/default/bind-property/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/amlogic-canvas/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/clock-controllers/clockimpl-visitor/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/gpio-controllers/gpioimpl-visitor/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/i2c-controllers/i2c-bus-visitor/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/iio/lib/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/interconnect/interconnect-visitor/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/mailbox-controllers/mailbox/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/mali-gpu/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/mmc/sdmmc/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/pwm-controllers/pwm-init/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/pwm-controllers/pwm/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/registers/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/regulator/regulator/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/serial/serial-port/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/spi-controllers/spi-bus-visitor/BUILD.gn
M sdk/lib/driver/devicetree/visitors/drivers/spmi-controllers/spmi/BUILD.gn
M sdk/lib/fidl_driver/tests/transport/BUILD.gn
M sdk/lib/fuchsia-mem-ext/BUILD.gn
M sdk/lib/scheduler/cpp/BUILD.gn
M sdk/lib/sys/component/cpp/testing/BUILD.gn
M sdk/lib/syslog/cpp/BUILD.gn
M src/camera/bin/camera-gym/BUILD.gn
M src/camera/bin/factory/BUILD.gn
M src/camera/bin/sensor_cli/BUILD.gn
M src/camera/lib/cobalt_logger/BUILD.gn
M src/cobalt/bin/app/BUILD.gn
M src/connectivity/bluetooth/hci/passthrough/BUILD.gn
M src/connectivity/bluetooth/hci/transport/uart/BUILD.gn
M src/connectivity/bluetooth/hci/vendor/broadcom/BUILD.gn
M src/connectivity/bluetooth/hci/vendor/intel/BUILD.gn
M src/connectivity/bluetooth/profiles/bt-hfp-audio-gateway/BUILD.gn
M src/connectivity/bluetooth/profiles/tests/bt-hfp-audio-gateway-integration-tests/BUILD.gn
M src/connectivity/bluetooth/tools/bt-pairing-tool/BUILD.gn
M src/connectivity/ethernet/BUILD.gn
M src/connectivity/ethernet/drivers/aml-ethernet/BUILD.gn
M src/connectivity/ethernet/drivers/third_party/igc/test/BUILD.gn
M src/connectivity/network/drivers/network-device/BUILD.gn
M src/connectivity/network/drivers/network-device/device/BUILD.gn
M src/connectivity/network/drivers/network-device/driver_source_split.gni
M src/connectivity/network/drivers/network-device/mac/BUILD.gn
M src/connectivity/network/testing/netemul/guest/BUILD.gn
M src/connectivity/network/tun/network-tun/BUILD.gn
M src/connectivity/openthread/third_party/openthread/BUILD.gn
M src/connectivity/policy/netcfg/BUILD.gn
M src/connectivity/weave/BUILD.gn
M src/connectivity/weave/adaptation/tests/BUILD.gn
M src/connectivity/weave/lib/core/BUILD.gn
M src/connectivity/weave/lib/core/tests/BUILD.gn
M src/connectivity/wlan/BUILD.gn
M src/connectivity/wlan/drivers/lib/components/BUILD.gn
M src/connectivity/wlan/drivers/lib/components/cpp/test/BUILD.gn
M src/connectivity/wlan/drivers/lib/log/cpp/BUILD.gn
M src/connectivity/wlan/drivers/lib/timer/cpp/test/BUILD.gn
M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/BUILD.gn
M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/recovery/test/BUILD.gn
M src/connectivity/wlan/drivers/third_party/broadcom/brcmfmac/test/BUILD.gn
M src/connectivity/wlan/drivers/wlanif/test/BUILD.gn
M src/connectivity/wlan/drivers/wlanphy/BUILD.gn
M src/connectivity/wlan/drivers/wlansoftmac/BUILD.gn
M src/connectivity/wlan/testing/wlantap-driver/BUILD.gn
M src/connectivity/wlan/tests/helpers/testcontroller-driver/BUILD.gn
M src/developer/debug/e2e_tests/BUILD.gn
M src/developer/ffx/lib/e2e_emu/ffx_e2e_test.gni
M src/developer/ffx/lib/profiler/BUILD.gn
M src/developer/ffx/lib/profiler/tests/BUILD.gn
M src/developer/ffx/plugins/setui/accessibility/BUILD.gn
M src/developer/ffx/plugins/setui/audio/BUILD.gn
M src/developer/ffx/plugins/setui/display/BUILD.gn
M src/developer/ffx/plugins/setui/do_not_disturb/BUILD.gn
M src/developer/ffx/plugins/setui/factory_reset/BUILD.gn
M src/developer/ffx/plugins/setui/input/BUILD.gn
M src/developer/ffx/plugins/setui/intl/BUILD.gn
M src/developer/ffx/plugins/setui/keyboard/BUILD.gn
M src/developer/ffx/plugins/setui/light/BUILD.gn
M src/developer/ffx/plugins/setui/night_mode/BUILD.gn
M src/developer/ffx/plugins/setui/privacy/BUILD.gn
M src/developer/ffx/plugins/setui/setup/BUILD.gn
M src/developer/ffx/tools/profiler/BUILD.gn
M src/developer/forensics/crash_reports/info/BUILD.gn
M src/developer/forensics/crash_reports/tests/BUILD.gn
M src/developer/forensics/exceptions/handler/BUILD.gn
M src/developer/forensics/feedback_data/tests/BUILD.gn
M src/developer/forensics/testing/stubs/BUILD.gn
M src/developer/forensics/utils/BUILD.gn
M src/developer/forensics/utils/cobalt/BUILD.gn
M src/developer/memory/metrics/tests/BUILD.gn
M src/developer/memory/pressure_signaler/BUILD.gn
M src/developer/remote-control/usb/overnet-usb/BUILD.gn
M src/devices/BUILD.gn
M src/devices/bin/driver_manager/BUILD.gn
M src/devices/bin/driver_manager/tests/BUILD.gn
M src/devices/bin/driver_runtime/BUILD.gn
M src/devices/bind/BUILD.gn
M src/devices/block/BUILD.gn
M src/devices/block/drivers/ahci/BUILD.gn
M src/devices/block/drivers/aml-sdmmc/BUILD.gn
M src/devices/block/drivers/core/BUILD.gn
M src/devices/block/drivers/ftl/BUILD.gn
M src/devices/block/drivers/sdmmc/BUILD.gn
M src/devices/block/drivers/ufs/BUILD.gn
M src/devices/board/BUILD.gn
M src/devices/board/drivers/astro/BUILD.gn
M src/devices/board/drivers/astro/post-init/BUILD.gn
M src/devices/board/drivers/crosvm/BUILD.gn
M src/devices/board/drivers/nelson/BUILD.gn
M src/devices/board/drivers/sherlock/BUILD.gn
M src/devices/bus/drivers/platform/test/BUILD.gn
M src/devices/bus/drivers/platform/test/power-integration-test/BUILD.gn
M src/devices/clock/drivers/clock/BUILD.gn
M src/devices/gpio/drivers/ti-tca6408a/BUILD.gn
M src/devices/gpio/testing/fake-gpio/BUILD.gn
M src/devices/hrtimer/drivers/aml-hrtimer/BUILD.gn
M src/devices/i2c/testing/fake-i2c/BUILD.gn
M src/devices/lib/fragment-irq/BUILD.gn
M src/devices/misc/drivers/compat/BUILD.gn
M src/devices/misc/drivers/packaged/BUILD.gn
M src/devices/misc/drivers/virtio-pmem/BUILD.gn
M src/devices/ml/drivers/aml-nna/BUILD.gn
M src/devices/power/BUILD.gn
M src/devices/power/drivers/aml-pwm-regulator/BUILD.gn
M src/devices/power/drivers/fusb302/BUILD.gn
M src/devices/pwm/drivers/aml-pwm-init/BUILD.gn
M src/devices/registers/drivers/registers/BUILD.gn
M src/devices/rtc/drivers/intel-rtc/BUILD.gn
M src/devices/serial/BUILD.gn
M src/devices/tee/drivers/optee/BUILD.gn
M src/devices/temperature/BUILD.gn
M src/devices/temperature/drivers/aml-trip/BUILD.gn
M src/devices/tests/BUILD.gn
M src/devices/tests/driver-runtime/BUILD.gn
M src/devices/tests/driver-transport/BUILD.gn
M src/devices/tests/node-group-test/BUILD.gn
M src/devices/tests/runtime-composite-test/BUILD.gn
M src/devices/tests/runtime-composite-test/drivers/BUILD.gn
M src/devices/tests/v2/compat-node-group/node-group/BUILD.gn
M src/devices/tests/v2/compat-runtime-v1/root/BUILD.gn
M src/devices/tests/v2/compat-runtime/BUILD.gn
M src/devices/tests/v2/devfs-export-service/BUILD.gn
M src/devices/tests/v2/devfs_exporter/BUILD.gn
M src/devices/tests/v2/dynamic_offers/BUILD.gn
M src/devices/tests/v2/interop/BUILD.gn
M src/devices/tests/v2/node_group/BUILD.gn
M src/devices/tests/v2/runtime-dispatcher/BUILD.gn
M src/devices/tests/v2/runtime-protocol/BUILD.gn
M src/devices/tests/v2/services/BUILD.gn
M src/devices/thermal/bin/fan-controller/BUILD.gn
M src/devices/usb/BUILD.gn
M src/devices/usb/drivers/usb-bus/BUILD.gn
M src/devices/usb/drivers/xhci/BUILD.gn
M src/devices/usb/lib/usb-endpoint/BUILD.gn
M src/devices/usb/lib/usb-phy/tests/BUILD.gn
M src/diagnostics/persistence/BUILD.gn
M src/diagnostics/validator/inspect/fidl/BUILD.gn
M src/firmware/BUILD.gn
M src/firmware/gigaboot/cpp/BUILD.gn
M src/graphics/BUILD.gn
M src/graphics/bin/agis/BUILD.gn
M src/graphics/display/BUILD.gn
M src/graphics/drivers/aml-gpu/BUILD.gn
M src/graphics/drivers/msd-arm-mali/tests/conformance/BUILD.gn
M src/graphics/drivers/msd-intel-gen/BUILD.gn
M src/graphics/drivers/msd-intel-gen/tests/conformance/BUILD.gn
M src/graphics/lib/compute/spinel/platforms/vk/BUILD.gn
M src/lib/analytics/rust/BUILD.gn
M src/lib/ddk/BUILD.gn
M src/lib/diagnostics/reader/rust/BUILD.gn
M src/lib/fidl_codec/BUILD.gn
M src/lib/gcs/BUILD.gn
M src/lib/gcs/test/BUILD.gn
M src/lib/icu/BUILD.gn
M src/lib/llvm/BUILD.gn
M src/lib/metrics_buffer/BUILD.gn
M src/lib/ui/flatland-frame-scheduling/BUILD.gn
M src/lib/zxc/BUILD.gn
M src/media/audio/audio_core/mixer/BUILD.gn
M src/media/audio/drivers/BUILD.gn
M src/media/audio/drivers/usb-audio/BUILD.gn
M src/media/codec/codecs/sw/low_layer/codec_android_pal/BUILD.gn
M src/media/codec/examples/use_media_decoder/BUILD.gn
M src/media/drivers/BUILD.gn
M src/media/lib/codec_impl/BUILD.gn
M src/performance/lib/memory/BUILD.gn
M src/performance/trace_bench/BUILD.gn
M src/power/power-manager/testing/fake_driver/BUILD.gn
M src/power/power-manager/testing/fake_root/BUILD.gn
M src/power/testing/fake-trippoint/BUILD.gn
M src/security/bin/kms/BUILD.gn
M src/storage/blobfs/test/BUILD.gn
M src/storage/blobfs/tools/BUILD.gn
M src/storage/f2fs/test/compatibility/BUILD.gn
M src/storage/fxfs/crypto/BUILD.gn
M src/storage/lib/paver/BUILD.gn
M src/storage/lib/watchdog/BUILD.gn
M src/storage/minfs/BUILD.gn
M src/storage/testing/BUILD.gn
M src/storage/tools/blobfs-compression/test/BUILD.gn
M src/storage/volume_image/ftl/BUILD.gn
M src/sys/component_manager/tests/BUILD.gn
M src/sys/component_manager/tests/structured_config/client_integration/cpp_driver/BUILD.gn
M src/sys/lib/runner/BUILD.gn
M src/sys/pkg/bin/omaha-client/BUILD.gn
M src/sys/pkg/bin/pkgctl/BUILD.gn
M src/sys/pkg/lib/far/cpp/BUILD.gn
M src/sys/pkg/lib/fuchsia-repo/BUILD.gn
M src/sys/pkg/lib/omaha-client-fuchsia/BUILD.gn
M src/sys/test_runners/BUILD.gn
M src/sys/test_runners/lib_loader_cache/BUILD.gn
M src/testing/system-validation/ui/BUILD.gn
M src/tests/end_to_end/bundles/BUILD.gn
M src/tests/end_to_end/package_manager/BUILD.gn
M src/tests/end_to_end/package_manager/util/pm/BUILD.gn
M src/tests/fidl/dynsuite/client_suite/harness/BUILD.gn
M src/tests/fidl/dynsuite/client_suite/runners/cpp_async/BUILD.gn
M src/tests/fidl/dynsuite/client_suite/runners/cpp_sync/BUILD.gn
M src/tests/fidl/dynsuite/client_suite/runners/cpp_wire_async/BUILD.gn
M src/tests/fidl/dynsuite/client_suite/runners/cpp_wire_sync/BUILD.gn
M src/tests/fidl/dynsuite/client_suite/runners/hlcpp_async/BUILD.gn
M src/tests/fidl/dynsuite/client_suite/runners/hlcpp_sync/BUILD.gn
M src/tests/memory_budget/BUILD.gn
M src/ui/a11y/bin/a11y_manager/BUILD.gn
M src/ui/a11y/lib/BUILD.gn
M src/ui/a11y/lib/screen_reader/BUILD.gn
M src/ui/a11y/lib/screen_reader/focus/tests/BUILD.gn
M src/ui/a11y/lib/screen_reader/i18n/tests/BUILD.gn
M src/ui/a11y/lib/screen_reader/i18n/tests/mocks/BUILD.gn
M src/ui/backlight/drivers/vim3-pwm-backlight/BUILD.gn
M src/ui/bin/brightness_manager/BUILD.gn
M src/ui/bin/scene_manager/BUILD.gn
M src/ui/bin/system_monitor/BUILD.gn
M src/ui/bin/system_monitor/tests/BUILD.gn
M src/ui/examples/screen_recording/BUILD.gn
M src/ui/input/drivers/buttons/BUILD.gn
M src/ui/input/drivers/goldfish_sensor/BUILD.gn
M src/ui/input/lib/injector/tests/BUILD.gn
M src/ui/input/testing/fake_input_report_device/BUILD.gn
M src/ui/lib/input_pipeline/BUILD.gn
M src/ui/scenic/lib/allocation/tests/BUILD.gn
M src/ui/scenic/lib/display/BUILD.gn
M src/ui/scenic/lib/flatland/BUILD.gn
M src/ui/scenic/lib/flatland/engine/BUILD.gn
M src/ui/scenic/lib/flatland/engine/tests/BUILD.gn
M src/ui/scenic/lib/flatland/engine/tests/pixeltests/BUILD.gn
M src/ui/scenic/lib/flatland/engine/tests/smoketests/BUILD.gn
M src/ui/scenic/lib/flatland/renderer/tests/BUILD.gn
M src/ui/scenic/lib/flatland/tests/BUILD.gn
M src/ui/scenic/lib/image-compression/BUILD.gn
M src/ui/scenic/lib/input/BUILD.gn
M src/ui/scenic/lib/screen_capture/BUILD.gn
M src/ui/scenic/lib/screen_capture2/BUILD.gn
M src/ui/scenic/lib/screen_capture2/tests/BUILD.gn
M src/ui/scenic/lib/screenshot/BUILD.gn
M src/ui/scenic/lib/screenshot/tests/BUILD.gn
M src/ui/scenic/tests/BUILD.gn
M src/ui/tests/integration_input_tests/text-input/BUILD.gn
M src/ui/tests/integration_input_tests/web-test-base/BUILD.gn
M src/virtualization/bin/vmm/device/tests/BUILD.gn
M src/virtualization/bin/vmm/device/virtio_net/BUILD.gn
M src/virtualization/lib/grpc/BUILD.gn
M src/virtualization/lib/guest_interaction/interactive_debian_guest/BUILD.gn
M src/virtualization/lib/vsh/BUILD.gn
M src/virtualization/tests/BUILD.gn
M src/zircon/bin/role_manager/BUILD.gn
M src/zircon/bin/role_manager/testing/fake/BUILD.gn
M third_party/pigweed/backends/pw_async_fuchsia/BUILD.gn
M tools/auto_owners/tests/no_auto_owners/dep/BUILD.gn
M tools/auto_owners/tests/owners/dep/BUILD.gn
M tools/doc_checker/BUILD.gn
M tools/docsgen/BUILD.gn
M tools/fidl/example-tester/example/cpp_wire/BUILD.gn
M tools/fidl/example-tester/example/rust/BUILD.gn
M zircon/system/ulib/concurrent/BUILD.gn
M zircon/system/ulib/hwreg-i2c/BUILD.gn
M zircon/system/ulib/syslog/BUILD.gn
M zircon/third_party/dev/ethernet/e1000/test/BUILD.gn

Change size: L

Delta: 323 files changed, 487 insertions(+), 486 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

David Fang
David Turner
James Robinson
Jay Zhuang
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/379ca6627496c49b89731f9a798def88a615d637-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Clayton McCray (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:02:42 PMAug 11

to David Turner, Aaron Wood, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, James Robinson, Jay Zhuang and Owners Override

Clayton McCray voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood

David Fang
David Turner
James Robinson
Jay Zhuang
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/59d5f9ecdaff8bfedce392953a81dd238e86ceff-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Clayton McCray (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:03:11 PMAug 11

to David Turner, Aaron Wood, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, James Robinson, Jay Zhuang and Owners Override

Clayton McCray voted Commit-Queue+2

Commit-Queue

+2

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/abc13f6759f75df56017b22ea6bfdfe341c70bf6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Clayton McCray (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:04:20 PMAug 11

to David Turner, Aaron Wood, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, James Robinson, Jay Zhuang and Owners Override

Clayton McCray voted Commit-Queue+0

Commit-Queue

+0

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/12eef26752da261b35792e048b8eab43acbbda1b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Aaron Wood (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:06:53 PMAug 11

to David Turner, Clayton McCray, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Aaron Wood abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ac0989806b9fa2d1d7581cf56666bb624d6fc924-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Aaron Wood (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:07:59 PMAug 11

to David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, David Turner, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from David Fang, David Turner, James Robinson, Jay Zhuang and Owners Override

Aaron Wood has uploaded the change for review

Aaron Wood would like David Fang, Owners Override, CL Deps Checker, David Turner, CQ Bot, Jay Zhuang and James Robinson to review this change.

Commit message

Reland "[build] Roll new GN release into the tree."

This is a reland of commit 3793479447263ceeb7cb32e370443278db7b3d39

Original change's description:
> [build] Roll new GN release into the tree.
>
> Manually roll a new GN release which includes a change
> in the `gn format` output, coming from [1].
>
> [1] https://gn-review.googlesource.com/c/gn/+/19322
>
> - build/icu/icu_rust_binary.gni: Minor fix to ensure dependency
>   label is properly formatted before expansion.
>
> Depends-On: turquoise-internal:I130fc9946936ee84acde6d3739f96c2eee39f67c
> Change-Id: If46f27428b8120d255ad9beff11ef62c31c22a49
> Bug: 434660570
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1332564
> Reviewed-by: David Fang <fan...@google.com>
> Commit-Queue: David Turner <di...@google.com>
> Fuchsia-Auto-Submit: David Turner <di...@google.com>
> Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
> Reviewed-by: Jay Zhuang <jayz...@google.com>
> Reviewed-by: Aaron Wood <aaro...@google.com>

Bug: 434660570

Change-Id: I038949302407b4c04255c245786cce7dece85eb5

Open in Gerrit

Related details

Attention is currently required from:

David Fang
David Turner
James Robinson
Jay Zhuang
Owners Override

Submit Requirements:

Code-Owners

Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/afda50b1fe1570d3433386e2c3e4d258b5f4548f-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Clayton McCray (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:09:00 PMAug 11

to David Turner, Aaron Wood, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, James Robinson, Jay Zhuang and Owners Override

Clayton McCray voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood

David Fang
David Turner
James Robinson
Jay Zhuang
Owners Override

Submit Requirements:

Code-Owners

Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0d2952fedfbe9468c51ec93fbd029e81285be9bc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Clayton McCray (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:09:43 PMAug 11

to David Turner, Aaron Wood, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, James Robinson, Jay Zhuang and Owners Override

Clayton McCray voted Commit-Queue+2

Commit-Queue

+2

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fe002efe765817e8008c1d9eefdca8d367b1ab8a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:09:48 PMAug 11

to David Turner, Aaron Wood, Clayton McCray, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, Jay Zhuang and Owners Override

James Robinson added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

James Robinson . resolved

What's different from the first time around?

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood
David Fang
David Turner

Jay Zhuang
Owners Override

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/547d1db1777447a027f2ce5219f163a9317f1888-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Clayton McCray (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:14:55 PMAug 11

to David Turner, Aaron Wood, Erick Tryzelaar, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, James Robinson, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, Erick Tryzelaar, James Robinson, Jay Zhuang and Owners Override

Clayton McCray added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

James Robinson . resolved

What's different from the first time around?

Clayton McCray

https://fuchsia-review.git.corp.google.com/c/fuchsia/+/1342890 landed ahead of this. The addition of the target fixed in that CL seems to have raced with the original version of this one.

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood
David Fang
David Turner

Erick Tryzelaar
James Robinson
Jay Zhuang
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2dd4362b98ec080c83f370cc7298068e6f1fa2ed-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:15:46 PMAug 11

to David Turner, Aaron Wood, Erick Tryzelaar, Clayton McCray, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Attention needed from Aaron Wood, David Fang, David Turner, Erick Tryzelaar, Jay Zhuang and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood
David Fang
David Turner
Erick Tryzelaar

Jay Zhuang
Owners Override

Submit Requirements:

Code-Owners

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6ba2886de9d7758d9df05355f169f44e9f568b93-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Clayton McCray (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:17:04 PMAug 11

to David Turner, Aaron Wood, James Robinson, Erick Tryzelaar, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder, GI Roller

Clayton McCray submitted the change

Change information

Commit message:

Reland "[build] Roll new GN release into the tree."

This is a reland of commit 3793479447263ceeb7cb32e370443278db7b3d39

Original change's description:
> [build] Roll new GN release into the tree.
>
> Manually roll a new GN release which includes a change
> in the `gn format` output, coming from [1].
>
> [1] https://gn-review.googlesource.com/c/gn/+/19322
>
> - build/icu/icu_rust_binary.gni: Minor fix to ensure dependency
>   label is properly formatted before expansion.
>
> Depends-On: turquoise-internal:I130fc9946936ee84acde6d3739f96c2eee39f67c
> Change-Id: If46f27428b8120d255ad9beff11ef62c31c22a49
> Bug: 434660570
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1332564
> Reviewed-by: David Fang <fan...@google.com>
> Commit-Queue: David Turner <di...@google.com>
> Fuchsia-Auto-Submit: David Turner <di...@google.com>
> Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
> Reviewed-by: Jay Zhuang <jayz...@google.com>
> Reviewed-by: Aaron Wood <aaro...@google.com>

Bug: 434660570

Change-Id: I038949302407b4c04255c245786cce7dece85eb5

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1342893

Reviewed-by: Clayton McCray <clayto...@google.com>

Owners-Override: James Robinson <jam...@google.com>

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Clayton McCray

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c5c8236177e775ff9e7847d0bbf618544f6f69e3-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Aug 11, 2025, 4:29:20 PMAug 11

to Aaron Wood, Clayton McCray, James Robinson, Erick Tryzelaar, David Turner, David Fang, Owners Override, CL Deps Checker, CQ Bot, Jay Zhuang, David Dorwin, Brian Bosak, Android Build Huckle Nudge, GI Try Builder

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1028740

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2f10830331ffbb1f4e5f1bbee0376a4288fcb43c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in fuchsia/fuchsia[main]: Reland "[build] Roll new GN release into the tree."

'Aaron Wood (Gerrit)' via owners-override

Aaron Wood has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Clayton McCray (Gerrit)' via owners-override

Clayton McCray voted Code-Review+2

Related details

'Clayton McCray (Gerrit)' via owners-override

Clayton McCray voted Commit-Queue+2

'Clayton McCray (Gerrit)' via owners-override

Clayton McCray voted Commit-Queue+0

'Aaron Wood (Gerrit)' via owners-override

Aaron Wood abandoned this change

Related details

'Aaron Wood (Gerrit)' via owners-override

Aaron Wood has uploaded the change for review

Commit message

Related details

'Clayton McCray (Gerrit)' via owners-override

Clayton McCray voted Code-Review+2

Related details

'Clayton McCray (Gerrit)' via owners-override

Clayton McCray voted Commit-Queue+2

'James Robinson (Gerrit)' via owners-override

James Robinson added 1 comment

Related details

'Clayton McCray (Gerrit)' via owners-override

Clayton McCray added 1 comment

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'Clayton McCray (Gerrit)' via owners-override

Clayton McCray submitted the change

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details