[L] Change in fuchsia/fuchsia[main]: Reland "[lacewing] Run async on the same event loop everywhere"

0 views

Skip to first unread message

'Charles Celerier (Gerrit)' via owners-override

unread,

Feb 27, 2026, 2:03:11 PM (2 days ago) Feb 27

to Andrew Davies, Hunter Freyer, RubberStamper 🤖?, CQ Bot, Rubber Stamper (Chrome), Owners Override, CL Deps Checker, Yilong Li, GI Roller, GI Try Builder

Attention needed from Andrew Davies, Hunter Freyer, Owners Override and Yilong Li

Charles Celerier has uploaded the change for review

Charles Celerier would like Andrew Davies, Hunter Freyer, RubberStamper 🤖, CQ Bot, Rubber Stamper (Chrome), Owners Override, CL Deps Checker and Yilong Li to review this change.

Commit message

Reland "[lacewing] Run async on the same event loop everywhere"

This reverts commit 652b9e17a0fb920c0818082e7fa97509f4490f01.

Reason for revert: Patched to pass the failing builder.

Original change's description:
> Revert "[lacewing] Run async on the same event loop everywhere"
>
> This reverts commit 3d11c5210b1601f7f82a0a1903cecdfb62eb4a74.
>
> Reason for revert: Broke CI
> First known failure: go/bbid/8688701886522434225
>
> Original change's description:
> > [lacewing] Run async on the same event loop everywhere
> >
> > Instead of creating a new loop every time a test needs to run a
> > coroutine, this change runs all the coroutines on the same global event
> > loop. This is a preparatory change for spreading the use of async to all
> > the tests.
> >
> > Depends-on: turquoise-internal:I526098579b1e6444874fb880e0c098efa6ba2288
> > Change-Id: If23a4f15ce3c2931ce226f4a25ea9a152cc9c5f9
> > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1514764
> > Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
> > Commit-Queue: Charles Celerier <ch...@google.com>
> > Owners-Override: Hunter Freyer <hjfr...@google.com>
> > Reviewed-by: Andrew Davies <awda...@google.com>
> > Fuchsia-Auto-Submit: Charles Celerier <ch...@google.com>
>
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1521140
> Exempt: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
> Reviewed-by: Hunter Freyer <hjfr...@google.com>
> Commit-Queue: Yilong Li <li...@google.com>

Change-Id: I88f0a3fa835765eefa9a6c766a56033c584095ff

Change diff

Change information

Files:

M docs/development/tools/fuchsia-controller/async-python.md
M scripts/lib/async_utils/__init__.py
M scripts/lib/async_utils/tests/async_utils_test.py
M scripts/lib/ffx_cmd/BUILD.gn
M scripts/lib/ffx_cmd/e2e_tests/test_ffx_inspect.py
M scripts/lib/ffx_cmd/lib.py
M scripts/lib/ffx_cmd/tests/__init__.py
M scripts/lib/ffx_cmd/tests/test_ffx_cmd.py
M scripts/lib/fx_cmd/lib.py
M scripts/lib/fx_cmd/tests/test_fx_cmd.py
M src/connectivity/network/tests/benchmarks/iperf/BUILD.gn
M src/connectivity/network/tests/benchmarks/iperf/netstack_iperf_test.py
M src/connectivity/wlan/tests/wlancfg/BUILD.gn
M src/connectivity/wlan/tests/wlancfg/RegulatoryRecoveryTest.py
M src/connectivity/wlan/tests/wlanix/ApfTest.py
M src/connectivity/wlan/tests/wlanix/BUILD.gn
M src/connectivity/wlan/tests/wlanix/IfaceCorrectnessAndConsistencyTest.py
M src/connectivity/wlan/tests/wlanix/IfaceLifecycleTest.py
M src/connectivity/wlan/tests/wlanix/WifiChipCorrectnessAndConsistencyTest.py
M src/connectivity/wlan/tests/wlanix/WifiChipExistenceTest.py
M src/connectivity/wlan/tests/wlanix/wlanix_testing/BUILD.gn
M src/connectivity/wlan/tests/wlanix/wlanix_testing/base_test.py
M src/developer/ffx/lib/fuchsia-controller/BUILD.gn
M src/developer/ffx/lib/fuchsia-controller/python/fidl/_client.py
M src/developer/ffx/lib/fuchsia-controller/python/fidl/_ipc.py
D src/developer/ffx/lib/fuchsia-controller/python/fidl/tests/BUILD.gn
D src/developer/ffx/lib/fuchsia-controller/python/fidl/tests/queue_wrapper_test.py
M src/developer/ffx/lib/fuchsia-controller/python/fuchsia_controller_py/wrappers.py
M src/storage/blackout/host/tests/BUILD.gn
M src/storage/blackout/host/tests/blackout.py
M src/testing/end_to_end/honeydew/honeydew/affordances/connectivity/bluetooth/bluetooth_common/bluetooth_common_using_fc.py
M src/testing/end_to_end/honeydew/honeydew/affordances/connectivity/bluetooth/bluetooth_common/tests/unit_tests/bluetooth_common_using_fc_test.py
M src/testing/end_to_end/honeydew/honeydew/affordances/rtc/rtc_using_fc.py
M src/testing/end_to_end/honeydew/honeydew/affordances/rtc/tests/unit_tests/rtc_using_fc_test.py
M src/testing/end_to_end/honeydew/honeydew/affordances/ui/user_input/user_input_using_fc.py
M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/audio_using_fuchsia_controller.py
M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/tests/functional_tests/BUILD.gn
M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/tests/functional_tests/test_audio_inject_record.py
M src/testing/end_to_end/honeydew/honeydew/fuchsia_device/fuchsia_device_impl.py
M src/testing/end_to_end/mobly_base_tests/fuchsia_async_extension/BUILD.gn
M tools/devshell/python/system-status/main.py
M tools/devshell/python/system-status/tests/test_system_status.py
M tools/fidl/fidlgen_python/tests/test_client.py

Change size: L

Delta: 43 files changed, 356 insertions(+), 544 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Andrew Davies
Hunter Freyer
Owners Override
Yilong Li

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-Tags
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0bdfd3998de33802a973c8a76ab68a4b5c8490e4-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Charles Celerier (Gerrit)' via owners-override

unread,

Feb 28, 2026, 7:50:42 AM (17 hours ago) Feb 28

to RubberStamper 🤖?, Andrew Davies, Hunter Freyer, CQ Bot, Rubber Stamper (Chrome), Owners Override, CL Deps Checker, Yilong Li, GI Roller, GI Try Builder

Attention needed from Andrew Davies, Hunter Freyer, Owners Override and Yilong Li

Charles Celerier added 1 comment

Commit Message

Line 11, Patchset 2 (Latest):Reason for reland: Patched to pass the failing builder.

Charles Celerier . unresolved

This is a lie for the moment. as the patch is currently in progress.

Open in Gerrit

Related details

Attention is currently required from:

Andrew Davies
Hunter Freyer
Owners Override
Yilong Li

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-Tags
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fce9483182cbedb44c14ee4dedbc51916302a3dc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Charles Celerier (Gerrit)' via owners-override

unread,

Feb 28, 2026, 7:55:43 AM (17 hours ago) Feb 28

to RubberStamper 🤖?, Andrew Davies, Hunter Freyer, CQ Bot, Rubber Stamper (Chrome), Owners Override, CL Deps Checker, Yilong Li, GI Roller, GI Try Builder

Attention needed from Andrew Davies, Hunter Freyer, Owners Override and Yilong Li

Charles Celerier voted and added 1 comment

Votes added by Charles Celerier

Fuchsia-Auto-Submit

1 comment

Commit Message

Line 11, Patchset 2:Reason for reland: Patched to pass the failing builder.

Charles Celerier . resolved

This is a lie for the moment. as the patch is currently in progress.

Charles Celerier

Done

Open in Gerrit

Related details

Attention is currently required from:

Andrew Davies
Hunter Freyer
Owners Override
Yilong Li

Submit Requirements:

Code-Owners
Code-Review
Commit-Message-Has-Tags
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/383bd8729f02fbf6cafaedba2c30734b13e34928-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages