[M] Change in fuchsia/fuchsia[main]: [versioning] APILevel wraps u32.

0 views
Skip to first unread message

'Hunter Freyer (Gerrit)' via owners-override

unread,
May 9, 2024, 11:41:02 AMMay 9
to Owners Override
Attention needed from Owners Override

Hunter Freyer has uploaded the change for review

Hunter Freyer would like Owners Override to review this change.

Commit message

[versioning] APILevel wraps u32.

RFC-0246 made API levels 32 bits, so let's update the rust code to avoid
confusion.

This CL leaves behind some unfortunate `api_level.as_u64()` statements,
but that's because some stable FIDL APIs still use u64s to represent API
levels. Changing that is a bigger thing than I want to deal with right
now, but I think making the conversions explicit is better than trying
to cover them up. So I've left `as_u64()` in place as deprecated and
suppressed the warnings as necessary.

Bug: 335473877
Change-Id: Id7085cd87965b5438aea2a9d4763ae9e338176de

Change diff


Change information

Files:
  • M src/developer/ffx/daemon/proxy/src/lib.rs
  • M src/developer/ffx/lib/version/src/lib.rs
  • M src/lib/versioning/version-history/rust/proc-macro/src/lib.rs
  • M src/lib/versioning/version-history/rust/shared/src/lib.rs
  • M src/sys/lib/cm_config/src/lib.rs
  • M src/sys/pkg/lib/package-tool/src/package_build.rs
Change size: M
Delta: 6 files changed, 48 insertions(+), 27 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id7085cd87965b5438aea2a9d4763ae9e338176de
Gerrit-Change-Number: 1042232
Gerrit-PatchSet: 5
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: David Dorwin <ddo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/08b97d3223453efcdf88fa5aff8b3b1afc07acf3-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,
May 9, 2024, 11:41:05 AMMay 9
to Owners Override, David Dorwin, CQ Bot
Attention needed from Owners Override

Hunter Freyer voted and added 1 comment

Votes added by Hunter Freyer

Commit-Queue+1
Fuchsia-Auto-Submit+1

1 comment

Commit Message
Line 13, Patchset 4:statements, but that's because some stable FIDL APIs still use u64s to
David Dorwin . resolved

Do we need to do a `replaced` on https://fuchsia.dev/reference/fidl/fuchsia.version/#ApiLevel to change the type? Is that straightforward and something we can do quickly?

Especially if we don't intend to do so soon, perhaps we should add something like `legacy_as_u64` to `ApiLevel` (with a TODO) so we can easily identify code that needs to be changed and documentthe reason for the conversion in one place.

Hunter Freyer

Fair point. I kept around `as_u64()` but marked it as deprecated.

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id7085cd87965b5438aea2a9d4763ae9e338176de
Gerrit-Change-Number: 1042232
Gerrit-PatchSet: 5
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: David Dorwin <ddo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 09 May 2024 15:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: David Dorwin <ddo...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/08b97d3223453efcdf88fa5aff8b3b1afc07acf3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
May 9, 2024, 11:47:31 AMMay 9
to Hunter Freyer, Owners Override, David Dorwin, CQ Bot
Attention needed from Hunter Freyer and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hunter Freyer
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id7085cd87965b5438aea2a9d4763ae9e338176de
Gerrit-Change-Number: 1042232
Gerrit-PatchSet: 5
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Dorwin <ddo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Hunter Freyer <hjfr...@google.com>
Gerrit-Comment-Date: Thu, 09 May 2024 15:47:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7262b965bacb9eccda28b110735b97d0b2d390be-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
May 9, 2024, 1:14:18 PMMay 9
to Hunter Freyer, Auto-Submit, Adam Barth, Owners Override, David Dorwin

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/lib/versioning/version-history/rust/shared/src/lib.rs
Insertions: 5, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/developer/ffx/lib/version/src/lib.rs
Insertions: 14, Deletions: 4.

The diff is too large to show. Please review the diff.
```
```
The name of the file: src/developer/ffx/daemon/proxy/src/lib.rs
Insertions: 7, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
[versioning] APILevel wraps u32.

RFC-0246 made API levels 32 bits, so let's update the rust code to avoid
confusion.

This CL leaves behind some unfortunate `api_level.as_u64()` statements,
but that's because some stable FIDL APIs still use u64s to represent API
levels. Changing that is a bigger thing than I want to deal with right
now, but I think making the conversions explicit is better than trying
to cover them up. So I've left `as_u64()` in place as deprecated and
suppressed the warnings as necessary.

Bug: 335473877
Change-Id: Id7085cd87965b5438aea2a9d4763ae9e338176de
Reviewed-by: David Dorwin <ddo...@google.com>
Fuchsia-Auto-Submit: Hunter Freyer <hjfr...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Files:
  • M src/developer/ffx/daemon/proxy/src/lib.rs
  • M src/developer/ffx/lib/version/src/lib.rs
  • M src/lib/versioning/version-history/rust/proc-macro/src/lib.rs
  • M src/lib/versioning/version-history/rust/shared/src/lib.rs
  • M src/sys/lib/cm_config/src/lib.rs
  • M src/sys/pkg/lib/package-tool/src/package_build.rs
Change size: M
Delta: 6 files changed, 48 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Dorwin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id7085cd87965b5438aea2a9d4763ae9e338176de
Gerrit-Change-Number: 1042232
Gerrit-PatchSet: 6
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Dorwin <ddo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bf693c14080f2bc4898c9e38aeaf2d17d5b2be21-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
May 9, 2024, 1:17:13 PMMay 9
to CQ Bot, Hunter Freyer, Auto-Submit, Adam Barth, Owners Override, David Dorwin

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id7085cd87965b5438aea2a9d4763ae9e338176de
Gerrit-Change-Number: 1042232
Gerrit-PatchSet: 6
Gerrit-Owner: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: David Dorwin <ddo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 09 May 2024 17:16:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2a6d3b2d11490afdc9f063e2dd05988e3101f9ea-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages