'Rui Qi Sim (Gerrit)' via owners-override

unread,

Jul 11, 2024, 6:26:40 PMJul 11

to Owners Override, James Sullivan

Attention needed from Chris Suter, James Sullivan and Owners Override

Rui Qi Sim has uploaded the change for review

Rui Qi Sim would like Owners Override and James Sullivan to review this change.

Commit message

[vfs][rust] Return EntryInfo for Node and DirectoryEntry

Introduce a new trait `GetEntryInfo` that all implementations of
`DirectoryEntry` (used in pseudo filesystems) and `Node` must
implement. This trait only has one method that returns `EntryInfo`.

Prior to this change, there is a method to get `EntryInfo` but it was
a part of only `DirectoryEntry`. Being able to get the entry's
information, regardless of if it is used in a pseudo filesystem, is
still useful. For example, in Open3, we want to identify the directory
entry type to validate protocols when there are more than one specified.

Bug: 348698584

Test: fx test //src/storage/conformance

Change-Id: Idefee013e4e96e8803c92d2166a15f27fe2d23b9

Change diff

Change information

Files:

M sdk/lib/zxio/tests/zxio-test.rs
M src/connectivity/network/testing/netemul/service/src/main.rs
M src/developer/ffx/playground/src/test.rs
M src/developer/ffx/tools/playground/src/cf_fs.rs
M src/developer/ffx/tools/playground/src/host_fs.rs
M src/lib/fuchsia-fs/src/directory/watcher.rs
M src/starnix/kernel/vfs/file_server.rs
M src/storage/block_adapter/src/lib.rs
M src/storage/fuchsia-fatfs/src/directory.rs
M src/storage/fuchsia-fatfs/src/file.rs
M src/storage/fxfs/platform/src/fuchsia/debug.rs
M src/storage/fxfs/platform/src/fuchsia/directory.rs
M src/storage/fxfs/platform/src/fuchsia/file.rs
M src/storage/fxfs/platform/src/fuchsia/fxblob/directory.rs
M src/storage/fxfs/platform/src/fuchsia/symlink.rs
M src/storage/lib/vfs/rust/src/directory/entry.rs
M src/storage/lib/vfs/rust/src/directory/mutable/connection.rs
M src/storage/lib/vfs/rust/src/directory/simple.rs
M src/storage/lib/vfs/rust/src/file.rs
M src/storage/lib/vfs/rust/src/file/connection.rs
M src/storage/lib/vfs/rust/src/file/simple.rs
M src/storage/lib/vfs/rust/src/file/vmo.rs
M src/storage/lib/vfs/rust/src/node.rs
M src/storage/lib/vfs/rust/src/protocols.rs
M src/storage/lib/vfs/rust/src/remote.rs
M src/storage/lib/vfs/rust/src/remote/tests.rs
M src/storage/lib/vfs/rust/src/service.rs
M src/storage/lib/vfs/rust/src/symlink.rs
M src/storage/lib/vfs/rust/src/token_registry.rs
M src/storage/lib/vmo-blob/src/lib.rs
M src/sys/component_manager/lib/sandbox/src/fidl/dict.rs
M src/sys/component_manager/lib/sandbox/src/fidl/dir_entry.rs
M src/sys/component_manager/lib/sandbox/src/fidl/directory.rs
M src/sys/component_manager/lib/serve_processargs/src/lib.rs
M src/sys/component_manager/lib/serve_processargs/src/namespace.rs
M src/sys/component_manager/src/model/component/mod.rs
M src/sys/component_manager/src/model/routing/legacy.rs
M src/sys/component_manager/src/model/routing/router_ext.rs
M src/sys/component_manager/src/model/routing/service.rs
M src/sys/component_manager/src/model/routing_fns.rs
M src/sys/component_manager/src/model/storage/admin_protocol.rs
M src/sys/component_manager/src/model/tests/directory.rs
M src/sys/component_manager/src/sandbox_util.rs
M src/sys/lib/mem_util/src/lib.rs
M src/sys/pkg/bin/pkg-cache/src/compat/pkgfs/validation.rs
M src/sys/pkg/lib/package-directory/src/meta_as_dir.rs
M src/sys/pkg/lib/package-directory/src/meta_subdir.rs
M src/sys/pkg/lib/package-directory/src/non_meta_subdir.rs
M src/sys/pkg/lib/package-directory/src/root_dir.rs

Change size: L

Delta: 49 files changed, 360 insertions(+), 236 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Chris Suter
James Sullivan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/43c497071a8912cd40387ecced3022533cd00ad4-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Rui Qi Sim (Gerrit)' via owners-override

unread,

Jul 11, 2024, 6:26:43 PMJul 11

to Owners Override, James Sullivan, Chris Suter, CQ Bot, Tricium

Attention needed from Chris Suter, James Sullivan and Owners Override

Rui Qi Sim added 1 comment

File src/storage/lib/vfs/rust/src/protocols.rs

Line 502, Patchset 6: if must_be_directory && !(dirent_type == fio::DirentType::Directory) {

Chris Suter . resolved

Same elsewhere.

```suggestion
        if must_be_directory && dirent_type != fio::DirentType::Directory {
```

Rui Qi Sim

Done

Open in Gerrit

Related details

Attention is currently required from:

Chris Suter
James Sullivan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/43c497071a8912cd40387ecced3022533cd00ad4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

Jul 11, 2024, 6:34:37 PMJul 11

to Rui Qi Sim, Owners Override, James Sullivan, Chris Suter, CQ Bot, Tricium

Attention needed from Chris Suter, James Sullivan, Owners Override and Rui Qi Sim

Adam Barth voted and added 1 comment

Votes added by Adam Barth

Owners-Override

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Adam Barth . resolved

Please get a +2 from someone on the local storage team before landing.

Open in Gerrit

Related details

Attention is currently required from:

Chris Suter
James Sullivan
Owners Override

Rui Qi Sim

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ae6b974a140bc03b007024b638e0936f6d1d7e17-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

open

diffy

'Chris Suter (Gerrit)' via owners-override

unread,

Jul 11, 2024, 8:45:08 PMJul 11

to Rui Qi Sim, Adam Barth, Owners Override, James Sullivan, CQ Bot, Tricium

Attention needed from James Sullivan, Owners Override and Rui Qi Sim

Chris Suter voted and added 2 comments

Votes added by Chris Suter

Code-Review

+2

2 comments

File src/storage/lib/vfs/rust/src/directory/entry.rs

Line 62, Patchset 7 (Latest):/// Node and DirectoryEntry implement this trait to give useful information about the entry, for

Chris Suter . unresolved

This doesn't seem accurate. They don't implement it. They include it as a supertrait. I don't think you need to mention this though.

Line 73, Patchset 7 (Latest):

/// directory.  If you don't need to add your nodes to a pseudo directory, consider implementing
/// node::IsDirectory instead.

Chris Suter . unresolved

Needs updating (probably just remove the sentence). Please can you do a quick grep for IsDirectory and make sure there aren't any more stray comments like this.

Open in Gerrit

Related details

Attention is currently required from:

James Sullivan
Owners Override
Rui Qi Sim

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9d82878fb3635f17dbb46cb4f3e9a9c2094405a8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Rui Qi Sim (Gerrit)' via owners-override

unread,

Jul 11, 2024, 9:14:21 PMJul 11

to Chris Suter, Adam Barth, Owners Override, James Sullivan, CQ Bot, Tricium

Attention needed from Adam Barth, James Sullivan and Owners Override

Rui Qi Sim added 2 comments

File src/storage/lib/vfs/rust/src/directory/entry.rs

Line 62, Patchset 7:/// Node and DirectoryEntry implement this trait to give useful information about the entry, for

Chris Suter . resolved

This doesn't seem accurate. They don't implement it. They include it as a supertrait. I don't think you need to mention this though.

Rui Qi Sim

Thanks for pointing that out! I've updated it now.

Line 73, Patchset 7:

/// directory.  If you don't need to add your nodes to a pseudo directory, consider implementing
/// node::IsDirectory instead.

Chris Suter . resolved

Needs updating (probably just remove the sentence). Please can you do a quick grep for IsDirectory and make sure there aren't any more stray comments like this.

Rui Qi Sim

Done. Also did a quick grep of IsDirectory like you suggested and didn't pick up anything else.

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
James Sullivan
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/636d4002d29d1a3ef60e451434e7290e65aa92b2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Rui Qi Sim (Gerrit)' via owners-override

unread,

Jul 11, 2024, 9:23:08 PMJul 11

to Chris Suter, Adam Barth, Owners Override, James Sullivan, CQ Bot, Tricium

Attention needed from Adam Barth, James Sullivan and Owners Override

Rui Qi Sim added 1 comment

Patchset-level comments

File-level comment, Patchset 7:

Adam Barth . resolved

Please get a +2 from someone on the local storage team before landing.

Rui Qi Sim

Sorry, I didn't realise the "owners-override" will be reset with a new patchset. Since this is such a large CL, I'd like to get two people on the storage team to look at it. Could the override be held off until I get another +2 from someone else on the team?

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/17f41e4f74da06c5dc4c9c98939a27f33522f0fa-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

Jul 12, 2024, 12:05:28 AMJul 12

to Rui Qi Sim, Chris Suter, Owners Override, James Sullivan, CQ Bot, Tricium

Attention needed from James Sullivan, Owners Override and Rui Qi Sim

Adam Barth added 1 comment

Patchset-level comments

File-level comment, Patchset 7:

Adam Barth . resolved

Please get a +2 from someone on the local storage team before landing.

Rui Qi Sim

Sorry, I didn't realise the "owners-override" will be reset with a new patchset. Since this is such a large CL, I'd like to get two people on the storage team to look at it. Could the override be held off until I get another +2 from someone else on the team?

Adam Barth

Sure, just ping me when you're ready.

Open in Gerrit

Related details

Attention is currently required from:

James Sullivan

Owners Override
Rui Qi Sim

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c53e68a768805eb3219c2bdbe9d2b12dbd1b6536-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'James Sullivan (Gerrit)' via owners-override

unread,

Jul 12, 2024, 11:53:13 AMJul 12

to Rui Qi Sim, Chris Suter, Adam Barth, Owners Override, CQ Bot, Tricium

Attention needed from Owners Override and Rui Qi Sim

James Sullivan voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

Owners Override
Rui Qi Sim

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/961c2c6b286f89208e7a1deea28f821ba19cf07c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Brandon Castellano (Gerrit)' via owners-override

unread,

Jul 12, 2024, 11:56:04 AMJul 12

to Rui Qi Sim, James Sullivan, Chris Suter, Adam Barth, Owners Override, CQ Bot, Tricium

Attention needed from Adam Barth, Owners Override and Rui Qi Sim

Brandon Castellano voted and added 1 comment

Votes added by Brandon Castellano

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7:

Adam Barth . unresolved

Please get a +2 from someone on the local storage team before landing.

Rui Qi Sim

Sorry, I didn't realise the "owners-override" will be reset with a new patchset. Since this is such a large CL, I'd like to get two people on the storage team to look at it. Could the override be held off until I get another +2 from someone else on the team?

Adam Barth

Sure, just ping me when you're ready.

Brandon Castellano

Should be ready now, thanks Adam!

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth

Owners Override
Rui Qi Sim

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a0e3e01d7c01ce92394824064519678f4c0592ff-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

Jul 12, 2024, 12:37:28 PMJul 12

to Rui Qi Sim, Brandon Castellano, James Sullivan, Chris Suter, Owners Override, CQ Bot, Tricium

Attention needed from Owners Override and Rui Qi Sim

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Owners Override
Rui Qi Sim

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/33a09cde007254583bb4951b8f0067f681ab454c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Brandon Castellano (Gerrit)' via owners-override

unread,

Jul 12, 2024, 5:19:55 PMJul 12

to Rui Qi Sim, Adam Barth, James Sullivan, Chris Suter, Owners Override, CQ Bot, Tricium

Attention needed from Owners Override and Rui Qi Sim

Brandon Castellano voted Commit-Queue+2

Commit-Queue

+2

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7bf97a9600d324cdb78f6a5ee91682214a28aae7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Brandon Castellano (Gerrit)' via owners-override

unread,

Jul 12, 2024, 5:20:03 PMJul 12

to Rui Qi Sim, CQ Bot, Adam Barth, James Sullivan, Chris Suter, Owners Override, Tricium

Brandon Castellano voted and added 1 comment

Votes added by Brandon Castellano

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 7:

Adam Barth . resolved

Please get a +2 from someone on the local storage team before landing.

Rui Qi Sim

Sorry, I didn't realise the "owners-override" will be reset with a new patchset. Since this is such a large CL, I'd like to get two people on the storage team to look at it. Could the override be held off until I get another +2 from someone else on the team?

Adam Barth

Sure, just ping me when you're ready.

Brandon Castellano

Should be ready now, thanks Adam!

Brandon Castellano

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/354c7f59ad3ad93f59150365696432fb9b49ee84-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Jul 12, 2024, 5:20:08 PMJul 12

to Rui Qi Sim, Adam Barth, Brandon Castellano, James Sullivan, Chris Suter, Owners Override, Tricium

CQ Bot submitted the change

Change information

Commit message:

[vfs][rust] Return EntryInfo for Node and DirectoryEntry

Introduce a new trait `GetEntryInfo` that all implementations of
`DirectoryEntry` (used in pseudo filesystems) and `Node` must
implement. This trait only has one method that returns `EntryInfo`.

Prior to this change, there is a method to get `EntryInfo` but it was
a part of only `DirectoryEntry`. Being able to get the entry's
information, regardless of if it is used in a pseudo filesystem, is
still useful. For example, in Open3, we want to identify the directory
entry type to validate protocols when there are more than one specified.

Bug: 348698584

Test: fx test //src/storage/conformance

Change-Id: Idefee013e4e96e8803c92d2166a15f27fe2d23b9

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1079792

Reviewed-by: James Sullivan <jfsu...@google.com>

Reviewed-by: Brandon Castellano <bcas...@google.com>

Commit-Queue: Brandon Castellano <bcas...@google.com>

Reviewed-by: Chris Suter <csu...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Delta: 49 files changed, 360 insertions(+), 238 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Brandon Castellano, +2 by James Sullivan, +2 by Chris Suter

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a39afa8b5e1c3aaea8e830619a9be61265e7a20e-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Jul 12, 2024, 5:22:47 PMJul 12

to Rui Qi Sim, CQ Bot, Adam Barth, Brandon Castellano, James Sullivan, Chris Suter, Owners Override, Tricium

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/4edaf8bf2c7972b78a471f47af2e4b5b89cfc22c

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e03133201539b6b275662b8293a26307f4b320db-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in fuchsia/fuchsia[main]: [vfs][rust] Return EntryInfo for Node and DirectoryEntry

'Rui Qi Sim (Gerrit)' via owners-override

Rui Qi Sim has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Rui Qi Sim (Gerrit)' via owners-override

Rui Qi Sim added 1 comment

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth voted and added 1 comment

Votes added by Adam Barth

1 comment

Related details

'Chris Suter (Gerrit)' via owners-override

Chris Suter voted and added 2 comments

Votes added by Chris Suter

2 comments

Related details

'Rui Qi Sim (Gerrit)' via owners-override

Rui Qi Sim added 2 comments

Related details

'Rui Qi Sim (Gerrit)' via owners-override

Rui Qi Sim added 1 comment

'Adam Barth (Gerrit)' via owners-override

Adam Barth added 1 comment

Related details

'James Sullivan (Gerrit)' via owners-override

James Sullivan voted Code-Review+2

Related details

'Brandon Castellano (Gerrit)' via owners-override

Brandon Castellano voted and added 1 comment

Votes added by Brandon Castellano

1 comment

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth voted Owners-Override+1

Related details

'Brandon Castellano (Gerrit)' via owners-override

Brandon Castellano voted Commit-Queue+2

'Brandon Castellano (Gerrit)' via owners-override

Brandon Castellano voted and added 1 comment

Votes added by Brandon Castellano

1 comment

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details