Dynamic offers: hopefully functional!

3 views
Skip to first unread message

Hunter Freyer

unread,
Oct 11, 2021, 4:00:44 PM10/11/21
to Abdulla Kamar, Suraj Malhotra, drive...@fuchsia.dev, component-framework-dev
Hey Drivers folks!

fxrev.dev/547027 has just landed, meaning dynamic offers should be usable! 

Steps to use:
  1. In the `fuchsia_component` BUILD rule for the component containing the collection that uses dynamic offers, add `restricted_features = [ "dynamic_offers" ]`. This will require updating this allowlist
  2. In CML, set `allowed_offers: "static_and_dynamic"` on the collection in which the dynamic components will be created.
  3. When creating the dynamic child, set CreateChildArgs.dynamic_offers.
Caveats/TODOs:
  1. Currently, you can create a dynamic offer whose source doesn't exist. This will become an error in a subsequent CL, so don't do that!
  2. Dynamic offers are not yet taken into account for component shutdown order. This could theoretically cause flakiness while the system shuts down, but in the drivers case I doubt it will.
Please assign me any bugs you discover! 

Thanks,
Hunter

Abdulla Kamar

unread,
Oct 12, 2021, 5:31:30 AM10/12/21
to Hunter Freyer, Suraj Malhotra, drive...@fuchsia.dev, component-framework-dev
Yay, thank you! \o/

I'll start plumbing this through the driver framework late this week, or early next week.
Reply all
Reply to author
Forward
0 new messages