sync-cpp library to partner?

[Novin Changizi]

Hi api folks,

I'm wondering if the sync-cpp library (https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/system/ulib/sync/BUILD.gn;l=29) has gone through review? I see it's marked as internal category while the corresponding async libraries are partner category.

It is one of the dependencies I have for the driver stuff, and it seems like a pretty straightforward library.

Let me know what the next steps for this should be. I've created a cl to mark it partner (https://fuchsia-review.git.corp.google.com/c/fuchsia/+/878082) but not sure if we want to do an official review for it?

-novin

[Novin Changizi]

Hi, hope you all had a great weekend! Popping this back to the top since it might have got lost. Lmk what the next steps are for getting this library to partner!

Thanks,

-novin

[Hunter Freyer]

Hey Novin! 

Sorry this fell through the cracks. I was on vacation, and I didn't get coverage for my API Council Chair responsibilities. My bad.

I see that https://fuchsia-review.git.corp.google.com/c/fuchsia/+/878082 already went in, flipping this to "partner", but we should have a proper calibration even if it's post-hoc. Luckily, the library is pretty small, so we can probably do something asynchronously.

Could you prepare a CL that makes a whitespace change to the two C++ header files? We'll collect some feedback from council members on that CL.

Thanks,

Hunter

--
You received this message because you are subscribed to the Google Groups "api-council" group.
To unsubscribe from this group and stop receiving emails from it, send an email to api-council...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/api-council/CADUkUJ4Muk65P_Ns4sDd_pKtHrsDi50FjUN7OXWqZ-GCk-soJA%40mail.gmail.com.

[Novin Changizi]

Hi!

No worries at all, I ended up just reaching out to the library owners @Roland McGrath and @John Grossman to make sure they were ok with moving this to the partner sdk.

I didn't think an API calibration is needed for this library since it is really small, and has existed unchanged in the repo for a long time with lots of users. But just in case, I have created the cl here:

https://fuchsia-review.git.corp.google.com/c/fuchsia/+/887220

Thanks,

-novin

[Hunter Freyer]

Thanks Novin! Taking a look now.

Council members: please take a look sometime this week. I'm particularly looking for volunteers with understanding of our core libraries. It's quite quick!

Thanks,

Hunter

[Christopher Anderson]

Happy to take part.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/api-council/CAMkOBfuG2Y3qMgbyAzFrO%2Bh_FwYwjzQ9yOdo1GaG0pTzJc60WA%40mail.gmail.com.

[Hunter Freyer]

Reminder: last call for API council members to comment on this API https://fuchsia-review.git.corp.google.com/c/fuchsia/+/887220!