tests broken in master
1 view
Skip to first unread message
David Kavanagh
Mar 31, 2015, 5:29:09 PM3/31/15
to team-ui
Due to some nav changes, the tests are broken. Unsure how the branch passed CI, but nonetheless...
The nav changes mean tests that clicked on menus to get sub-menus won't work.
So, instead of clicking (say) the storage menu, we'd just click the hamburger icon for the dropdown and then click the "volumes" (for instance).
The resource-menu-dashboard is referenced 202 times in the tests. We'll have to at least look at all of those to see if this change needs to go there.
GUI-1489 has the latest nav changes and I'll work on tweaking there. Hopefully, that branch will pass and we can merge that into master, then other branches that are failing.
Hubenko, Alice
Mar 31, 2015, 5:58:10 PM3/31/15
to tea...@eucalyptus.com, Iglesias, Vic
I saw some merges that happened after failed CI , for instance PR #1324 was merged after a failed CI round that failed due to intermittent failures to clone from git. The commit containing nav changes could not have possibly passed the CI test.
I am trying to find the ticket/PR where the nav change was first introduced.
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To unsubscribe from this group and stop receiving emails from it, send an email to
team-ui+u...@eucalyptus.com.
To post to this group, send email to tea...@eucalyptus.com.
To view this discussion on the web visit
https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv3fon_81BqFS0%2BNgFCHn15wzS%3DL6Adk%3DyMpgUzRFy%3Dn1Q%40mail.gmail.com.
For more options, visit
https://groups.google.com/a/eucalyptus.com/d/optout.
Hubenko, Alice
Mar 31, 2015, 6:36:32 PM3/31/15
to tea...@eucalyptus.com, Iglesias, Vic
I tracked the change back to GUI-1474: update navigation to always use hamburger
https://github.com/eucalyptus/eucaconsole/pull/1304
It failed the first test which was re-run and somehow passed. http://jenkins.qa1.eucalyptus-systems.com/job/user-console-regression-sequence/13774/http://jenkins.qa1.eucalyptus-systems.com/job/user-console-regression-sequence/13774/
Not sure how that’s possible…investigating.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E7C37%40G9W0338.americas.hpqcorp.net.
David Kavanagh
Apr 6, 2015, 10:29:03 AM4/6/15
to team-ui, Iglesias, Vic
To add some more color to this, I noticed that GUI-1474 passed CI which is why it got merged with existing tests. I've noticed some other PRs Kamal submitted based on master also passed CI. I decided to create a new branch off master to make a PR and that also passed CI. Then, I created another branch with updated tests only and got that passing CI as well (some random infrastructure failures caused me to have this PR retested).
David
Since the tests in master rely on opening the menus of the old nav-bar, I'm not certain how they work. Many tests wait for a link like "resource-menuitem-volumes" to be visible and click it. I assume that must work sometimes when the element is not visible, otherwise tests wouldn't pass so often.
The changes I made in GUI-1474's new branch were to click "offcanvas-icon" to show the new nav menu, then click the resource-menuitem-XXX directly. I removed any selection of the old menus (like "menu-item-storage"). I think we could merge the GUI-1474 PR into master, though I'm still not certain why master doesn't fail consistently.
Thoughts or concerns?
David
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E84CE%40G9W0338.americas.hpqcorp.net.
Hubenko, Alice
Apr 6, 2015, 1:04:39 PM4/6/15
to tea...@eucalyptus.com, Iglesias, Vic
Thanks, David! I will look into these today. I suspect this is general selenium RC wonkiness. waitForVisible command probably not working correctly among other things.
Alice
From: David Kavanagh <david.k...@eucalyptus.com<mailto:david.k...@eucalyptus.com>>
Reply-To: "tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>" <tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>>
Date: Monday, April 6, 2015 at 7:29 AM
To: team-ui <tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>>
Cc: "Iglesias, Vic" <vic.ig...@hp.com<mailto:vic.ig...@hp.com>>
Subject: Re: tests broken in master
To add some more color to this, I noticed that GUI-1474 passed CI which is why it got merged with existing tests. I've noticed some other PRs Kamal submitted based on master also passed CI. I decided to create a new branch off master to make a PR and that also passed CI. Then, I created another branch with updated tests only and got that passing CI as well (some random infrastructure failures caused me to have this PR retested).
Since the tests in master rely on opening the menus of the old nav-bar, I'm not certain how they work. Many tests wait for a link like "resource-menuitem-volumes" to be visible and click it. I assume that must work sometimes when the element is not visible, otherwise tests wouldn't pass so often.
The changes I made in GUI-1474's new branch were to click "offcanvas-icon" to show the new nav menu, then click the resource-menuitem-XXX directly. I removed any selection of the old menus (like "menu-item-storage"). I think we could merge the GUI-1474 PR into master, though I'm still not certain why master doesn't fail consistently.
Thoughts or concerns?
David
Not sure how that’s possible…investigating.
From: Hubenko, Alice
Sent: Tuesday, March 31, 2015 2:57 PM
To: tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>
Cc: Iglesias, Vic
Subject: RE: tests broken in master
I saw some merges that happened after failed CI , for instance PR #1324 was merged after a failed CI round that failed due to intermittent failures to clone from git. The commit containing nav changes could not have possibly passed the CI test.
I am trying to find the ticket/PR where the nav change was first introduced.
From: David Kavanagh [mailto:david.k...@eucalyptus.com]
Sent: Tuesday, March 31, 2015 2:29 PM
To: team-ui
Subject: tests broken in master
Due to some nav changes, the tests are broken. Unsure how the branch passed CI, but nonetheless...
The nav changes mean tests that clicked on menus to get sub-menus won't work.
So, instead of clicking (say) the storage menu, we'd just click the hamburger icon for the dropdown and then click the "volumes" (for instance).
http://pastebin.com/6HVfTw3G
The resource-menu-dashboard is referenced 202 times in the tests. We'll have to at least look at all of those to see if this change needs to go there.
GUI-1489 has the latest nav changes and I'll work on tweaking there. Hopefully, that branch will pass and we can merge that into master, then other branches that are failing.
David
--
David Kavanagh
Console Team
HP Helion Eucalyptus
d...@hp.com<mailto:d...@hp.com>
@David_67
Hewlett-Packard Company
[cid:image0...@01CF6887.B1D47C00]
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv3fon_81BqFS0%2BNgFCHn15wzS%3DL6Adk%3DyMpgUzRFy%3Dn1Q%40mail.gmail.com<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv3fon_81BqFS0%2BNgFCHn15wzS%3DL6Adk%3DyMpgUzRFy%3Dn1Q%40mail.gmail.com?utm_medium=email&utm_source=footer>.
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E7C37%40G9W0338.americas.hpqcorp.net<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E7C37%40G9W0338.americas.hpqcorp.net?utm_medium=email&utm_source=footer>.
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E84CE%40G9W0338.americas.hpqcorp.net<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E84CE%40G9W0338.americas.hpqcorp.net?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/a/eucalyptus.com/d/optout.
--
David Kavanagh
Console Team
HP Helion Eucalyptus
d...@hp.com<mailto:d...@hp.com>
@David_67
Hewlett-Packard Company
[cid:image0...@01CF6887.B1D47C00]
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To unsubscribe from this group and stop receiving emails from it, send an email to team-ui+u...@eucalyptus.com<mailto:team-ui+u...@eucalyptus.com>.
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv0F_kCncBAMMWwxPfrqG8G1OEAvsmKm8bmMRsdH5adqdQ%40mail.gmail.com<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv0F_kCncBAMMWwxPfrqG8G1OEAvsmKm8bmMRsdH5adqdQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
Alice
From: David Kavanagh <david.k...@eucalyptus.com<mailto:david.k...@eucalyptus.com>>
Reply-To: "tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>" <tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>>
Date: Monday, April 6, 2015 at 7:29 AM
To: team-ui <tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>>
Cc: "Iglesias, Vic" <vic.ig...@hp.com<mailto:vic.ig...@hp.com>>
Subject: Re: tests broken in master
To add some more color to this, I noticed that GUI-1474 passed CI which is why it got merged with existing tests. I've noticed some other PRs Kamal submitted based on master also passed CI. I decided to create a new branch off master to make a PR and that also passed CI. Then, I created another branch with updated tests only and got that passing CI as well (some random infrastructure failures caused me to have this PR retested).
Since the tests in master rely on opening the menus of the old nav-bar, I'm not certain how they work. Many tests wait for a link like "resource-menuitem-volumes" to be visible and click it. I assume that must work sometimes when the element is not visible, otherwise tests wouldn't pass so often.
The changes I made in GUI-1474's new branch were to click "offcanvas-icon" to show the new nav menu, then click the resource-menuitem-XXX directly. I removed any selection of the old menus (like "menu-item-storage"). I think we could merge the GUI-1474 PR into master, though I'm still not certain why master doesn't fail consistently.
Thoughts or concerns?
David
On Tue, Mar 31, 2015 at 6:34 PM, Hubenko, Alice <al...@hp.com<mailto:al...@hp.com>> wrote:
I tracked the change back to GUI-1474: update navigation to always use hamburger
https://github.com/eucalyptus/eucaconsole/pull/1304
It failed the first test which was re-run and somehow passed. http://jenkins.qa1.eucalyptus-systems.com/job/user-console-regression-sequence/13774/http://jenkins.qa1.eucalyptus-systems.com/job/user-console-regression-sequence/13774/<http://jenkins.qa1.eucalyptus-systems.com/job/user-console-regression-sequence/13774/http:/jenkins.qa1.eucalyptus-systems.com/job/user-console-regression-sequence/13774/>
I tracked the change back to GUI-1474: update navigation to always use hamburger
https://github.com/eucalyptus/eucaconsole/pull/1304
Not sure how that’s possible…investigating.
From: Hubenko, Alice
Sent: Tuesday, March 31, 2015 2:57 PM
To: tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>
Cc: Iglesias, Vic
Subject: RE: tests broken in master
I saw some merges that happened after failed CI , for instance PR #1324 was merged after a failed CI round that failed due to intermittent failures to clone from git. The commit containing nav changes could not have possibly passed the CI test.
I am trying to find the ticket/PR where the nav change was first introduced.
From: David Kavanagh [mailto:david.k...@eucalyptus.com]
Sent: Tuesday, March 31, 2015 2:29 PM
To: team-ui
Subject: tests broken in master
Due to some nav changes, the tests are broken. Unsure how the branch passed CI, but nonetheless...
The nav changes mean tests that clicked on menus to get sub-menus won't work.
So, instead of clicking (say) the storage menu, we'd just click the hamburger icon for the dropdown and then click the "volumes" (for instance).
http://pastebin.com/6HVfTw3G
The resource-menu-dashboard is referenced 202 times in the tests. We'll have to at least look at all of those to see if this change needs to go there.
GUI-1489 has the latest nav changes and I'll work on tweaking there. Hopefully, that branch will pass and we can merge that into master, then other branches that are failing.
David
--
David Kavanagh
Console Team
HP Helion Eucalyptus
@David_67
Hewlett-Packard Company
[cid:image0...@01CF6887.B1D47C00]
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To unsubscribe from this group and stop receiving emails from it, send an email to team-ui+u...@eucalyptus.com<mailto:team-ui+u...@eucalyptus.com>.
You received this message because you are subscribed to the Google Groups "team-ui" group.
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv3fon_81BqFS0%2BNgFCHn15wzS%3DL6Adk%3DyMpgUzRFy%3Dn1Q%40mail.gmail.com<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv3fon_81BqFS0%2BNgFCHn15wzS%3DL6Adk%3DyMpgUzRFy%3Dn1Q%40mail.gmail.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/a/eucalyptus.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To unsubscribe from this group and stop receiving emails from it, send an email to team-ui+u...@eucalyptus.com<mailto:team-ui+u...@eucalyptus.com>.
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E7C37%40G9W0338.americas.hpqcorp.net<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E7C37%40G9W0338.americas.hpqcorp.net?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/a/eucalyptus.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To unsubscribe from this group and stop receiving emails from it, send an email to team-ui+u...@eucalyptus.com<mailto:team-ui+u...@eucalyptus.com>.
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E84CE%40G9W0338.americas.hpqcorp.net<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/542F37744926EC4791005FF007CF19F86E84CE%40G9W0338.americas.hpqcorp.net?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/a/eucalyptus.com/d/optout.
--
David Kavanagh
Console Team
HP Helion Eucalyptus
@David_67
Hewlett-Packard Company
[cid:image0...@01CF6887.B1D47C00]
--
You received this message because you are subscribed to the Google Groups "team-ui" group.
To post to this group, send email to tea...@eucalyptus.com<mailto:tea...@eucalyptus.com>.
To view this discussion on the web visit https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv0F_kCncBAMMWwxPfrqG8G1OEAvsmKm8bmMRsdH5adqdQ%40mail.gmail.com<https://groups.google.com/a/eucalyptus.com/d/msgid/team-ui/CAOcTqv0F_kCncBAMMWwxPfrqG8G1OEAvsmKm8bmMRsdH5adqdQ%40mail.gmail.com?utm_medium=email&utm_source=footer>.
Reply all
Reply to author
Forward
0 new messages