It doesn't build on Ubuntu 12.04

[Hossam Hammady]

I have libpq-dev, libpam-dev and libedit-dev,

I get this error when running make:

pgrhash.o: In function `pgrhash_create': /home/hammady/workspace/pg_catcheck/pgrhash.c:51: undefined reference to `fls' collect2: ld returned 1 exit status make: *** [pg_catcheck] Error 1

[Robert Haas]

If you add this line:

#include "port.h"

...immediately after the include of pg_catcheck.h, does that fix it?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[Hossam Hammady]

No this doesn't fix it. Please note that it is a linker error not a compiler error, there is a missing library that you need to link to.

[Hossam Hammady]

I found that the Ubuntu port of postgres doesn't include src/port/fls.c. I have simply grabbed it from https://github.com/postgres/postgres/blob/master/src/port/fls.c and added it to the Makefile.

Now it builds with no problems!

[Robert Haas]

On Sun, Dec 7, 2014 at 3:50 AM, Hossam Hammady <ham...@gmail.com> wrote:
> I found that the Ubuntu port of postgres doesn't include src/port/fls.c. I
> have simply grabbed it from
> https://github.com/postgres/postgres/blob/master/src/port/fls.c and added it
> to the Makefile.
> Now it builds with no problems!

Glad it's working. But I would have though that if fls() does not
exist on your platform, it would have been in pgport. I wonder why
not?

[Hossam Hammady]

don't you mean src/port in the main postgres tree? No it has been removed in Ubuntu. 

--

--

Thanks

Hossam Hammady

http://twitter.com/hammady