Groups

Dart Code Reviews

1–30 of 124888

All emails to this list are automatically generated when a code review is updated.

Please do not send emails to this list.

To learn how you can contribute, visit: https://code.google.com/p/dart/wiki/Contributing

To view all changes, visit: https://codereview.chromium.org/search?repo_guid=5387d39e155533a4abe4cc1bfe88223c824ee2ee

0 selected

Ryan Macnak (Gerrit), Alexander Aprelev (Gerrit)2

6:23 PM

[S] Change in dart/sdk[main]: Invoke tests with relative paths.

Attention needed from Ryan Macnak Alexander Aprelev voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[S] Change in dart/sdk[main]: Invoke tests with relative paths.

Attention needed from Ryan Macnak Alexander Aprelev voted Code-Review+1 Code-Review +1 Open in Gerrit

6:23 PM

Brian Wilkerson (Gerrit), … Phil Quitslund (Gerrit)3

6:15 PM

[S] Change in dart/sdk[main]: Don't lint on raw types in constant patterns if the matched type is o...

Attention needed from Brian Wilkerson and Jake Macdonald Phil Quitslund voted and added 1 comment

unread,

[S] Change in dart/sdk[main]: Don't lint on raw types in constant patterns if the matched type is o...

Attention needed from Brian Wilkerson and Jake Macdonald Phil Quitslund voted and added 1 comment

6:15 PM

Nate Bosch (Gerrit), Jake Macdonald (Gerrit)3

5:45 PM

[S] Change in dart/sdk[main]: [deps] rev core, dartdoc, ecosystem, http, shelf, test, tools

Attention needed from Nicholas Shahan Nate Bosch voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit

unread,

[S] Change in dart/sdk[main]: [deps] rev core, dartdoc, ecosystem, http, shelf, test, tools

Attention needed from Nicholas Shahan Nate Bosch voted Commit-Queue+2 Commit-Queue +2 Open in Gerrit

5:45 PM

Samuel Rawlins (Gerrit), … Kevin Moore (Gerrit)6

4:02 PM

[L] Change in dart/sdk[main]: [dart:io] Add WebSocket timeline instrumentation(GSoC'26)

Attention needed from Ben Konyi, Hangyu Jin, Samuel Rawlins and Yash Hosalli Kevin Moore voted and

unread,

[L] Change in dart/sdk[main]: [dart:io] Add WebSocket timeline instrumentation(GSoC'26)

Attention needed from Ben Konyi, Hangyu Jin, Samuel Rawlins and Yash Hosalli Kevin Moore voted and

4:02 PM

Jake Macdonald (Gerrit)

3:41 PM

[S] Change in dart/sdk[main]: Dont lint on raw types in constant patterns if the matched type is of...

Attention needed from Phil Quitslund Jake Macdonald voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[S] Change in dart/sdk[main]: Dont lint on raw types in constant patterns if the matched type is of...

Attention needed from Phil Quitslund Jake Macdonald voted Commit-Queue+1 Commit-Queue +1 Open in

3:41 PM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

3:34 PM

[S] Change in dart/sdk[main]: CQ. Migrate from assertInvalidTestCode() to resolveTestCodeWithDiagno...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: CQ. Migrate from assertInvalidTestCode() to resolveTestCodeWithDiagno...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:34 PM

Konstantin Shcheglov (Gerrit)

3:34 PM

[M] Change in dart/sdk[main]: CQ. Stop using assertErrorsInList() in AnalysisDriverCachingTest.

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[M] Change in dart/sdk[main]: CQ. Stop using assertErrorsInList() in AnalysisDriverCachingTest.

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

3:34 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

3:27 PM

[M] Change in dart/sdk[main]: [build] Fix RBE fallback on pkg, ddc and dyn bots.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [build] Fix RBE fallback on pkg, ddc and dyn bots.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:27 PM

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

3:26 PM

[S] Change in dart/sdk[main]: CQ. Remove SdkConstraintVerifierTest, assertErrorsInCode()

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: CQ. Remove SdkConstraintVerifierTest, assertErrorsInCode()

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

3:26 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

2:39 PM

[M] Change in dart/sdk[main]: Add an unnecessary_primary_constructor_body lint

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: Add an unnecessary_primary_constructor_body lint

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

2:39 PM

Kallen Tu (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

2:29 PM

[M] Change in dart/sdk[main]: [migrate] Allow additional force enabled codes in BulkFixProcessor.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [migrate] Allow additional force enabled codes in BulkFixProcessor.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

2:29 PM

Brian Wilkerson (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

2:28 PM

[M] Change in dart/sdk[main]: Augment. Deprecate MethodDeclaration.isAbstract, add isComplete to Co...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[M] Change in dart/sdk[main]: Augment. Deprecate MethodDeclaration.isAbstract, add isComplete to Co...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

2:28 PM

Samuel Rawlins (Gerrit), Keerti Parthasarathy (Gerrit)2

2:27 PM

[L] Change in dart/sdk[main]: DAS plugins: Export types from analyzer_plugin for convenience

Attention needed from Samuel Rawlins Keerti Parthasarathy voted Code-Review+1 Code-Review +1 Open in

unread,

[L] Change in dart/sdk[main]: DAS plugins: Export types from analyzer_plugin for convenience

Attention needed from Samuel Rawlins Keerti Parthasarathy voted Code-Review+1 Code-Review +1 Open in

2:27 PM

Slava Egorov (Gerrit), Alexander Aprelev (Gerrit)4

2:11 PM

[S] Change in dart/sdk[main]: [vm/isolate_api] Fix thread-starting race in threading_test.

Attention needed from Slava Egorov Alexander Aprelev added 1 comment Patchset-level comments File-

unread,

[S] Change in dart/sdk[main]: [vm/isolate_api] Fix thread-starting race in threading_test.

Attention needed from Slava Egorov Alexander Aprelev added 1 comment Patchset-level comments File-

2:11 PM

Konstantin Shcheglov (Gerrit)

2:07 PM

[M] Change in dart/sdk[main]: Fine. Store formal parameter default values separately from FunctionT...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

unread,

[M] Change in dart/sdk[main]: Fine. Store formal parameter default values separately from FunctionT...

Attention needed from Johnni Winther and Paul Berry Konstantin Shcheglov voted Commit-Queue+1 Commit-

2:07 PM

Nate Bosch (Gerrit), … Nicholas Shahan (Gerrit)3

1:49 PM

[S] Change in dart/sdk[main]: [deps] rev core, dartdoc, ecosystem, http, shelf, test, tools, vector...

Attention needed from Nate Bosch Nicholas Shahan added 1 comment File DEPS Line 155, Patchset 1 (

unread,

[S] Change in dart/sdk[main]: [deps] rev core, dartdoc, ecosystem, http, shelf, test, tools, vector...

Attention needed from Nate Bosch Nicholas Shahan added 1 comment File DEPS Line 155, Patchset 1 (

1:49 PM

Nate Bosch (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

1:49 PM

[XS] Change in dart/sdk[main]: Bump test to 2adf8b546d878cb7f6534653d0a821ac7e1f5753

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XS] Change in dart/sdk[main]: Bump test to 2adf8b546d878cb7f6534653d0a821ac7e1f5753

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:49 PM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

1:49 PM

[M] Change in dart/sdk[main]: CQ. Remove not useful PubSuggestionCodeTest, tweak for encoding test.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: CQ. Remove not useful PubSuggestionCodeTest, tweak for encoding test.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:49 PM

Alexander Markov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

1:29 PM

[S] Change in dart/sdk[main]: [vm] Cleanup unused UntaggedPcDescriptors::kBSSRelocation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[S] Change in dart/sdk[main]: [vm] Cleanup unused UntaggedPcDescriptors::kBSSRelocation

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

1:29 PM

Slava Egorov (Gerrit), Alexander Aprelev (Gerrit)2

1:24 PM

[S] Change in dart/sdk[main]: [vm/isolate_api] Ensure isolate acquisition fails gracefully when tar...

Attention needed from Slava Egorov Alexander Aprelev added 1 comment File runtime/vm/port.cc Line 257

unread,

[S] Change in dart/sdk[main]: [vm/isolate_api] Ensure isolate acquisition fails gracefully when tar...

Attention needed from Slava Egorov Alexander Aprelev added 1 comment File runtime/vm/port.cc Line 257

1:24 PM

Konstantin Shcheglov (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)8

12:51 PM

[S] Change in dart/sdk[main]: API. Deprecate FormalParameterElement.formalParameters and typeParame...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[S] Change in dart/sdk[main]: API. Deprecate FormalParameterElement.formalParameters and typeParame...

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

12:51 PM

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

12:34 PM

[XL] Change in dart/sdk[main]: Augment. Hide augmentation recovery elements from signatures

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[XL] Change in dart/sdk[main]: Augment. Hide augmentation recovery elements from signatures

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:34 PM

Johnni Winther (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)3

12:31 PM

[M] Change in dart/sdk[main]: CQ. Remove stale tests.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: CQ. Remove stale tests.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:31 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

12:23 PM

[M] Change in dart/sdk[main]: [build] Enable racing mode for Dart actions.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[M] Change in dart/sdk[main]: [build] Enable racing mode for Dart actions.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:23 PM

Ryan Macnak (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)4

12:16 PM

[L] Change in dart/sdk[main]: [build] Remove the platform/full SDK distinction.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

unread,

[L] Change in dart/sdk[main]: [build] Remove the platform/full SDK distinction.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Change information

12:16 PM

Kevin Moore (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)6

11:59 AM

[XS] Change in dart/sdk[main]: [build] Extract C++-only warning flags in GN compiler configs

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 7

unread,

[XS] Change in dart/sdk[main]: [build] Extract C++-only warning flags in GN compiler configs

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change Unreviewed changes 7

11:59 AM

Tess Strickland (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)9

10:54 AM

[S] Change in dart/sdk[main]: [vm,dyn_modules] Remove CompilerState use from CallMarshaller.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[S] Change in dart/sdk[main]: [vm,dyn_modules] Remove CompilerState use from CallMarshaller.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

10:54 AM

Bob Nystrom (Gerrit), … dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)5

10:07 AM

[XS] Change in dart/sdk[main]: Roll dart_style into the SDK.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

unread,

[XS] Change in dart/sdk[main]: Roll dart_style into the SDK.

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed

10:07 AM

Jens Johansen (Gerrit), Johnni Winther (Gerrit)3

9:37 AM

[S] Change in dart/sdk[main]: [analyzer] Fix _OverlayFile.writeAsBytesSync

Attention needed from Johnni Winther Jens Johansen added 2 comments File pkg/analyzer/test/

unread,

[S] Change in dart/sdk[main]: [analyzer] Fix _OverlayFile.writeAsBytesSync

Attention needed from Johnni Winther Jens Johansen added 2 comments File pkg/analyzer/test/

9:37 AM

Daco Harkes (Gerrit), … Bob Nystrom (Gerrit)5

9:24 AM

[XS] Change in dart/sdk[main]: [dartdev] Fix test package resolution

Bob Nystrom voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is empty

unread,

[XS] Change in dart/sdk[main]: [dartdev] Fix test package resolution

Bob Nystrom voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is empty

9:24 AM

Search

Clear search

Close search

Google apps

Main menu