Re: Change in dart/sdk[master]: [vm] Add weak mode to VM

3 views
Skip to first unread message

Vyacheslav Egorov

unread,
Jul 18, 2018, 4:15:44 AM7/18/18
to change...@dart-review.googlesource.com, Alexander Markov, Martin Kustermann, Ryan Macnak, Samir Jindel, Siva Annamalai, rev...@dartlang.org, vm-...@dartlang.org
I am strongly against this mode.

I can’t -1 this CL because I don’t have a laptop on me but count this as a -1.

On Wed, 18 Jul 2018 at 01.11, Alexander Markov (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

PTAL

Patch set 1:Commit-Queue +1

View Change

    To view, visit change 65484. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: I042cbccba83c105b61b3e11c659a35c20e0329cd
    Gerrit-Change-Number: 65484
    Gerrit-PatchSet: 1
    Gerrit-Owner: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
    Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
    Gerrit-Reviewer: Samir Jindel <sji...@google.com>
    Gerrit-Reviewer: Siva Annamalai <as...@google.com>
    Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>
    Gerrit-Comment-Date: Wed, 18 Jul 2018 00:11:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --

    // Vyacheslav Egorov
    Reply all
    Reply to author
    Forward
    0 new messages