Re: Change in dart/sdk[master]: [gardening] Fix up name detection in isolate tests.

2 views
Skip to first unread message

Ben Konyi

unread,
Mar 20, 2019, 10:33:49 AM3/20/19
to change...@dart-review.googlesource.com, rev...@dartlang.org, vm-...@dartlang.org, Martin Kustermann, commi...@chromium.org, Ryan Macnak
Hm, alright. I'm still confused but these fixes LGTM. 

On Tue, Mar 19, 2019, 11:51 PM 'Stevie Strickland (Gerrit)' via Dart Code Reviews <rev...@dartlang.org> wrote:

Patch Set 2:

I'm still uncertain as to how https://github.com/dart-lang/sdk/issues/36232 is still causing breakages after the commit in question being reverted. Do we know why we're seeing these failures?

Unsure. Is it possible that they already were approved errors, but when your CL came through and fixed the tests, that the approvals for failures went away, and then when the revert happened the tests now started visibly failing due to the lack of approvals?

You can see the diff, as it's very small, and it shows why the failures were happening. The lifecycle test looks for a suffix (using `endsWith`) of "main" to filter out non-spawned isolates, but the actual string ends in "main()" with parens. When set_rpc_name_test is compiled, it's compiled to <...>/out.dill and so the isolate is named "out.dill:main()", but that wasn't a possibility considered by the test.

The latter could have happened if the test infrastructure changed to compile to out.dill instead of, say, out.jitsnapshot, but I don't think that was a recent change. In the former case, it could be that the string representations of methods changed recently to add the parens, but since both original examples in set_name_rpc_test end in "main()", I also don't expect that to have been a recent change, hence the speculation about approvals because I don't see how these tests passed previously.

View Change

    To view, visit change 97220. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: I062669c07f4963291450b35a46fb73256505c706
    Gerrit-Change-Number: 97220
    Gerrit-PatchSet: 2
    Gerrit-Owner: Stevie Strickland <sstr...@google.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
    Gerrit-Reviewer: Stevie Strickland <sstr...@google.com>
    Gerrit-CC: Ryan Macnak <rma...@google.com>
    Gerrit-Comment-Date: Wed, 20 Mar 2019 06:51:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    --
    You received this message because you are subscribed to the Google Groups "Dart Code Reviews" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to reviews+u...@dartlang.org.
    Reply all
    Reply to author
    Forward
    0 new messages