Re: Change in dart/sdk[master]: [VM} Fix script URLs for dart:* libraries

5 views
Skip to first unread message

Ben Konyi

unread,
Feb 20, 2019, 1:44:35 PM2/20/19
to change...@dart-review.googlesource.com, Siva Annamalai, commi...@chromium.org, vm-...@dartlang.org, rev...@dartlang.org, Alexander Aprelev
Checking to see if this will be fixed by https://dart-review.googlesource.com/c/sdk/+/93373. Should know soon.

On Wed, Feb 20, 2019 at 10:39 AM Alexander Aprelev (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

This broke `flutter test` when running with --local-engine option:

```
02:33 +3600 ~30 -1: /usr/local/home/flutter/flutter/packages/flutter/test/foundation/stack_trace_test.dart: FlutterError.defaultStackFilter [E]
Expected: match '^#1 +Declarer\.test\.<anonymous closure>.<anonymous closure>.<anonymous closure> \(package:test_api/.+:[0-9]+:[0-9]+\)$'
Actual: '#1 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///usr/local/home/.pub-cache/hosted/pub.dartlang.org/test_api-0.2.2/lib/src/backend/declarer.dart:168:27)'
```

`file:`-uris are incorrectly reported instead of `package:`-uris.

Can this be reverted to turn hhh-buildbot back green?

View Change

    To view, visit change 92922. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: I645939e7ba937034471044fb492a5ecdb9a50bf5
    Gerrit-Change-Number: 92922
    Gerrit-PatchSet: 3
    Gerrit-Owner: Siva Annamalai <as...@google.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Siva Annamalai <as...@google.com>
    Gerrit-CC: Alexander Aprelev <a...@google.com>
    Gerrit-Comment-Date: Wed, 20 Feb 2019 18:39:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment
    Reply all
    Reply to author
    Forward
    0 new messages