Re: Change in dart/sdk[master]: [dart:io] Parse scoped IPv6 in constructor of InternetAddress

10 views
Skip to first unread message

Kevin Moore

unread,
May 8, 2020, 7:53:53 PM5/8/20
to change...@dart-review.googlesource.com, rev...@dartlang.org, vm-...@dartlang.org, Zach Anderson, Siva Annamalai, Jonas Termansen, commi...@chromium.org
Seems like the kind of thing that would be good to have a test for.

If we're limited by the bots, might be good to

1) create a skipped test – suree

2) have a corresponding bug requesting IPv6 abilities in our test lab

On Fri, May 8, 2020 at 4:47 PM Zichang Guo (Gerrit) <noreply-gerritcodereview-CI6EFmPW0vzZpY_1S0jAsQ==@google.com> wrote:

Patch Set 4:

Tests?

This can't be tested on a machine without scoped IPv6 addresses. I did a test locally. Do you want me to upload a test and keep it "skipped" by bots?

View Change

    To view, visit change 147060. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic7a140bc335e56550e39bb30390247db668c6101
    Gerrit-Change-Number: 147060
    Gerrit-PatchSet: 4
    Gerrit-Owner: Zichang Guo <zicha...@google.com>
    Gerrit-Reviewer: Jonas Termansen <sor...@google.com>
    Gerrit-Reviewer: Siva Annamalai <as...@google.com>
    Gerrit-Reviewer: Zach Anderson <z...@google.com>
    Gerrit-Reviewer: Zichang Guo <zicha...@google.com>
    Gerrit-CC: Kevin Moore <kev...@google.com>
    Gerrit-Comment-Date: Fri, 08 May 2020 23:47:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment
    Reply all
    Reply to author
    Forward
    0 new messages