Re: Change in dart/sdk[master]: [VM] Add Dart_InvokeVMServiceMethod() to dart_tools_api.h

[Martin Kustermann]

CL is already up for review: https://dart-review.googlesource.com/c/sdk/+/66567

(These TFA tests are not very robust and need re-generation of the expectation files)

On Wed, Jul 25, 2018 at 5:46 PM 'William Hesse (Gerrit)' via Dart Code Reviews <rev...@dartlang.org> wrote:

The package bots seem to have started failing with this change.

The interface of some object, dumped in some interface language, had a "*" changed to a "[]" in a function signature.

https://ci.chromium.org/p/dart/builders/luci.dart.ci.sandbox/pkg-mac-release/1449

View Change

To view, visit change 66384. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk

Gerrit-Branch: master

Gerrit-Change-Id: Ia54e5a73a0f0a4899e3e6d60694af0b394efb993

Gerrit-Change-Number: 66384

Gerrit-PatchSet: 4

Gerrit-Owner: Martin Kustermann <kuste...@google.com>

Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-Reviewer: Zach Anderson <z...@google.com>

Gerrit-CC: William Hesse <whe...@google.com>

Gerrit-CC: commi...@chromium.org <commi...@chromium.org>

Gerrit-Comment-Date: Wed, 25 Jul 2018 15:46:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

Gerrit-MessageType: comment

--
You received this message because you are subscribed to the Google Groups "Dart Code Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviews+u...@dartlang.org.