Re: Change in dart/sdk[master]: Call _asyncStarMoveNextHelper in kernel

3 views
Skip to first unread message

Vyacheslav Egorov

unread,
Jul 9, 2018, 1:15:56 PM7/9/18
to change...@dart-review.googlesource.com, Jens Johansen, dart-fe-te...@google.com, Dart Reviews, vm-...@dartlang.org, Kevin Millikin, Commit Bot, Alexander Markov, Karl Klose, Ryan Macnak
I think that is the cleanest solution - but I fear it is much larger refactoring. 

Right now we do pass environment defines down to compileToKernel (and Flutter even takes care of setting dart.vm.product for release builds) - but this is not passed further in FE which actually runs the async transformation.

// Vyacheslav Egorov


On Mon, Jul 9, 2018 at 7:14 PM Alexander Markov (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

Patch Set 5:

I suggested to actually emit

  if (...) _asyncStartHelper(...) 

The code as it is written right now would not actually work - because front-end is running on non-product VM in Flutter.

You're right, CFE should take defines as options instead of relying on the host VM configuration. Environment defines (such as 'dart.vm.product') are used in constants transformation and Flutter should be passing them to front-end already. Does it make sense to pass environment defines through CompilerOptions or Target and use in async transformation as well?

View Change

    To view, visit change 63624. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: I4969ca48f798bd51f9d2d5bc26dd224fa7eff627
    Gerrit-Change-Number: 63624
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jens Johansen <je...@google.com>
    Gerrit-Reviewer: Jens Johansen <je...@google.com>
    Gerrit-Reviewer: Kevin Millikin <kmil...@google.com>
    Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>
    Gerrit-CC: Alexander Markov <alexm...@google.com>
    Gerrit-CC: Karl Klose <karl...@google.com>
    Gerrit-CC: Ryan Macnak <rma...@google.com>
    Gerrit-Comment-Date: Mon, 09 Jul 2018 17:14:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment
    Reply all
    Reply to author
    Forward
    0 new messages