Re: Change in dart/sdk[master]: [vm/kernel] Re-land partial instantiation of local functions.

3 views

Skip to first unread message

Vyacheslav Egorov

unread,

May 4, 2018, 12:21:10 PM5/4/18

to change...@dart-review.googlesource.com, Kevin Millikin, Samir Jindel, Siva Annamalai, commi...@chromium.org, rev...@dartlang.org, vm-...@dartlang.org

I would like a separate regression test for instantiation itself if possible. I added a slightly different one.

On Fri, 4 May 2018 at 18.17, Régis Crelier (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

Oh, never mind. Slava added the regression test: https://dart-review.googlesource.com/c/sdk/+/53742
View Change
To view, visit change 53801. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk

Gerrit-Branch: master

Gerrit-Change-Id: I434a42578b91f0930b088c4d264d882c3ef5b4a3

Gerrit-Change-Number: 53801

Gerrit-PatchSet: 2

Gerrit-Owner: Samir Jindel <sji...@google.com>

Gerrit-Reviewer: Régis Crelier <re...@google.com>

Gerrit-Reviewer: Samir Jindel <sji...@google.com>

Gerrit-CC: Kevin Millikin <kmil...@google.com>

Gerrit-CC: Siva Annamalai <as...@google.com>

Gerrit-CC: Vyacheslav Egorov <veg...@google.com>

Gerrit-CC: commi...@chromium.org <commi...@chromium.org>

Gerrit-Comment-Date: Fri, 04 May 2018 16:17:10 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

Gerrit-MessageType: comment