Re: Change in dart/sdk[master]: [vm] Add unsafe mode to VM
11 views
Skip to first unread message
Vyacheslav Egorov
Jul 19, 2018, 2:40:03 PM7/19/18
to change...@dart-review.googlesource.com, Alexander Markov, Martin Kustermann, Ryan Macnak, Samir Jindel, commi...@chromium.org, rev...@dartlang.org, vm-...@dartlang.org
I withdraw my -1 given the interim nature of the change.
My only request is to rename the flag into something that starts with “experimental”, “provisional” or “interim”.
I can’t properly review this from my phone, so I can’t give explicit +1
On Thu, 19 Jul 2018 at 19.23, Siva Annamalai (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:
I understand the concerns around this CL but am recommending that we go ahead with it as an interim way to for the internal tools to bridge the performance regressions we are seeing. I have filed an issue (https://github.com/dart-lang/sdk/issues/33915) to actively track removal of this flag.
Patch set 3:Code-Review +1
1 comment:
File runtime/vm/compiler/jit/compiler.cc:
Patch Set #3, Line 146:
"Omit strong mode type checks and disable optimizations based on types.");maybe is should say 'omit runtime strong mode type checks...' as the front end will still be doing the static checks.
To view, visit change 65484. To unsubscribe, or for help writing mail filters, visit settings.
// Vyacheslav Egorov
Reply all
Reply to author
Forward
0 new messages