Re: Change in dart/sdk[master]: [vm] Add unsafe mode to VM

11 views
Skip to first unread message

Vyacheslav Egorov

unread,
Jul 19, 2018, 2:40:03 PM7/19/18
to change...@dart-review.googlesource.com, Alexander Markov, Martin Kustermann, Ryan Macnak, Samir Jindel, commi...@chromium.org, rev...@dartlang.org, vm-...@dartlang.org
I withdraw my -1 given the interim nature of the change.

My only request is to rename the flag into something that starts with “experimental”, “provisional” or “interim”. 

I can’t properly review this from my phone, so I can’t give explicit +1

On Thu, 19 Jul 2018 at 19.23, Siva Annamalai (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

I understand the concerns around this CL but am recommending that we go ahead with it as an interim way to for the internal tools to bridge the performance regressions we are seeing. I have filed an issue (https://github.com/dart-lang/sdk/issues/33915) to actively track removal of this flag.

Patch set 3:Code-Review +1

View Change

1 comment:

To view, visit change 65484. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: master
Gerrit-Change-Id: I042cbccba83c105b61b3e11c659a35c20e0329cd
Gerrit-Change-Number: 65484
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Ryan Macnak <rma...@google.com>
Gerrit-Reviewer: Samir Jindel <sji...@google.com>
Gerrit-Reviewer: Siva Annamalai <as...@google.com>
Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>
Gerrit-Comment-Date: Thu, 19 Jul 2018 18:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--

// Vyacheslav Egorov
Reply all
Reply to author
Forward
0 new messages