Re: Change in dart/sdk[master]: [vm/kernel/bytecode] Implement strong mode type checks in bytecode

5 views
Skip to first unread message

Régis Crelier

unread,
Jun 19, 2018, 12:08:43 PM6/19/18
to change...@dart-review.googlesource.com, Alexander Markov, Dart Reviews, vm-...@dartlang.org, Martin Kustermann, Vyacheslav Egorov
LGTM

Thanks for implementing my side too :-)

I get (temporary?) server errors on Gerrit and cannot approve the normal way. I send this email instead.

-- Regis

On Tue, Jun 19, 2018 at 8:46 AM Zach Anderson (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

Patch set 2:Code-Review +1

View Change

    To view, visit change 60822. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic265ea6a7fca2bfcc9a96e4ede268ec8e693ff41
    Gerrit-Change-Number: 60822
    Gerrit-PatchSet: 2
    Gerrit-Owner: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
    Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
    Gerrit-Reviewer: Régis Crelier <re...@google.com>
    Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>
    Gerrit-Reviewer: Zach Anderson <z...@google.com>
    Gerrit-Comment-Date: Tue, 19 Jun 2018 15:46:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    Reply all
    Reply to author
    Forward
    0 new messages