Re: Change in sdk[master]: [Kernel] Check return type of native functions in strong mode (fixes ...

[Vyacheslav Egorov]

I have sent a PR to Flutter engine to address issues not addressed by Jason's change. 

https://github.com/flutter/engine/pull/4676

Once that lands Flutter tests no longer find any other issues - so we should be fine.

// Vyacheslav Egorov

On Tue, Feb 13, 2018 at 6:18 PM, Régis Crelier (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

Patch Set 3:

Note: this introduces 300+ failures on Flutter tests.

We might want hold off landing it - unless we hear from Jason that he is close to fixing Tonic.

Thanks. I'll wait. Please, keep me posted.

View Change

To view, visit change 40641. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk

Gerrit-Branch: master

Gerrit-MessageType: comment

Gerrit-Change-Id: I01ff80e9ec5c625a0855a22498f9c2d738de4678

Gerrit-Change-Number: 40641

Gerrit-PatchSet: 3

Gerrit-Owner: Régis Crelier <re...@google.com>

Gerrit-Reviewer: Régis Crelier <re...@google.com>

Gerrit-Reviewer: Siva Annamalai <as...@google.com>

Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>

Gerrit-CC: Dart Reviews <rev...@dartlang.org>

Gerrit-Comment-Date: Tue, 13 Feb 2018 17:18:04 +0000

Gerrit-HasComments: No

Gerrit-HasLabels: No