Re: Change in dart/sdk[master]: Reland "[VM] Introduction of type testing stubs - Part 1-4"

5 views

Skip to first unread message

Vyacheslav Egorov

unread,

Apr 12, 2018, 6:15:01 PM4/12/18

to Régis Crelier, Martin Kustermann, rev...@dartlang.org, vm-...@dartlang.org

Hi Regis,

This reland follows the convention: Patch Set 1 contains original change that got reverted, everything else is a difference from the original change. So you can compare Patch Set 1 against Patch Set 3 by selecting PS 1 in the drop down that by default says “Base”. This would reveal the changes.

Thanks for taking a look!

On Thu, 12 Apr 2018 at 20.51, Régis Crelier (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

I have reviewed each one of the 4 parts.
It is hard to see what has changed regarding type arguments in this "reland" cl.
Still looks good to me.
Patch set 3:Code-Review +1
View Change
To view, visit change 50944. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk

Gerrit-Branch: master

Gerrit-Change-Id: Ib79fbe7f043aa88f32bddad62d7656c638914b44

Gerrit-Change-Number: 50944

Gerrit-PatchSet: 3

Gerrit-Owner: Martin Kustermann <kuste...@google.com>

Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>

Gerrit-Reviewer: Régis Crelier <re...@google.com>

Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>

Gerrit-CC: Keerti Parthasarathy <kee...@google.com>

Gerrit-CC: Zach Anderson <z...@google.com>

Gerrit-CC: commi...@chromium.org <commi...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Apr 2018 18:51:28 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

Gerrit-MessageType: comment

// Vyacheslav Egorov

Régis Crelier

unread,

Apr 12, 2018, 6:17:05 PM4/12/18

to Vyacheslav Egorov, Martin Kustermann, Dart Reviews, vm-...@dartlang.org

On it! Thanks.

On Thu, Apr 12, 2018 at 3:14 PM, Vyacheslav Egorov <veg...@google.com> wrote:

Hi Regis,

This reland follows the convention: Patch Set 1 contains original change that got reverted, everything else is a difference from the original change. So you can compare Patch Set 1 against Patch Set 3 by selecting PS 1 in the drop down that by default says “Base”. This would reveal the changes.

Thanks for taking a look!