Re: Change in sdk[master]: [observatory] Remove references to pkg:browser from web/index.html

2 views

Skip to first unread message

Kevin Moore

unread,

Mar 30, 2018, 1:05:31 PM3/30/18

to change...@dart-review.googlesource.com, Siva Annamalai, rev...@dartlang.org, vm-...@dartlang.org, Commit Bot

We can certainly get rid of dart_to_js_script_rewriter – this is only there for the import case we just eliminated...

On Fri, Mar 30, 2018 at 9:54 AM Ryan Macnak (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

View Change
1 comment:
File runtime/observatory/pubspec.yaml:
Patch Set #5, Line 21: browser:
Didn't quite get rid of browser...
There are still transitive dependencies through dart_to_js_script_rewriter, csslib, usage, and charted.
To view, visit change 48804. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk

Gerrit-Branch: master

Gerrit-Change-Id: I3d48fd59f1fedc9d64a652cde7d0229c0a7ace28

Gerrit-Change-Number: 48804

Gerrit-PatchSet: 5

Gerrit-Owner: Siva Annamalai <as...@google.com>

Gerrit-Reviewer: Kevin Moore <kev...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-Reviewer: Siva Annamalai <as...@google.com>

Gerrit-CC: commi...@chromium.org <commi...@chromium.org>

Gerrit-Comment-Date: Fri, 30 Mar 2018 16:54:26 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kevin Moore <kev...@google.com>

Gerrit-MessageType: comment

Reply all

Reply to author

Forward

0 new messages