Re: Change in sdk[master]: Provide distinct BigInt implementation classes in VM, dart2js, and da...

5 views
Skip to first unread message

Stephen Adams

unread,
Jan 19, 2018, 6:05:44 PM1/19/18
to change...@dart-review.googlesource.com, vm-...@dartlang.org, commi...@chromium.org, Jenny Messerly, Siva Annamalai, Keerti Parthasarathy, Dart Reviews, Zach Anderson
The library tag in the patch file might conflict with one in the main file.

I would avoid using part files and import the implementation.
This will require renaming _BigIntImpl to BigIntImpl.

On Fri, Jan 19, 2018 at 3:01 PM, Régis Crelier (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

The added line "library dart.core;" in core_patch.dart was necessary to build dart2js when including a part file. However, it is causing errors with the dart2js-linux-none-only-unittest configuration. See try bots.

Stephen, any idea how to resolve this issue without going back to the full inlined version?

Thanks,
Regis

View Change

    To view, visit change 35521. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-MessageType: comment
    Gerrit-Change-Id: I8397fd927b89fa745ac7aa4b8d98e562140f731b
    Gerrit-Change-Number: 35521
    Gerrit-PatchSet: 7
    Gerrit-Owner: Régis Crelier <re...@google.com>
    Gerrit-Reviewer: Jenny Messerly <jmes...@google.com>
    Gerrit-Reviewer: Régis Crelier <re...@google.com>
    Gerrit-Reviewer: Siva Annamalai <as...@google.com>
    Gerrit-Reviewer: Stephen Adams <s...@google.com>
    Gerrit-CC: Dart Reviews <rev...@dartlang.org>
    Gerrit-CC: Keerti Parthasarathy <kee...@google.com>
    Gerrit-CC: Zach Anderson <z...@google.com>
    Gerrit-Comment-Date: Fri, 19 Jan 2018 23:01:00 +0000
    Gerrit-HasComments: No
    Gerrit-HasLabels: No

    Reply all
    Reply to author
    Forward
    0 new messages