Re: Change in dart/sdk[master]: Declare return types of Uint8List.
6 views
Skip to first unread message
Kevin Moore
May 8, 2019, 1:17:51 AM5/8/19
to change...@dart-review.googlesource.com, rev...@dartlang.org, vm-...@dartlang.org, Michael Thomsen, commi...@chromium.org, Zach Anderson
I hear you. And I love this change in theory.
Guessing you should start this dance, at a minimum – https://github.com/dart-lang/sdk/blob/master/docs/process/breaking-changes.md
From: Todd Volkert (Gerrit) <noreply-gerritcoderevie...@google.com>
Date: Tue, May 7, 2019 at 10:13 PM
Cc: <rev...@dartlang.org>, <vm-...@dartlang.org>, Michael Thomsen, Kevin Moore, commi...@chromium.org, Zach Anderson
Date: Tue, May 7, 2019 at 10:13 PM
Cc: <rev...@dartlang.org>, <vm-...@dartlang.org>, Michael Thomsen, Kevin Moore, commi...@chromium.org, Zach Anderson
It's a _technically_ breaking change. That said, if any class was implementing these interfaces to return anything other than a Uint8List, it was doing something very bad and exposing code to weird breakages because of all the places where callers have assumed the Uint8List return value. e.g. see https://github.com/dart-lang/sdk/issues/31547#issuecomment-349942106
To view, visit change 101742. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages