Re: Change in dart/sdk[master]: Declare return types of Uint8List.

Skip to first unread message

Kevin Moore

May 8, 2019, 1:17:51 AM5/8/19
to,,, Michael Thomsen,, Zach Anderson
I hear you. And I love this change in theory.

Guessing you should start this dance, at a minimum –

From: Todd Volkert (Gerrit) <>
Date: Tue, May 7, 2019 at 10:13 PM
Cc: <>, <>, Michael Thomsen, Kevin Moore,, Zach Anderson

It's a _technically_ breaking change. That said, if any class was implementing these interfaces to return anything other than a Uint8List, it was doing something very bad and exposing code to weird breakages because of all the places where callers have assumed the Uint8List return value. e.g. see

View Change

    To view, visit change 101742. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic3bc1db0d64de36fb68b1d8d98037eed1464f978
    Gerrit-Change-Number: 101742
    Gerrit-PatchSet: 2
    Gerrit-Owner: Todd Volkert <>
    Gerrit-Reviewer: Todd Volkert <>
    Gerrit-Reviewer: Zach Anderson <>
    Gerrit-CC: Kevin Moore <>
    Gerrit-CC: Michael Thomsen <>
    Gerrit-Comment-Date: Wed, 08 May 2019 05:13:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment
    Reply all
    Reply to author
    0 new messages