Re: Change in dart/sdk[master]: [VM] Extract common code from Assembler to new AssemblerBase base class

[Vyacheslav Egorov]

Thanks for diagnosing and reverting! 

// Vyacheslav Egorov

On Tue, Oct 30, 2018 at 12:44 AM Ryan Macnak (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

View Change

1 comment:

• File runtime/vm/compiler/assembler/assembler_arm64.h:

  • Patch Set #4, Line 1630:

    prologue_offset_ is now uninitialized and shadows the one from AssemblerBase.

    https://github.com/dart-lang/sdk/issues/34973

To view, visit change 81641. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk

Gerrit-Branch: master

Gerrit-Change-Id: Ie7189081b3acac53a80a399b1353261c2312da79

Gerrit-Change-Number: 81641

Gerrit-PatchSet: 4

Gerrit-Owner: Martin Kustermann <kuste...@google.com>

Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>

Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>

Gerrit-Reviewer: commi...@chromium.org <commi...@chromium.org>

Gerrit-CC: Ryan Macnak <rma...@google.com>

Gerrit-Comment-Date: Mon, 29 Oct 2018 23:44:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Gerrit-MessageType: comment