Re: Change in sdk[master]: Add pragma class to dart:core.

7 views
Skip to first unread message

Vyacheslav Egorov

unread,
Mar 2, 2018, 5:43:02 AM3/2/18
to change...@dart-review.googlesource.com, vm-...@dartlang.org, Lasse R.H. Nielsen, Leaf Petersen, Keerti Parthasarathy, Dart Reviews
That's an interesting consideration. 

I did not anticipate there are cases where different embedder refer to different subsets of entry points inside the same library. 

I was thinking that embedder can instead control what goes into their platform at library granularity, e.g. a library as whole is either used or not. It seems to be true for the current AOT consumers.

Do we have examples (or do we anticipate use cases) where this is not the case?






// Vyacheslav Egorov

On Thu, Mar 1, 2018 at 10:30 PM, Zach Anderson (Gerrit) <noreply-gerritcoderevie...@google.com> wrote:

So all entry points, even those in Flutter would be annotated with "vm:extern"

Okay, so in that model IIUC, the dart:io entrypoints in that list in main will also need to have @pragma('vm:extern') on them.

Is there a concern that different embedders of the VM may have different entrypoints? If we don't distinguish between embedders, then the AOT compiler may include more code than necessary.

View Change

    To view, visit change 43062. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: master
    Gerrit-Change-Id: Icf2106accfb1167124582466a3a55486d432793d
    Gerrit-Change-Number: 43062
    Gerrit-PatchSet: 5
    Gerrit-Owner: Vyacheslav Egorov <veg...@google.com>
    Gerrit-Reviewer: Lasse R.H. Nielsen <l...@google.com>
    Gerrit-Reviewer: Leaf Petersen <le...@google.com>
    Gerrit-Reviewer: Vyacheslav Egorov <veg...@google.com>
    Gerit-CC: Dart Reviews <rev...@dartlang.org>
    Gerit-CC: Keerti Parthasarathy <kee...@google.com>
    Gerit-CC: Zach Anderson <z...@google.com>
    Gerrit-Comment-Date: Thu, 01 Mar 2018 21:30:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Reply all
    Reply to author
    Forward
    0 new messages