Seems like the kind of thing that would be good to have a test for. If we're limited by the bots,

Thank you for doing this refactoring! On Fri, 25 Oct 2019 at 00.31, commi...@chromium.org (Gerrit)

FYI https://www.reddit.com/r/etymology/comments/3ic9y7/why_is_it_that_transferable_and_transferrable/

I hear you. And I love this change in theory. Guessing you should start this dance, at a minimum –

https://github.com/dart-lang/sdk/wiki/5-Commit-Message-Best-Practices :-) DO Use the full GitHub URL

Hm, alright. I'm still confused but these fixes LGTM. On Tue, Mar 19, 2019, 11:51 PM 'Stevie

> I don't fully understand why this check insists on a pre-installed dart:

Checking to see if this will be fixed by https://dart-review.googlesource.com/c/sdk/+/93373. Should

I'm guessing any impl we do on the JS side would be no worse than what a user could/would do by

Thanks for the reply bro. You mentioned that "all these handles become part of the root set

Thanks for diagnosing and reverting! // Vyacheslav Egorov On Tue, Oct 30, 2018 at 12:44 AM Ryan

Hi, it doesn't really matter, only 1.34 sec less.. $ time dart --snapshot=map.snap map.dart

CL is already up for review: https://dart-review.googlesource.com/c/sdk/+/66567 (These TFA tests are

I withdraw my -1 given the interim nature of the change. My only request is to rename the flag into

I am strongly against this mode. I can't -1 this CL because I don't have a laptop on me but

I think that is the cleanest solution - but I fear it is much larger refactoring. Right now we do

LGTM Thanks for implementing my side too :-) I get (temporary?) server errors on Gerrit and cannot

Thanks! That make it clear to me. On Wed, May 9, 2018 at 3:47 PM Samir Jindel <sji...@google.com

I would like a separate regression test for instantiation itself if possible. I added a slightly

On it! Thanks. On Thu, Apr 12, 2018 at 3:14 PM, Vyacheslav Egorov <veg...@google.com> wrote:

We can certainly get rid of dart_to_js_script_rewriter – this is only there for the import case we

Oops. I did not notice that this got stuck in the CQ. I will fix a CQ failure. // Vyacheslav Egorov

That's an interesting consideration. I did not anticipate there are cases where different

Hi! I'm a game developer and I would like to integrate Dart VM with my game engine. From what I

I have sent a PR to Flutter engine to address issues not addressed by Jason's change. https://

Hey, I'm trying to build the dart sdk from the sources in order to create a solus package. i have

FYI this CL has failed on SIMARM64: https://ci.chromium.org/p/dart/builds/b8956774519756276976 python

The library tag in the patch file might conflict with one in the main file. I would avoid using part

Hi Siva, For example this one: https://logs.chromium.org/v/?s=dart%2Fbuildbucket%2Fcr-buildbucket.

Sounds good to me. On Thu, Jan 18, 2018 at 5:58 PM, Siva Annamalai <as...@google.com> wrote: ​