[L] Change in dart/sdk[main]: [cfe] Make Scope and VariableContext data objects, not TreeNodes

0 views
Skip to first unread message

Chloe Stefantsova (Gerrit)

unread,
May 11, 2026, 9:26:36 AM (2 days ago) May 11
to Chloe Stefantsova, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie4f244433c320c3a72e8769034526e438dc6406c
Gerrit-Change-Number: 502682
Gerrit-PatchSet: 2
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Mon, 11 May 2026 13:26:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
May 11, 2026, 9:34:29 AM (2 days ago) May 11
to Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chloe Stefantsova
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie4f244433c320c3a72e8769034526e438dc6406c
Gerrit-Change-Number: 502682
Gerrit-PatchSet: 2
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Comment-Date: Mon, 11 May 2026 13:34:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chloe Stefantsova (Gerrit)

unread,
3:53 AM (6 hours ago) 3:53 AM
to Chloe Stefantsova, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org

Chloe Stefantsova voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie4f244433c320c3a72e8769034526e438dc6406c
Gerrit-Change-Number: 502682
Gerrit-PatchSet: 3
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 07:53:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
4:40 AM (5 hours ago) 4:40 AM
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[cfe] Make Scope and VariableContext data objects, not TreeNodes

Part of https://github.com/dart-lang/sdk/issues/61572
Change-Id: Ie4f244433c320c3a72e8769034526e438dc6406c
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Chloe Stefantsova <cstefa...@google.com>
Files:
  • M pkg/front_end/lib/src/fragment/constructor/encoding.dart
  • M pkg/front_end/lib/src/fragment/factory/encoding.dart
  • M pkg/front_end/lib/src/fragment/field/encoding.dart
  • M pkg/front_end/lib/src/fragment/getter/encoding.dart
  • M pkg/front_end/lib/src/fragment/method/encoding.dart
  • M pkg/front_end/lib/src/fragment/setter/encoding.dart
  • M pkg/front_end/lib/src/type_inference/inference_visitor.dart
  • M pkg/kernel/lib/src/ast/variables.dart
  • M pkg/kernel/lib/src/coverage.dart
  • M pkg/kernel/lib/src/equivalence.dart
  • M pkg/kernel/lib/src/node_creator.dart
  • M pkg/kernel/lib/visitor.dart
Change size: L
Delta: 12 files changed, 140 insertions(+), 284 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Johnni Winther
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie4f244433c320c3a72e8769034526e438dc6406c
Gerrit-Change-Number: 502682
Gerrit-PatchSet: 4
Gerrit-Owner: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Chloe Stefantsova <cstefa...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages