[L] Change in dart/sdk[main]: [cfe] Make Scope and VariableContext data objects, not TreeNodes
0 views
Skip to first unread message
Chloe Stefantsova (Gerrit)
May 11, 2026, 9:26:36 AM (2 days ago) May 11
to Chloe Stefantsova, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
May 11, 2026, 9:34:29 AM (2 days ago) May 11
to Chloe Stefantsova, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Chloe Stefantsova
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Chloe Stefantsova
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chloe Stefantsova (Gerrit)
3:53 AM (6 hours ago) 3:53 AM
to Chloe Stefantsova, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
Chloe Stefantsova voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
4:40 AM (5 hours ago) 4:40 AM
to Chloe Stefantsova, Johnni Winther, Alexander Markov, Jens Johansen, dart-fe-te...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[cfe] Make Scope and VariableContext data objects, not TreeNodes
Part of https://github.com/dart-lang/sdk/issues/61572
Change-Id: Ie4f244433c320c3a72e8769034526e438dc6406c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/502682
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Chloe Stefantsova <cstefa...@google.com>
Files:
- M pkg/front_end/lib/src/fragment/constructor/encoding.dart
- M pkg/front_end/lib/src/fragment/factory/encoding.dart
- M pkg/front_end/lib/src/fragment/field/encoding.dart
- M pkg/front_end/lib/src/fragment/getter/encoding.dart
- M pkg/front_end/lib/src/fragment/method/encoding.dart
- M pkg/front_end/lib/src/fragment/setter/encoding.dart
- M pkg/front_end/lib/src/type_inference/inference_visitor.dart
- M pkg/kernel/lib/src/ast/variables.dart
- M pkg/kernel/lib/src/coverage.dart
- M pkg/kernel/lib/src/equivalence.dart
- M pkg/kernel/lib/src/node_creator.dart
- M pkg/kernel/lib/visitor.dart
Change size: L
Delta: 12 files changed, 140 insertions(+), 284 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages