[M] Change in dart/sdk[main]: [migrate] Add tool tip to use apply after a dry run.
0 views
Skip to first unread message
Kallen Tu (Gerrit)
1:00 PM (6 hours ago) 1:00 PM
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
1:19 PM (6 hours ago) 1:19 PM
to Kallen Tu, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kallen Tu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
1:21 PM (6 hours ago) 1:21 PM
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Kallen Tu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
1:22 PM (6 hours ago) 1:22 PM
to Kallen Tu, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[migrate] Add tool tip to use apply after a dry run.
After running a dry-run that has proposed changes, the tool outputs:
```
To apply the proposed changes, run:
dart migrate --apply --step=<steps> <path>
```
- Return a `WorkspaceEdit` in `DartMigrateResult` so clients can decide
whether or not they want to apply the edits and so that they can provide
a tool tip for running `--apply`.
- Removes `apply` from `MigrationRunner` entirely. We always merge and
return the edits.
Change-Id: Ib8052a343ce0e8c9ee6afaf7a96d2d5f3cabd8df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/531440
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Kallen Tu <kall...@google.com>
Files:
- M pkg/analysis_server/lib/src/lsp/handlers/custom/handler_migrate.dart
- M pkg/analysis_server/lib/src/lsp/handlers/custom/migration/migration_runner.dart
- M pkg/analysis_server/test/lsp/migrate_test.dart
- M pkg/dartdev/lib/src/commands/migrate.dart
- M pkg/dartdev/test/commands/migrate_test.dart
Change size: M
Delta: 5 files changed, 79 insertions(+), 31 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages