[M] Change in dart/sdk[main]: linter: Support primary constructors in sort{,_unnamed}_constructors_...

[Konstantin Shcheglov (Gerrit)]

Attention needed from Brian Wilkerson and Samuel Rawlins

Konstantin Shcheglov voted and added 2 comments

Votes added by Konstantin Shcheglov

Code-Review

+1

2 comments

File pkg/linter/test/rules/sort_constructors_first_test.dart

Line 38, Patchset 4 (Latest): test_enum_primaryBody_afterMethod() async {

Konstantin Shcheglov . unresolved

Not consistent name: `PrimaryConstructorBody` above.

File pkg/linter/test/rules/sort_unnamed_constructors_first_test.dart

Line 21, Patchset 4 (Latest): test_class_new_sorted() async {

Konstantin Shcheglov . unresolved

FYI, there is also thing called "newHead", e.g.
```
class A {
  new named();
}
```
Not sure if you intended to support it in a separate pass.

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I14c00358b2145d00d0d38f0ddba22f4d4a1c00f6

Gerrit-Change-Number: 480741

Gerrit-PatchSet: 4

Gerrit-Owner: Samuel Rawlins <sraw...@google.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Sun, 15 Feb 2026 04:12:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes