[L] Change in dart/sdk[main]: [vm] Nicer disassembly for RISC-V hints.
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Dec 9, 2025, 5:25:17 PM12/9/25
to Alexander Aprelev, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Aprelev
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alexander Aprelev
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Aprelev (Gerrit)
Dec 10, 2025, 1:51:37 PM12/10/25
to Ryan Macnak, Alexander Aprelev, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Ryan Macnak
Alexander Aprelev voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ryan Macnak
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ryan Macnak (Gerrit)
Dec 10, 2025, 1:54:03 PM12/10/25
to Alexander Aprelev, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Ryan Macnak voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 10, 2025, 2:19:22 PM12/10/25
to Ryan Macnak, Alexander Aprelev, dart-vm-compil...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vm] Nicer disassembly for RISC-V hints.
Add missing byte and halfword compare-and-swap.
Add missing clear of reservation after SC.
Define XLEN aliases for the AMOs.
Add wait-on-reservation-set.
More systematically print state on fault.
TEST=ci
Change-Id: Ia07e638a6e08cd40eecc1f8f7d242fd94ef2f2d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467200
Commit-Queue: Ryan Macnak <rma...@google.com>
Reviewed-by: Alexander Aprelev <a...@google.com>
Files:
- M runtime/vm/compiler/asm_intrinsifier_riscv.cc
- M runtime/vm/compiler/assembler/assembler_riscv.cc
- M runtime/vm/compiler/assembler/assembler_riscv.h
- M runtime/vm/compiler/assembler/assembler_riscv_test.cc
- M runtime/vm/compiler/assembler/disassembler_riscv.cc
- M runtime/vm/compiler/stub_code_compiler_riscv.cc
- M runtime/vm/constants_riscv.h
- M runtime/vm/simulator_riscv.cc
- M runtime/vm/simulator_riscv.h
Change size: L
Delta: 9 files changed, 345 insertions(+), 129 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Aprelev
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages