[M] Change in dart/sdk[main]: linter: Fix false positive with parameter_assignments and negate oper...
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
Apr 21, 2026, 12:33:43 PM (23 hours ago) Apr 21
to Keerti Parthasarathy, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy
Samuel Rawlins voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Keerti Parthasarathy
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keerti Parthasarathy (Gerrit)
Apr 21, 2026, 4:49:50 PM (19 hours ago) Apr 21
to Samuel Rawlins, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Keerti Parthasarathy voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Apr 21, 2026, 5:12:12 PM (18 hours ago) Apr 21
to Keerti Parthasarathy, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 21, 2026, 5:12:31 PM (18 hours ago) Apr 21
to Samuel Rawlins, Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
linter: Fix false positive with parameter_assignments and negate operator
Fixes https://github.com/dart-lang/sdk/issues/61169
The test case is weird. The issue is that `!p` was reported _only after_ `p = true;` is called. So it manifested as a double report. The test case leaves the `p = true;` statement.
The code is otherwise simplified.
Change-Id: I34b6e4ce0f90dc2ab6005e4fe400ca7d608184f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/496440
Reviewed-by: Keerti Parthasarathy <kee...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/linter/lib/src/rules/parameter_assignments.dart
- M pkg/linter/test/rules/parameter_assignments_test.dart
Change size: M
Delta: 2 files changed, 46 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Keerti Parthasarathy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages