[L] Change in dart/sdk[main]: [ Service ] Initial implementation of VM Service based on `package:da...

[Ben Konyi (Gerrit)]

Attention needed from Nicholas Shahan and Ryan Macnak

Ben Konyi voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Nicholas Shahan
• Ryan Macnak

Submit Requirements:

• Code-Owners
• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 4

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ryan Macnak <rma...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 21:22:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ben Konyi (Gerrit)]

Attention needed from Alexander Thomas, Nicholas Shahan and Ryan Macnak

Ben Konyi voted and added 1 comment

Votes added by Ben Konyi

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Ben Konyi . resolved

@at...@google.com for approval to add pkg/dart_runtime_service_vm/

Open in Gerrit

Related details

Attention is currently required from:

• Alexander Thomas
• Nicholas Shahan
• Ryan Macnak

Submit Requirements:

• Code-Owners

• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 5

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Alexander Thomas <at...@google.com>

Gerrit-Attention: Ryan Macnak <rma...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Wed, 04 Mar 2026 18:57:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ryan Macnak (Gerrit)]

Attention needed from Alexander Thomas, Ben Konyi and Nicholas Shahan

Ryan Macnak added 6 comments

Patchset-level comments

File-level comment, Patchset 5:

Ben Konyi . unresolved

@at...@google.com for approval to add pkg/dart_runtime_service_vm/

Ryan Macnak

Add //pkg/dart_runtime_service_vm/OWNERS that looks something like //pkg/vm/OWNERS to give the relevant groups the ability to approve future changes to this package.

File runtime/bin/main_impl.cc

Line 564, Patchset 6 (Parent): flags->load_vmservice_library = true;

Ryan Macnak . resolved

Mostly a complaint about how things are already loaded: this shouldn't need any VM change at all, just a `main() => if (bool.fromEnvironment()) newVMService() else oldVMService()` in the Dart code. But the existing service isn't even a proper snapshot/kernel file :/

File runtime/bin/vmservice_experimental_impl.cc

Line 1, Patchset 6 (Latest):// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file

Ryan Macnak . unresolved

Can't this be the same as vmservice_impl.cc except for the URI of the main library?

File runtime/vm/dart_api_impl.cc

Line 6401, Patchset 6 (Latest): Dart_NativeEntryResolver resolver = BootstrapNatives::Lookup;
Dart_NativeEntrySymbol symbol_resolver = BootstrapNatives::Symbol;

Ryan Macnak . unresolved

I don't think any API should be exposing the bootstrap natives.

File sdk_args.gni

Line 46, Patchset 6 (Latest): use_experimental_vm_service = false

Ryan Macnak . unresolved

include_experimental_vm_service? Even when this build-time flag is true, another runtime flag must also be passed to VM to actually use it.

File tools/gn.py

Line 566, Patchset 6 (Latest): action='store_true')

Ryan Macnak . unresolved

This should be set on at least one builder?

Open in Gerrit

Related details

Attention is currently required from:

• Alexander Thomas
• Ben Konyi
• Nicholas Shahan

Submit Requirements:

• Code-Owners
• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 6

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ben Konyi <bko...@google.com>

Gerrit-Attention: Alexander Thomas <at...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Wed, 04 Mar 2026 22:12:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ben Konyi <bko...@google.com>

[Alexander Thomas (Gerrit)]

Attention needed from Ben Konyi and Nicholas Shahan

Alexander Thomas added 1 comment

Patchset-level comments

File-level comment, Patchset 5:

Ben Konyi . unresolved

@at...@google.com for approval to add pkg/dart_runtime_service_vm/

Ryan Macnak

Add //pkg/dart_runtime_service_vm/OWNERS that looks something like //pkg/vm/OWNERS to give the relevant groups the ability to approve future changes to this package.

Alexander Thomas

FYI, I don't have concerns about adding this package, re-add me to the attention set when others have approved and I'll stamp it.

Open in Gerrit

Related details

Attention is currently required from:

• Ben Konyi
• Nicholas Shahan

Submit Requirements:

• Code-Owners
• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 6

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ben Konyi <bko...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Thu, 05 Mar 2026 08:36:09 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ben Konyi <bko...@google.com>

Comment-In-Reply-To: Ryan Macnak <rma...@google.com>

[Nicholas Shahan (Gerrit)]

Attention needed from Ben Konyi

Nicholas Shahan added 2 comments

File pkg/dart_runtime_service/lib/src/dart_runtime_service_backend.dart

Line 37, Patchset 6 (Latest): // TODO(bkonyi):

Nicholas Shahan . unresolved

nit: Missing details?

File pkg/dart_runtime_service_vm/pubspec.yaml

Line 17, Patchset 6 (Latest):dev_dependencies:
test: any
vm_service: any

Nicholas Shahan . unresolved

Are there any uses of these dev_dependencies?

Open in Gerrit

Related details

Attention is currently required from:

• Ben Konyi

Submit Requirements:

• Code-Owners
• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 6

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ben Konyi <bko...@google.com>

Gerrit-Comment-Date: Thu, 05 Mar 2026 22:42:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Nicholas Shahan (Gerrit)]

Attention needed from Ben Konyi

Nicholas Shahan voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Ben Konyi

Submit Requirements:

• Code-Owners

• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 6

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ben Konyi <bko...@google.com>

Gerrit-Comment-Date: Thu, 05 Mar 2026 22:42:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ben Konyi (Gerrit)]

Attention needed from Nicholas Shahan and Ryan Macnak

Ben Konyi voted and added 5 comments

Votes added by Ben Konyi

Commit-Queue

+1

5 comments

File pkg/dart_runtime_service/lib/src/dart_runtime_service_backend.dart

Line 37, Patchset 6: // TODO(bkonyi):

Nicholas Shahan . resolved

nit: Missing details?

Ben Konyi

Done

File pkg/dart_runtime_service_vm/pubspec.yaml

Line 17, Patchset 6:dev_dependencies:
test: any
vm_service: any

Nicholas Shahan . resolved

Are there any uses of these dev_dependencies?

Ben Konyi

Nope, these should be removed.

File runtime/vm/dart_api_impl.cc

Line 6401, Patchset 6: Dart_NativeEntryResolver resolver = BootstrapNatives::Lookup;


Dart_NativeEntrySymbol symbol_resolver = BootstrapNatives::Symbol;

Ryan Macnak . unresolved

I don't think any API should be exposing the bootstrap natives.

Ben Konyi

I've updated the function to only expose the `VMService_` natives. Is that more reasonable?

File sdk_args.gni

Line 46, Patchset 6: use_experimental_vm_service = false

Ryan Macnak . resolved

include_experimental_vm_service? Even when this build-time flag is true, another runtime flag must also be passed to VM to actually use it.

Ben Konyi

Done

File tools/gn.py

Line 566, Patchset 6: action='store_true')

Ryan Macnak . unresolved

This should be set on at least one builder?

Ben Konyi

Good idea. I'll set it for one AOT and one JIT builder for now.

Open in Gerrit

Related details

Attention is currently required from:

• Nicholas Shahan
• Ryan Macnak

Submit Requirements:

• Code-Owners

• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 7

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ryan Macnak <rma...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Mon, 09 Mar 2026 14:57:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Nicholas Shahan <nsh...@google.com>

Comment-In-Reply-To: Ryan Macnak <rma...@google.com>

[Ben Konyi (Gerrit)]

Attention needed from Nicholas Shahan and Ryan Macnak

Ben Konyi voted and added 1 comment

Votes added by Ben Konyi

Commit-Queue

+1

1 comment

File tools/gn.py

Line 566, Patchset 6: action='store_true')

Ryan Macnak . resolved

This should be set on at least one builder?

Ben Konyi

Good idea. I'll set it for one AOT and one JIT builder for now.

Ben Konyi

Done

Open in Gerrit

Related details

Attention is currently required from:

• Nicholas Shahan
• Ryan Macnak

Submit Requirements:

• Code-Owners
• Code-Review
• Commit-Message-Has-TEST
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 9

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ryan Macnak <rma...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Mon, 09 Mar 2026 17:58:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ben Konyi (Gerrit)]

Attention needed from Nicholas Shahan and Ryan Macnak

Ben Konyi voted and added 2 comments

Votes added by Ben Konyi

Commit-Queue

+1

2 comments

File runtime/bin/vmservice_experimental_impl.cc

Line 1, Patchset 6:// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file

Ryan Macnak . resolved

Can't this be the same as vmservice_impl.cc except for the URI of the main library?

Ben Konyi

Done

File runtime/vm/dart_api_impl.cc

Line 6401, Patchset 6: Dart_NativeEntryResolver resolver = BootstrapNatives::Lookup;
Dart_NativeEntrySymbol symbol_resolver = BootstrapNatives::Symbol;

Ryan Macnak . resolved

I don't think any API should be exposing the bootstrap natives.

Ben Konyi

I've updated the function to only expose the `VMService_` natives. Is that more reasonable?

Ben Konyi

Done

Open in Gerrit

Related details

Attention is currently required from:

• Nicholas Shahan
• Ryan Macnak

Submit Requirements:

• Code-Owners
• Code-Review
• Commit-Message-Has-TEST

• Core-Library-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 14

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ryan Macnak <rma...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Mon, 09 Mar 2026 21:02:33 +0000

[Ryan Macnak (Gerrit)]

Attention needed from Ben Konyi and Nicholas Shahan

Ryan Macnak voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Ben Konyi
• Nicholas Shahan

Submit Requirements:

• Code-Owners

• Code-Review

• Commit-Message-Has-TEST
• Core-Library-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I4a58cd1fa0a386313baa3d5c5345720231279123

Gerrit-Change-Number: 484820

Gerrit-PatchSet: 15

Gerrit-Owner: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Alexander Thomas <at...@google.com>

Gerrit-Reviewer: Ben Konyi <bko...@google.com>

Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>

Gerrit-Reviewer: Ryan Macnak <rma...@google.com>

Gerrit-CC: Commit Queue <dart-...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Ben Konyi <bko...@google.com>

Gerrit-Attention: Nicholas Shahan <nsh...@google.com>

Gerrit-Comment-Date: Mon, 09 Mar 2026 23:09:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes