[XS] Change in dart/sdk[main]: [dart2wasm] Use == instead of identical for when converting value types
Ömer Ağacan (Gerrit)
Ömer Ağacan added 1 comment![]( "Open in Gerrit")
@nate...@google.com I wasn't sure why we want `identical` here instead of `==`. I would expect that if I have `ref MyStruct` on both sides we should avoid conversion, even though the types may not be identical. Changing this to `==` does not break any tests. Is there a reason why we want `identical` instead of `==`?
Related details
- Nate Biggs
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Biggs (Gerrit)
Nate Biggs added 1 comment![]( "Open in Gerrit")
@nate...@google.com I wasn't sure why we want `identical` here instead of `==`. I would expect that if I have `ref MyStruct` on both sides we should avoid conversion, even though the types may not be identical. Changing this to `==` does not break any tests. Is there a reason why we want `identical` instead of `==`?
`identical` was meant as a quick, cheap short-circuit. I realized that the `isSubtypeOf` check below ends up doing the same equality checks. So in the many cases where the types aren't `==` we end up doing the kind of slow `==` check twice. When they are `==` we don't save much work by doing that full check here.
Related details
- Ömer Ağacan
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ömer Ağacan (Gerrit)
Ömer Ağacan abandoned this change![]( "Open in Gerrit")
Related details
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |