[M] Change in dart/sdk[main]: Use package:record_use for dart2js

0 views
Skip to first unread message

Moritz Sümmermann (Gerrit)

unread,
Mar 17, 2025, 1:49:50 PMMar 17
to Stephen Adams, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org

Moritz Sümmermann added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Moritz Sümmermann . resolved

@s...@google.com Let me know what you think (not a review yet - this is WIP)

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I67b5e3d4aebac6c22b185c77f5cb69025d746a32
Gerrit-Change-Number: 416000
Gerrit-PatchSet: 2
Gerrit-Owner: Moritz Sümmermann <mo...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-Comment-Date: Mon, 17 Mar 2025 17:49:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Moritz Sümmermann (Gerrit)

unread,
Jun 27, 2025, 5:25:27 AMJun 27
to Stephen Adams, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Moritz Sümmermann and Stephen Adams

Moritz Sümmermann voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Moritz Sümmermann
  • Stephen Adams
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCommit-Message-Has-TEST
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I67b5e3d4aebac6c22b185c77f5cb69025d746a32
Gerrit-Change-Number: 416000
Gerrit-PatchSet: 20
Gerrit-Owner: Moritz Sümmermann <mo...@google.com>
Gerrit-Reviewer: Moritz Sümmermann <mo...@google.com>
Gerrit-Reviewer: Stephen Adams <s...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Stephen Adams <s...@google.com>
Gerrit-Attention: Moritz Sümmermann <mo...@google.com>
Gerrit-Comment-Date: Fri, 27 Jun 2025 09:25:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Jun 30, 2025, 4:31:24 AMJun 30
to Moritz Sümmermann, Stephen Adams, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
Attention needed from Moritz Sümmermann and Stephen Adams

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Moritz Sümmermann
  • Stephen Adams
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedCommit-Message-Has-TEST
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I67b5e3d4aebac6c22b185c77f5cb69025d746a32
    Gerrit-Change-Number: 416000
    Gerrit-PatchSet: 21
    Gerrit-Owner: Moritz Sümmermann <mo...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Moritz Sümmermann <mo...@google.com>
    Gerrit-Reviewer: Stephen Adams <s...@google.com>
    Gerrit-CC: Alexander Markov <alexm...@google.com>
    Gerrit-Attention: Stephen Adams <s...@google.com>
    Gerrit-Attention: Moritz Sümmermann <mo...@google.com>
    Gerrit-Comment-Date: Mon, 30 Jun 2025 08:31:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Daco Harkes (Gerrit)

    unread,
    4:50 AM (5 hours ago) 4:50 AM
    to Moritz Sümmermann, Johnni Winther, Stephen Adams, Commit Queue, Alexander Markov, dart2js-te...@google.com, rev...@dartlang.org
    Attention needed from Moritz Sümmermann and Stephen Adams

    Daco Harkes added 2 comments

    Patchset-level comments
    File-level comment, Patchset 23 (Latest):
    Daco Harkes . resolved

    This is not yet ready for review. We cannot land this without a g3 customer migration. Let me know if you need help with the g3 workflow.

    Commit Message
    Line 11, Patchset 23 (Latest):(Internal) customers will have to migrated.
    Daco Harkes . unresolved

    You can clone the failing g3 cl, migrate the customers and port the require changes to a separate g3 cl, and attach that CL to the cbuild. That should make it green here. (We cannot land this Gerrit CL without that.)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Moritz Sümmermann
    • Stephen Adams
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedCommit-Message-Has-TEST
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: I67b5e3d4aebac6c22b185c77f5cb69025d746a32
      Gerrit-Change-Number: 416000
      Gerrit-PatchSet: 23
      Gerrit-Owner: Moritz Sümmermann <mo...@google.com>
      Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
      Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
      Gerrit-Reviewer: Moritz Sümmermann <mo...@google.com>
      Gerrit-Reviewer: Stephen Adams <s...@google.com>
      Gerrit-CC: Alexander Markov <alexm...@google.com>
      Gerrit-Attention: Stephen Adams <s...@google.com>
      Gerrit-Attention: Moritz Sümmermann <mo...@google.com>
      Gerrit-Comment-Date: Mon, 29 Sep 2025 08:50:25 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages