[XL] Change in dart/sdk[main]: [analyzer/linter] Document message parameter names and types.

0 views
Skip to first unread message

Paul Berry (Gerrit)

unread,
Aug 8, 2025, 1:17:45 PM8/8/25
to Konstantin Shcheglov, Johnni Winther, Brian Wilkerson, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Johnni Winther, Konstantin Shcheglov and Phil Quitslund

Paul Berry added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Paul Berry . resolved

Requesting review from:

  • Konstantin or Johnni on changes to `pkg/analyzer`
  • Phil or Brian on changes to `pkg/linter` (Brian because he's been part of the design discussions for this change; Phil because Brian is out today)
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Johnni Winther
  • Konstantin Shcheglov
  • Phil Quitslund
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
Gerrit-Change-Number: 444365
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Berry <paul...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Phil Quitslund <pquit...@google.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 17:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Aug 8, 2025, 1:20:52 PM8/8/25
to Paul Berry, Johnni Winther, Brian Wilkerson, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson, Johnni Winther, Paul Berry and Phil Quitslund

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Johnni Winther
  • Paul Berry
  • Phil Quitslund
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
    Gerrit-Change-Number: 444365
    Gerrit-PatchSet: 1
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Attention: Johnni Winther <johnni...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Phil Quitslund <pquit...@google.com>
    Gerrit-Comment-Date: Fri, 08 Aug 2025 17:20:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Johnni Winther (Gerrit)

    unread,
    Aug 11, 2025, 4:17:57 AM8/11/25
    to Paul Berry, Konstantin Shcheglov, Brian Wilkerson, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson, Paul Berry and Phil Quitslund

    Johnni Winther voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Paul Berry
    • Phil Quitslund
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
    Gerrit-Change-Number: 444365
    Gerrit-PatchSet: 2
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Phil Quitslund <pquit...@google.com>
    Gerrit-Comment-Date: Mon, 11 Aug 2025 08:17:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    Aug 11, 2025, 12:26:21 PM8/11/25
    to Paul Berry, Johnni Winther, Konstantin Shcheglov, Brian Wilkerson, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson, Paul Berry and Phil Quitslund

    Samuel Rawlins voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Paul Berry
    • Phil Quitslund
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
    Gerrit-Change-Number: 444365
    Gerrit-PatchSet: 2
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Phil Quitslund <pquit...@google.com>
    Gerrit-Comment-Date: Mon, 11 Aug 2025 16:26:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Brian Wilkerson (Gerrit)

    unread,
    Aug 11, 2025, 12:51:00 PM8/11/25
    to Paul Berry, Brian Wilkerson, Samuel Rawlins, Johnni Winther, Konstantin Shcheglov, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Paul Berry and Phil Quitslund

    Brian Wilkerson voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Paul Berry
    • Phil Quitslund
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
    Gerrit-Change-Number: 444365
    Gerrit-PatchSet: 2
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Phil Quitslund <pquit...@google.com>
    Gerrit-Comment-Date: Mon, 11 Aug 2025 16:50:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Berry (Gerrit)

    unread,
    Aug 11, 2025, 6:14:14 PM8/11/25
    to Brian Wilkerson, Samuel Rawlins, Johnni Winther, Konstantin Shcheglov, Phil Quitslund, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Phil Quitslund

    Paul Berry voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Phil Quitslund
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
    Gerrit-Change-Number: 444365
    Gerrit-PatchSet: 3
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Phil Quitslund <pquit...@google.com>
    Gerrit-Comment-Date: Mon, 11 Aug 2025 22:14:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Aug 11, 2025, 6:51:03 PM8/11/25
    to Paul Berry, Brian Wilkerson, Samuel Rawlins, Johnni Winther, Konstantin Shcheglov, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Unreviewed changes

    2 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [analyzer/linter] Document message parameter names and types.

    The code generation for diagnostic codes is changed so that parameter
    names and their types show up in the auto-generated doc comments. When
    we begin the transition to reporting diagnostics using a
    statically-checked API, these comments should make it easier to figure
    out what parameters to pass in.
    Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Commit-Queue: Paul Berry <paul...@google.com>
    Reviewed-by: Johnni Winther <johnni...@google.com>
    Files:
    • M pkg/_fe_analyzer_shared/lib/src/scanner/errors.g.dart
    • M pkg/analyzer/lib/src/analysis_options/error/option_codes.g.dart
    • M pkg/analyzer/lib/src/dart/error/ffi_code.g.dart
    • M pkg/analyzer/lib/src/dart/error/hint_codes.g.dart
    • M pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart
    • M pkg/analyzer/lib/src/error/codes.g.dart
    • M pkg/analyzer/lib/src/manifest/manifest_warning_code.g.dart
    • M pkg/analyzer/lib/src/pubspec/pubspec_warning_code.g.dart
    • M pkg/analyzer/tool/messages/error_code_info.dart
    • M pkg/linter/lib/src/lint_codes.g.dart
    Change size: XL
    Delta: 10 files changed, 904 insertions(+), 868 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Samuel Rawlins, +1 by Johnni Winther, +1 by Konstantin Shcheglov, +1 by Brian Wilkerson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b33ccd5b5d5a24001da2e1af2cd31cc30366e6a
    Gerrit-Change-Number: 444365
    Gerrit-PatchSet: 4
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages