[L] Change in dart/sdk[main]: Fine. Fix NPE when constant expression uses operator of unnamed exten...
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Oct 19, 2025, 8:28:42 PM (2 days ago) Oct 19
to Paul Berry, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry
Konstantin Shcheglov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Oct 19, 2025, 10:32:54 PM (2 days ago) Oct 19
to Konstantin Shcheglov, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Konstantin Shcheglov
Paul Berry voted and added 4 comments![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
4 comments
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Paul Berry . resolved
lgtm assuming review comments are addressed
File pkg/analyzer/test/src/dart/analysis/driver_test.dart
Line 73806, Patchset 5 (Latest):
const a = -'' + 1;Paul Berry . unresolved
This is an invalid constant, right?
So the purpose of the test is just to make sure the implementation doesn't crash?
Assuming that's correct, could you include a comment explaining tha, so that readers of the test won't be confused?
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Oct 19, 2025, 11:38:15 PM (2 days ago) Oct 19
to Paul Berry, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Konstantin Shcheglov added 3 comments![]( "Open in Gerrit")
File pkg/analyzer/test/src/dart/analysis/driver_test.dart
This is an invalid constant, right?
So the purpose of the test is just to make sure the implementation doesn't crash?
Assuming that's correct, could you include a comment explaining tha, so that readers of the test won't be confused?
Konstantin Shcheglov
Done
Line 73888, Patchset 5:
const b = 0.length + 1;Paul Berry . resolved
Konstantin ShcheglovSame issue here
Done
Line 73955, Patchset 5:
const a = -'' + 1;Paul Berry . resolved
Konstantin ShcheglovSame issue here
Done
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Oct 20, 2025, 5:16:34 AM (yesterday) Oct 20
to Konstantin Shcheglov, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Oct 20, 2025, 1:07:33 PM (yesterday) Oct 20
to Johnni Winther, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Oct 20, 2025, 1:07:44 PM (yesterday) Oct 20
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fine. Fix NPE when constant expression uses operator of unnamed extension.
Change-Id: I2a7da9296996bb7701e4815c6b720b49e19ac1c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455900
Reviewed-by: Paul Berry <paul...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Files:
- M pkg/analyzer/lib/src/dart/analysis/driver.dart
- M pkg/analyzer/lib/src/fine/manifest_ast.dart
- M pkg/analyzer/test/src/dart/analysis/driver_test.dart
- M pkg/analyzer/test/src/dart/analysis/result_printer.dart
Change size: L
Delta: 4 files changed, 283 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry, +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages