[XS] Change in dart/sdk[main]: Roll dart_style into the SDK.
0 views
Skip to first unread message
Bob Nystrom (Gerrit)
Jun 8, 2026, 7:43:47 PMJun 8
to Alexander Thomas, Nate Bosch, Leaf Petersen, rev...@dartlang.org
Attention needed from Alexander Thomas
Bob Nystrom voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alexander Thomas
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Thomas (Gerrit)
Jun 9, 2026, 1:45:09 AMJun 9
to Bob Nystrom, dart-...@luci-project-accounts.iam.gserviceaccount.com, Nate Bosch, Leaf Petersen, rev...@dartlang.org
Attention needed from Bob Nystrom
Alexander Thomas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Thomas
| Code-Review | +1 |
1 comment
File CHANGELOG.md
Line 132, Patchset 2 (Latest):
#### Dart format
- Fix a crash bug in `dart format` if an `analysis_options.yaml` file has an
include that points to a non-existent file (issue [#1840][dart_style #1840]).
[dart_style #1840]: https://github.com/dart-lang/dart_style/issues/1840
Alexander Thomas . unresolved
Hmm, not sure we need this. The changelog will eventually also contain the previous stable release that duplicates this text.
Related details
Attention is currently required from:
- Bob Nystrom
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bob Nystrom (Gerrit)
Jun 9, 2026, 9:32:36 AMJun 9
to Alexander Thomas, dart-...@luci-project-accounts.iam.gserviceaccount.com, Nate Bosch, Leaf Petersen, rev...@dartlang.org
Bob Nystrom voted and added 1 comment![]( "Open in Gerrit")
Votes added by Bob Nystrom
| Auto-Submit | +1 |
- Fix a crash bug in `dart format` if an `analysis_options.yaml` file has an
include that points to a non-existent file (issue [#1840][dart_style #1840]).
[dart_style #1840]: https://github.com/dart-lang/dart_style/issues/1840
Alexander Thomas . resolved
Hmm, not sure we need this. The changelog will eventually also contain the previous stable release that duplicates this text.
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bob Nystrom (Gerrit)
Jun 9, 2026, 9:32:46 AMJun 9
to Alexander Thomas, dart-...@luci-project-accounts.iam.gserviceaccount.com, Nate Bosch, Leaf Petersen, rev...@dartlang.org
Bob Nystrom voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 9, 2026, 10:07:13 AMJun 9
to Bob Nystrom, Alexander Thomas, Nate Bosch, Leaf Petersen, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: CHANGELOG.md
Insertions: 0, Deletions: 7.
@@ -129,13 +129,6 @@
[analyzer plugins]: https://dart.dev/tools/analyzer-plugins
-#### Dart format
-
-- Fix a crash bug in `dart format` if an `analysis_options.yaml` file has an
- include that points to a non-existent file (issue [#1840][dart_style #1840]).
-
-[dart_style #1840]: https://github.com/dart-lang/dart_style/issues/1840
-
These changes are not language versioned and affect formatting all code:
- Fix a bug where some collections or arguments might split unnecessarily.
```
Change information
Commit message:
Roll dart_style into the SDK.
This doesn't roll the latest dart_style main branch in because that has some style changes and there are other style changes still in flight. I want to roll all of those in all in one batch later.
Instead, this brings in a single commit whose parent is the current dart_style commit in the SDK. That commit contains only a fix for a crash bug when an analysis_options.yaml file contains an include pointing to a non-existent file. See:
https://github.com/dart-lang/dart_style/pull/1855
This gets the main branch in sync with the stable branch which has a cherry-pick with that same fix.
Change-Id: I97e3adec1c93175d372bb972989fe6a2860cf31f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510222
Auto-Submit: Bob Nystrom <rnys...@google.com>
Commit-Queue: Bob Nystrom <rnys...@google.com>
Reviewed-by: Alexander Thomas <at...@google.com>
Files:
- M CHANGELOG.md
- M DEPS
Change size: XS
Delta: 2 files changed, 1 insertion(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Thomas
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages