Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[XL] Change in dart/sdk[main]: Revert "Migrate to use pub workspace"
0 views
Skip to first unread message
Alexander Thomas (Gerrit)
Mar 14, 2025, 11:14:05 AMMar 14
to Sigurd Meldgaard, Commit Queue, Alexander Markov, Jens Johansen, Paul Berry, dart-analys...@google.com, dart-dc-te...@google.com, dart-fe-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Sigurd Meldgaard
Alexander Thomas voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Sigurd Meldgaard
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sigurd Meldgaard (Gerrit)
Mar 14, 2025, 11:15:15 AMMar 14
to Alexander Thomas, Commit Queue, Alexander Markov, Jens Johansen, Paul Berry, dart-analys...@google.com, dart-dc-te...@google.com, dart-fe-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Sigurd Meldgaard voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
Commit-Message-Has-TEST
Core-Library-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 14, 2025, 12:08:25 PMMar 14
to Sigurd Meldgaard, Alexander Thomas, Alexander Markov, Jens Johansen, Paul Berry, dart-analys...@google.com, dart-dc-te...@google.com, dart-fe-te...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org, vm-...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Revert "Migrate to use pub workspace"
This reverts commit b9b77058a9fa6430603b81b601fdc0c031cb9f63.
Revert "Add missing sample pubspec to workspace"
This reverts commit 892ea15ac73f0a89b080135d70f9ff35b0edcfc0.
These seem to break the engine.
Change-Id: Ieee26deb7928c3869a1b6265326c3ce568ffe731
Tested: this is a revert.
CoreLibraryReviewExempt: this is a revert
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415582
Commit-Queue: Sigurd Meldgaard <sig...@google.com>
Reviewed-by: Alexander Thomas <at...@google.com>
Files:
- M .gitignore
- M pkg/_fe_analyzer_shared/pubspec.yaml
- M pkg/_js_interop_checks/pubspec.yaml
- M pkg/_macros/pubspec.yaml
- M pkg/analysis_server/pubspec.yaml
- M pkg/analysis_server_client/pubspec.yaml
- M pkg/analysis_server_plugin/pubspec.yaml
- M pkg/analyzer/pubspec.yaml
- M pkg/analyzer_cli/pubspec.yaml
- M pkg/analyzer_plugin/pubspec.yaml
- M pkg/analyzer_utilities/pubspec.yaml
- M pkg/async_helper/pubspec.yaml
- M pkg/bisect_dart/pubspec.yaml
- M pkg/build_integration/pubspec.yaml
- M pkg/compiler/pubspec.yaml
- M pkg/dart2bytecode/pubspec.yaml
- M pkg/dart2js_info/pubspec.yaml
- M pkg/dart2js_runtime_metrics/pubspec.yaml
- M pkg/dart2js_tools/pubspec.yaml
- M pkg/dart2native/pubspec.yaml
- M pkg/dart2wasm/pubspec.yaml
- M pkg/dart_internal/pubspec.yaml
- M pkg/dart_service_protocol_shared/pubspec.yaml
- M pkg/dartdev/pubspec.yaml
- M pkg/dds/pubspec.yaml
- M pkg/dds_service_extensions/pubspec.yaml
- M pkg/dev_compiler/pubspec.yaml
- M pkg/dtd/pubspec.yaml
- M pkg/dtd_impl/pubspec.yaml
- M pkg/dynamic_modules/pubspec.yaml
- M pkg/expect/pubspec.yaml
- M pkg/front_end/pubspec.yaml
- D pkg/front_end/testcases/pubspec.yaml
- M pkg/frontend_server/pubspec.yaml
- M pkg/heap_snapshot/pubspec.yaml
- M pkg/js/pubspec.yaml
- M pkg/js_ast/pubspec.yaml
- M pkg/js_runtime/pubspec.yaml
- M pkg/js_shared/pubspec.yaml
- M pkg/kernel/pubspec.yaml
- M pkg/linter/pubspec.yaml
- M pkg/macros/pubspec.yaml
- M pkg/meta/pubspec.yaml
- M pkg/mmap/pubspec.yaml
- M pkg/modular_test/pubspec.yaml
- M pkg/native_stack_traces/pubspec.yaml
- M pkg/node_preamble/pubspec.yaml
- M pkg/record_use/pubspec.yaml
- M pkg/reload_test/pubspec.yaml
- M pkg/scrape/pubspec.yaml
- M pkg/server_plugin/pubspec.yaml
- M pkg/smith/pubspec.yaml
- M pkg/sourcemap_testing/pubspec.yaml
- M pkg/status_file/pubspec.yaml
- M pkg/telemetry/pubspec.yaml
- M pkg/test_runner/pubspec.yaml
- M pkg/testing/pubspec.yaml
- M pkg/vm/pubspec.yaml
- M pkg/vm_service/pubspec.yaml
- M pkg/vm_service/test/test_package/pubspec.yaml
- M pkg/vm_service_interface/pubspec.yaml
- M pkg/vm_service_protos/pubspec.yaml
- M pkg/vm_snapshot_analysis/pubspec.yaml
- M pkg/wasm_builder/pubspec.yaml
- D pubspec.yaml
- M runtime/tools/heapsnapshot/pubspec.yaml
- M samples/ffi/http/pubspec.yaml
- M sdk/lib/js_util/js_util.dart
- M third_party/pkg/dap/pubspec.yaml
- M third_party/pkg/language_server_protocol/pubspec.yaml
- M tools/generate_package_config.dart
- M tools/package_deps/pubspec.yaml
- M tools/pubspec.yaml
- M tools/run_offsets_extractor.dart
Change size: XL
Delta: 74 files changed, 818 insertions(+), 542 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Thomas
Core-Library-Review: Code-Review+1 by Alexander Thomas
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages