Samuel Rawlins (Gerrit)

unread,

Dec 10, 2025, 1:06:23 PM12/10/25

to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson

Samuel Rawlins voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Dec 10, 2025, 1:23:15 PM12/10/25

to Samuel Rawlins, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Samuel Rawlins

Brian Wilkerson voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Commit Queue (Gerrit)

unread,

Dec 10, 2025, 1:23:33 PM12/10/25

to Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:

analyzer_testing: Add mixed-in types; other fixes

My generator was not writing "with clauses," so this corrects that.

Additionally:

* `Diagnosticable.debugFillProperties` has annotations that I missed.
* `DiagnosticableTree.debugDescribeChildren` has an annotation that I
  missed, and can be abstract.
* VoidCallback was moved to `dart:ui`, and I had missed this.

Change-Id: I6c4c79a1532ede84e8fdbeed754662b67e5c8282

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/467380

Reviewed-by: Brian Wilkerson <brianwi...@google.com>

Commit-Queue: Brian Wilkerson <brianwi...@google.com>

Auto-Submit: Samuel Rawlins <sraw...@google.com>

Files:

M pkg/analyzer_testing/lib/src/mock_packages/flutter/animation/animation_controller.dart
M pkg/analyzer_testing/lib/src/mock_packages/flutter/foundation/assertions.dart
M pkg/analyzer_testing/lib/src/mock_packages/flutter/foundation/diagnostics.dart
M pkg/analyzer_testing/lib/src/mock_packages/flutter/painting/borders.dart
M pkg/analyzer_testing/lib/src/mock_packages/flutter/widgets/framework.dart
M pkg/analyzer_testing/lib/src/mock_packages/flutter/widgets/navigator.dart
M pkg/analyzer_testing/lib/src/mock_packages/ui/ui.dart

Change size: S

Delta: 7 files changed, 19 insertions(+), 7 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Brian Wilkerson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[S] Change in dart/sdk[main]: analyzer_testing: Add mixed-in types; other fixes

Samuel Rawlins (Gerrit)

Samuel Rawlins voted Auto-Submit+1

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson voted

Related details

Commit Queue (Gerrit)

Commit Queue submitted the change

Change information