[M] Change in dart/sdk[main]: [vm/ffi] FFI static type checks to handle invalid function types
0 views
Skip to first unread message
Daco Harkes (Gerrit)
Jun 22, 2026, 2:13:50 PM (2 days ago) Jun 22
to Liam Appelbe, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, rev...@dartlang.org
Attention needed from Liam Appelbe
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Liam Appelbe
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liam Appelbe (Gerrit)
Jun 22, 2026, 6:09:24 PM (2 days ago) Jun 22
to Daco Harkes, Liam Appelbe, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, rev...@dartlang.org
Attention needed from Daco Harkes
Liam Appelbe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Liam Appelbe
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Liam Appelbe . resolved
LGTM once analysis errors are fixed: https://ci.chromium.org/ui/p/dart/builders/try/pkg-mac-release-arm64-try/1721/overview
Related details
Attention is currently required from:
- Daco Harkes
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daco Harkes (Gerrit)
4:54 AM (7 hours ago) 4:54 AM
to Liam Appelbe, dart-...@luci-project-accounts.iam.gserviceaccount.com, Alexander Markov, rev...@dartlang.org
Attention needed from Liam Appelbe
Daco Harkes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daco Harkes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Liam Appelbe . resolved
LGTM once analysis errors are fixed: https://ci.chromium.org/ui/p/dart/builders/try/pkg-mac-release-arm64-try/1721/overview
Daco Harkes
Seems we can't have static errors in those test cases.
Lets stick with only the other test then. The other test wouldn't pass if the compiler crashes, so it covers the repro already.
Related details
Attention is currently required from:
- Liam Appelbe
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages