[S] Change in dart/sdk[main]: [dartdev] Remove resolved TODO for DynamicLibrary.openFromAssetId in ...

0 views
Skip to first unread message

Jaime Wren (Gerrit)

unread,
Jul 14, 2026, 5:28:09 PM (2 days ago) Jul 14
to Ben Konyi, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Ben Konyi

Jaime Wren voted Commit-Queue+0

Commit-Queue+0
Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I894091e1bb73a0479051b15ce0b28d0ae2c810a8
Gerrit-Change-Number: 524263
Gerrit-PatchSet: 1
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jaime Wren <jw...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Comment-Date: Tue, 14 Jul 2026 21:28:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daco Harkes (Gerrit)

unread,
Jul 15, 2026, 3:01:51 PM (10 hours ago) Jul 15
to Jaime Wren, Ben Konyi, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Jaime Wren

Daco Harkes added 1 comment

File pkg/dartdev/test/native_assets/test_test.dart
Line 164, Patchset 1 (Parent): // TODO(https://github.com/dart-lang/sdk/issues/63295): Use
Daco Harkes . unresolved

The support for `DynamicLibrary.openAsset` hasn't landed yet in Flutter. And I have not migrated the test project upstream on dart-lang/native to use `DynamicLibrary.openAsset` yet.

(It's a mystery to me why the tests are green!)

Open in Gerrit

Related details

Attention is currently required from:
  • Jaime Wren
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I894091e1bb73a0479051b15ce0b28d0ae2c810a8
Gerrit-Change-Number: 524263
Gerrit-PatchSet: 1
Gerrit-Owner: Jaime Wren <jw...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Attention: Jaime Wren <jw...@google.com>
Gerrit-Comment-Date: Wed, 15 Jul 2026 19:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages