[S] Change in dart/sdk[main]: [analysis_server] Add tests for move-params-left refactor for Primary...

0 views
Skip to first unread message

Danny Tuppeny (Gerrit)

unread,
Mar 9, 2026, 10:22:44 AM (17 hours ago) Mar 9
to Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Danny Tuppeny added 2 comments

File pkg/analysis_server/test/src/services/refactoring/move_selected_formal_parameters_left_test.dart
Line 111, Patchset 1 (Latest): }
Danny Tuppeny . unresolved

Note: this CL depends on https://dart-review.googlesource.com/c/sdk/+/485822, and also depends on the formatter (so the bots won't pass yet, except if I comment out the format calls).

I'll rebase this once (and the other CL) once the formatter is updated.

Line 113, Patchset 1 (Latest): Future<void> test_primaryConstructor() async {
Danny Tuppeny . unresolved

Let me know if you can think of any other cases to test. I feel like all the other cases added to the previous change (`new`, `factory` etc.) and having empty bodies are not useful here since the changes only took param/argument lists.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I48ada3209032f40d1c9ca7de9b41699fae8ab8a1
Gerrit-Change-Number: 486382
Gerrit-PatchSet: 1
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 14:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Mar 9, 2026, 10:45:23 AM (16 hours ago) Mar 9
to Danny Tuppeny, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny and Samuel Rawlins

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review+1

1 comment

File pkg/analysis_server/test/src/services/refactoring/move_selected_formal_parameters_left_test.dart
Line 113, Patchset 1 (Latest): Future<void> test_primaryConstructor() async {
Danny Tuppeny . resolved

Let me know if you can think of any other cases to test. I feel like all the other cases added to the previous change (`new`, `factory` etc.) and having empty bodies are not useful here since the changes only took param/argument lists.

Brian Wilkerson

I think these are sufficient.

Open in Gerrit

Related details

Attention is currently required from:
  • Danny Tuppeny
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I48ada3209032f40d1c9ca7de9b41699fae8ab8a1
Gerrit-Change-Number: 486382
Gerrit-PatchSet: 1
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Mon, 09 Mar 2026 14:45:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Danny Tuppeny <da...@tuppeny.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Mar 9, 2026, 11:13:17 AM (16 hours ago) Mar 9
to Danny Tuppeny, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danny Tuppeny
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I48ada3209032f40d1c9ca7de9b41699fae8ab8a1
    Gerrit-Change-Number: 486382
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Mon, 09 Mar 2026 15:13:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages