[S] Change in dart/sdk[main]: [dart2wasm] Use Expect.listEquals instead of home-rolled solution

0 views
Skip to first unread message

Kevin Moore (Gerrit)

unread,
Dec 17, 2025, 10:22:09 PM (4 days ago) Dec 17
to Ömer Ağacan, Martin Kustermann, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann and Ömer Ağacan

Kevin Moore voted and added 1 comment

Votes added by Kevin Moore

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kevin Moore . resolved

Just looking around. Seemed reasonable

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
  • Ömer Ağacan
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ida9bf4d7f4ace30ed51240b854212b330309f65c
Gerrit-Change-Number: 469000
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 03:22:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Ömer Ağacan (Gerrit)

unread,
Dec 18, 2025, 4:24:31 AM (4 days ago) Dec 18
to Kevin Moore, Commit Queue, Martin Kustermann, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Kevin Moore and Martin Kustermann

Ömer Ağacan voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kevin Moore
  • Martin Kustermann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ida9bf4d7f4ace30ed51240b854212b330309f65c
Gerrit-Change-Number: 469000
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Kevin Moore <kev...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Ömer Ağacan <ome...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Attention: Kevin Moore <kev...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 09:24:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 18, 2025, 4:24:45 AM (4 days ago) Dec 18
to Kevin Moore, Ömer Ağacan, Martin Kustermann, dart2wasm-t...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[dart2wasm] Use Expect.listEquals instead of home-rolled solution
Change-Id: Ida9bf4d7f4ace30ed51240b854212b330309f65c
Auto-Submit: Kevin Moore <kev...@google.com>
Commit-Queue: Ömer Ağacan <ome...@google.com>
Reviewed-by: Ömer Ağacan <ome...@google.com>
Files:
  • M pkg/dart2wasm/test/self_compile_test.dart
  • M pkg/dart2wasm/test/wasm_read_write_test.dart
Change size: S
Delta: 2 files changed, 4 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ömer Ağacan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ida9bf4d7f4ace30ed51240b854212b330309f65c
Gerrit-Change-Number: 469000
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Moore <kev...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages